Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp3523317pxb; Sun, 20 Feb 2022 23:06:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxr0cGzb6GQ6Q/lkgFkyMJHpeLAZPdagtpyWeXRqjxzyBopXDp+7qTXGWMXbjkkBfHYR2x5 X-Received: by 2002:a05:6402:17d9:b0:410:aaaf:6467 with SMTP id s25-20020a05640217d900b00410aaaf6467mr20507114edy.38.1645427202853; Sun, 20 Feb 2022 23:06:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645427202; cv=none; d=google.com; s=arc-20160816; b=K9q+MBi92DqU8BkwhCdUr+ih/paNuANXtKg2aFS3vKXpEw/J4KEGLsNfshRW8owF+K 7QAMvy5OYxxr3EHGutUyIZX53PCEBeyw73dN9pZ/x+8geY4fkSAfAUTnduKINAG1h/Vt kisl381EloldzQ4w7EWPJdwms9CHp3Kes+42T5+LRF2Z3SeRG9+sMJM+AUQNpm7Vv8eN bbvBBnr5/hA0dcVAZ1rXGnf5XS1mcQDeuFwBY2Bx76RvtiQDtUqwyrjKp4fgABNHFOh3 AfzJV3wYev3ZyoySzdFyxbVDSEbT5PHplt3VcFdr1ae2yCYNfdqwuvxuGo7E+CW79n7F rkeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=lu+z9wDe3Dj5HFygWUr4EswmIj2GifCPehbF0kUQbho=; b=XBsHctxxGpdm0ikokX9t4RbYzVySka6WqLin1+3O94mnMdDVsa4ddAE+P6gBCycyUY b3kipYADkzn6Wr7jvZPYmNMMyLPl8xJ+b7YzBfe6tA+oYmX0+A9HL6bZXCZoqq6oMaIL IbDbF1qx1UeI/lmX06dvMzcycVUwiAcFZgrBQ+OfuYPvGOfZ15WRzsRXtbBzcBO9WoM5 +3/Sp4VAOI6NsDCaj05vM/W5u1IVC3LuABWegwW0XooByvfvoNkT0sJNucTyBbIyxa6E jJI+8wGWnjN2F7snxaSKvNDsY+buUglhI07IKHr1OtlTbF06PT8VDHwKHMJ76WU4gPae wrLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14si4858814edz.95.2022.02.20.23.06.18; Sun, 20 Feb 2022 23:06:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241448AbiBSHKh (ORCPT + 99 others); Sat, 19 Feb 2022 02:10:37 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241524AbiBSHKc (ORCPT ); Sat, 19 Feb 2022 02:10:32 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B74C425AE43; Fri, 18 Feb 2022 23:10:10 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 008BD68D05; Sat, 19 Feb 2022 08:10:07 +0100 (CET) Date: Sat, 19 Feb 2022 08:10:07 +0100 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 12/22] staging: emxx_udc: Don't use GFP_DMA when calling dma_alloc_coherent() Message-ID: <20220219071007.GL26505@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-13-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220219005221.634-13-bhe@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 19, 2022 at 08:52:11AM +0800, Baoquan He wrote: > dma_alloc_coherent() allocates dma buffer with device's addressing > limitation in mind. It's redundent to specify GFP_DMA when calling > dma_alloc_coherent(). Looks good: Reviewed-by: Christoph Hellwig