Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kavyasree.Kotagiri@microchip.com>
To:     <michael@walle.cc>
CC:     <Manohar.Puri@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <alexandre.belloni@bootlin.com>, <arnd@arndb.de>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <Nicolas.Ferre@microchip.com>,
        <olof@lixom.net>, <robh+dt@kernel.org>, <soc@kernel.org>
Subject: RE: [PATCH v4] ARM: dts: add DT for lan966 SoC and 2-port board
 pcb8291
Thread-Topic: [PATCH v4] ARM: dts: add DT for lan966 SoC and 2-port board
 pcb8291
Thread-Index: AQHYHaYU1qtS5sG/10aA2sqGSWL+96yLj0MAgAD4oLCAAAQRgIAAFAoQgAARrQCADJaDQIAAA5+AgAREUaA=
Date:   Mon, 21 Feb 2022 05:44:21 +0000
Message-ID: <CO1PR11MB4865E667CB963C8B5DE5000B923A9@CO1PR11MB4865.namprd11.prod.outlook.com>
References: <20220209111318.21112-1-kavyasree.kotagiri@microchip.com>
 <20220209184600.1230365-1-michael@walle.cc>
 <CO1PR11MB486534A2987684CC7402CE06922F9@CO1PR11MB4865.namprd11.prod.outlook.com>
 <97bcfa4417d5f8c41cc6aa1e411c8747@walle.cc>
 <CO1PR11MB4865E913D083C1D80D4E1F80922F9@CO1PR11MB4865.namprd11.prod.outlook.com>
 <b98f40575f88a0bbf205d628f73cccac@walle.cc>
 <CO1PR11MB4865B205DF4490D37E96524792379@CO1PR11MB4865.namprd11.prod.outlook.com>
 <426e31325066cfa9f0ab50860289e12a@walle.cc>
In-Reply-To: <426e31325066cfa9f0ab50860289e12a@walle.cc>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JuTiTn6jIRctDyK+XuNyvVN/9SBx88Ix6/OwQZZ8cPHxZR8wkMt4sy+M3FMo?=
 =?us-ascii?Q?TO/RmGcCUxMOSoIATdHR+aa0/Wjo8iYLsOkGH1JVGbamfzQu2FEjDIF/iJQL?=
 =?us-ascii?Q?uYHRmiGkb3/X0waolJKhibmNfi8BnZX9hHdlfAxIXXFj6WVsEbGx63WJfvW8?=
 =?us-ascii?Q?Ei5emWojOIp7eAfkM9QP/779+JmNfh4aHR0LlmbecuOEZ/u2C5H2Yyawv/63?=
 =?us-ascii?Q?v/UgffmwZ9OkY6k8y7HD2gV5RnTCgTc3sfpN4ko2s9DB53rmxzPKCWHc2uo1?=
 =?us-ascii?Q?ejCbBl466qnsxtunDHUbaSvX9WIU+kjvoYzqWaN7xiz/DYNki5b4TVtEHzXR?=
 =?us-ascii?Q?/XfL8lvVLwJ1ly4SUmNep63EFU+5PAvb3Zya0bext4t2EZx4bcRhwldjk+v7?=
 =?us-ascii?Q?L1Q0pDRz+amwvsy9YRgnISSl4vm2HwPp3y/9e0OGs6R2BOrUABm5X/2penhQ?=
 =?us-ascii?Q?g0aeMUgiEW8Lv3QMsrpq3ykHQ+39TQuefYnaK7e43erWG9zsJzKOghTBbsDS?=
 =?us-ascii?Q?qeTX0KHX9sAQhA29wkwyX30ru0w+p96V6VocvftVL4XZ7J5OCEWL8y/U59hj?=
 =?us-ascii?Q?yrcZMZBdu577un3R9m5NMq95TCbL0yYAYf4PX19e/5QV44yFJI7U3a+eVW6R?=
 =?us-ascii?Q?WOVqPQzJcWpy1UEJdf4o5OX25Oz2O6l55vbH9szR+qa2Nsf+KtZfA+ou/b56?=
 =?us-ascii?Q?I9bCa3t5J76gdzZqKX7LqGdFlHhwN0hP4xDj3LcLaRBIwoYGzL8tROTpGURN?=
 =?us-ascii?Q?mumJ9Caf6P0bN4z7dny/csZ6nbuyKYq0nQkxegBc4Zzw/YlOZmpwP0yUkURC?=
 =?us-ascii?Q?LUYv/pIRcWr7/n8JMAmfegmslfaIAm3a+gCIKlY8AG2MLRHeckrnlaOVn1pk?=
 =?us-ascii?Q?VvbVwQajOFaoqxe9fhWGG/l3RB9bCpxrTGcWKhzvdN0guCh/o5yx0u1WZCOH?=
 =?us-ascii?Q?AoOQyLaJvehgxFa5wGhxzVhusZ60Cs2bJO5mjyWFX7xAxyzKdgRKQIkeU7tl?=
 =?us-ascii?Q?mOhmdenvvacE15bfHFXbjfxgDQ+gUtDLUy8H+rNXfXGX2TkqutlHU+P5CVn3?=
 =?us-ascii?Q?+08outozbacG4ZLNeQYtEDeLLZAtG/Eu8WiL17vNM6SQZ1vPXwqfPbgKlsaB?=
 =?us-ascii?Q?cj1bG0vRJZ2MtYASvyovjXp4tGGyzMGOPxgEyymig4nsJyfE68THl8/8L8zN?=
 =?us-ascii?Q?sh4U4cJyul9WPT4cwDU+eGso54daKb1UzNmT4nWi0oRuSKCS+/RSqecQWnF0?=
 =?us-ascii?Q?gurNVQTW8CQThm9iBPC6qPSpMCNEgP5wEP0lw8beRWOybwyrgyg4RsR/Tc5J?=
 =?us-ascii?Q?PwgCAR5MUGIfZ3rgtpcN7DJCQ5J8bsZZfy28R53cfhUgY5Hqq0Bl7gWaz5s5?=
 =?us-ascii?Q?jxZMHhOvyWqbB5zro3xpwheurHB4RPtXFJYQh7v1qnIcy7jY8xp5csAzI+KZ?=
 =?us-ascii?Q?x8SY1jCteSYZH1ToxrOzmhL3yfiSToQqqu7c67LMwRZC8K1gw+SGYV2rUG6J?=
 =?us-ascii?Q?YW/q8EfGdiLI3pVZncexweB8lvEFGvOCIMunXlDrawUPX1GpRnFzTsWE5t66?=
 =?us-ascii?Q?WO1XTS1rA26UIYGuuSLP9Mkvbh9QY3Q844IP4XLuax7PETNEA/LirYeBnq4A?=
 =?us-ascii?Q?p0WtUkQNax1ua0e7FMnGWIHFftH5nW9p+G//JSYwigprqYrCVlSLWTbx8CDA?=
 =?us-ascii?Q?/CrWmhP7orlZ4QLeLTRUNhwtlqdB4g2MQA6jWSN9P7qSKIzb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4865.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd320299-093f-4d69-d4e6-08d9f4fd35a0
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 05:44:21.2020
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y05qH8e3Z2wZY8BOtZRBpWRi60dlhlnFQQszsHgwxq/cCG/bZjw2inriC+yaJlN4jWneYnnVTgQUP9/bBwAkqDCIqWAb5kliGTBs3VsZDc+yc1QExgPouwr8lq83wR2n
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2805
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> Am 2022-02-18 13:28, schrieb Kavyasree.Kotagiri@microchip.com:
> >> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> >> the
> >> content is safe
> >>
> >> Am 2022-02-10 12:52, schrieb Kavyasree.Kotagiri@microchip.com:
> >> >> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know
> >> >> the
> >> >> content is safe
> >> >>
> >> >> Am 2022-02-10 10:40, schrieb Kavyasree.Kotagiri@microchip.com:
> >> >> >> EXTERNAL EMAIL: Do not click links or open attachments unless yo=
u
> >> know
> >> >> >> the
> >> >> >> content is safe
> >> >>
> >> >> >> > +     clocks {
> >> >> >> [..]
> >> >> >> > +
> >> >> >> > +             nic_clk: nic_clk {
> >> >> >>
> >> >> >> What does nic_clk stand for? If I had to guess, it
> >> >> >> has something to do with network. But..
> >> >> >>
> >> >> > NIC clock is the clock used by AXI, AHB fabric and APB bridges wh=
ich
> >> >> > connects all the peripherals.
> >> >> > It is named so because the AXI fabric is based on NIC400 IP from =
ARM
> >> >>
> >> >> Ok, thanks for clarification.
> >> >>
> >> >>
> >> >> >> > +             watchdog: watchdog@e0090000 {
> >> >> >> > +                     compatible =3D "snps,dw-wdt";
> >> >> >> > +                     reg =3D <0xe0090000 0x1000>;
> >> >> >> > +                     interrupts =3D <GIC_SPI 38 IRQ_TYPE_LEVE=
L_HIGH>;
> >> >> >> > +                     clocks =3D <&nic_clk>;
> >> >> >>
> >> >> >> Btw. can we disable all nodes by default and enable them
> >> >> >> in the board dts files?
> >> >> > I would like to have only board specific nodes enabled in dts fil=
es
> >> >> > and rest of them in dtsi file
> >> >>
> >> >> And how do you know which ones are board specific? E.g. I would lik=
e
> >> >> to add our board which is also based on the lan9668. Maybe I don't
> >> >> want a watchdog (or whatever node). Of course I could use
> >> >>
> >> >> &watchdog {
> >> >>    status =3D "disabled";
> >> >> };
> >> >>
> >> >> But IMHO opt-in is better. At least thats what we are doing for
> >> >> the layerscape over on arm64.
> >> >>
> >> > Basically, I am disabling only the nodes which have pinctrl settings
> >> > in dtsi file
> >> > and enable in dts to make sure there are no conflicts on pins on the
> >> > board.
> >>
> >> Thats not what I'm asking. I would like to see *optional* nodes
> >> disabled by default. Whether the watchdog is optional might be
> >> debatable, but what about the usb controller and the qspi
> >> controller? They don't have shared pins AFAIK, so according
> >> to your rule, they will be enabled by default and each board
> >> which doesn't have anything connected on these pins would have
> >> to disabled it.
> >>
> >> Please keep in mind that this .dtsi will also be used by boards
> >> not manufactured by microchip.
> >>
> > I agree with you - "disabling optional nodes in dtsi"
> > I have gone through all the nodes.
> > Confirmed and moved enabling optional node watchdog
> > to dts file.
>=20
> Great, I just wanted to get to an agreement how the optional nodes
> should be handled. If it turns out, some are still optional or
> some aren't. It is easy to just mark them disabled and enable them
> in the board dts files in a later patch.
>=20
Sorry, I didn't get you. Do you still see optional nodes in my dtsi?
I think GPIO controller, Interrupt controller, XDMA, timers, AES, SHA, TRNG=
 are
not optional. So, I keep them enabled in dtsi.=20
Please let me know your comments.

> -michael