Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp3558508pxb; Mon, 21 Feb 2022 00:16:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKbqyKJUQ9TP8DpReCFg1J43IlLsinrUz1DrWaoxw9i7oVgP51qjoxqWKwOqWey8YAUUwf X-Received: by 2002:a17:902:6acc:b0:149:8f60:a526 with SMTP id i12-20020a1709026acc00b001498f60a526mr18669302plt.25.1645431380458; Mon, 21 Feb 2022 00:16:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645431380; cv=none; d=google.com; s=arc-20160816; b=oUrg0RQ7vwLujMmx1h4leAlYZg5f1m9FrFb9xTJWVeO0TrBaZC46LN3fSjW3ys+Y5N n2o/kUPKr7psoQcsLDt2kEeLGAb84Mr4VQFE8wYklmkUe9QmKd/Ec/JsxVbKEWeEnzVf V3APLt5p883RRmfDYakUhUBRX+EPIoCzhbuPmVIsO61PaTYGwTX3SrSyaurjYRw0ptA5 ViAUAT9u/WS8BrfWm6Kj8b7qoSrvuoLQSiMTI28eFzxBIbUfJddBZSSJFwPF1jUycaNJ XvtcoxT6ds2YvDavfeNp8mPFVwz7P+1AscNp00Bx/bvMTtPXxBcox5xRbYMekZF4Nb9V g9Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=5Q3RSEfRjRgZDf/8cME03EMs6LC1/71dljJznKEKM+4=; b=cpkvH/9Z3ZU26SJWrVWaOwcB5Kc1XKFRcAc1T0vtZ4fhe4OByu4SbGWccc4I2rwMFI 2pTvC6Vz0STpDRbfMRn8zsZIy2c4nJfJR/ss65+EsEHp1WaOWRk+Gs2yo3xlaDs2Hsbk luuyRczXbZ0zM3+MH2nuInzmnBjZMp+Pu9APc/mPb49EJV6HovT7ynEh3PETI/vdI9mL fWOJeNcwUFU87rqiKuXsrh7hlEptcaaStKPfDx66fUnJib+QoWMD+apmevzqms2rV4Z2 n7VENefaFvOCmS0X8q19VHf80PBQ9Kwafu9OrEcp2LXx7kCK9DAS7BcTl7M1mIFSQhLX qhfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 65si8072348pff.216.2022.02.21.00.15.59; Mon, 21 Feb 2022 00:16:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244301AbiBTRGE (ORCPT + 99 others); Sun, 20 Feb 2022 12:06:04 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229808AbiBTRGC (ORCPT ); Sun, 20 Feb 2022 12:06:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD10E3CA65; Sun, 20 Feb 2022 09:05:40 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 70DFCB80D2C; Sun, 20 Feb 2022 17:05:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09452C340EB; Sun, 20 Feb 2022 17:05:36 +0000 (UTC) Date: Sun, 20 Feb 2022 12:05:35 -0500 From: Steven Rostedt To: tangmeng Cc: mingo@redhat.com, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nizhen@uniontech.com, zhanglianjie@uniontech.com, nixiaoming@huawei.com Subject: Re: [PATCH 02/11] kernel/trace: move stack_tracer_enabled sysctl to its own file Message-ID: <20220220120535.50380537@gandalf.local.home> In-Reply-To: <20220220060017.13285-1-tangmeng@uniontech.com> References: <20220220060017.13285-1-tangmeng@uniontech.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Feb 2022 14:00:17 +0800 tangmeng wrote: > kernel/sysctl.c is a kitchen sink where everyone leaves their dirty > dishes, this makes it very difficult to maintain. > > To help with this maintenance let's start by moving sysctls to places > where they actually belong. The proc sysctl maintainers do not want to > know what sysctl knobs you wish to add for your own piece of code, we > just care about the core logic. > > All filesystem syctls now get reviewed by fs folks. This commit > follows the commit of fs, move the stack_tracer_enabled sysctl to its > own file, kernel/trace/trace_stack.c. > > Signed-off-by: tangmeng Acked-by: Steven Rostedt (Google) -- Steve