Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Feb 2022 02:57:16 +0100
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Dave Kleikamp <dave.kleikamp@oracle.com>
Cc:     linux-kernel@vger.kernel.org, Sumit Garg <sumit.garg@linaro.org>,
        James Bottomley <jejb@linux.ibm.com>,
        Mimi Zohar <zohar@linux.ibm.com>,
        David Howells <dhowells@redhat.com>,
        James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
        linux-security-module@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] KEYS: trusted: Avoid calling null function
 trusted_key_exit
Message-ID: <YhLxfHcCccNUAiIl@kernel.org>
References: <20220126184155.220814-1-dave.kleikamp@oracle.com>
 <YfGtVk/HQjgl1zSS@iki.fi>
 <cda221fd-6481-598f-03ba-29d0b79af8b7@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cda221fd-6481-598f-03ba-29d0b79af8b7@oracle.com>
Precedence: bulk

On Mon, Feb 07, 2022 at 11:40:23AM -0600, Dave Kleikamp wrote:
> On 1/26/22 2:21PM, Jarkko Sakkinen wrote:
> > On Wed, Jan 26, 2022 at 12:41:55PM -0600, Dave Kleikamp wrote:
> > > If one loads and unloads the trusted module, trusted_key_exit can be
> > > NULL. Call it through static_call_cond() to avoid a kernel trap.
> > > 
> > > Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework")
> > > 
> > > Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
> > 
> > Please re-send with cc stable and the empty line removed and I'll pick it.
> 
> I re-sent a v2, but haven't seen any response from you.
> 
> I can send it again, or feel free to clean up those lines yourself.
> 
> Thanks,
> Shaggy

I've applied the patch. Thank you, and apologies for the latency.

BR, Jarkko