Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220220035321.3870-1-warp5tw@gmail.com> <20220220035321.3870-3-warp5tw@gmail.com>
 <1645410969.402841.2041548.nullmailer@robh.at.kernel.org>
In-Reply-To: <1645410969.402841.2041548.nullmailer@robh.at.kernel.org>
From:   Tyrone Ting <warp5tw@gmail.com>
Date:   Mon, 21 Feb 2022 16:31:37 +0800
Message-ID: <CACD3sJaC-8BO9TkunmAfFQOow1rmWxEjhSRE-kekFRM1wmKq2Q@mail.gmail.com>
Subject: Re: [PATCH v2 02/11] dt-bindings: i2c: npcm: support NPCM845
To:     Rob Herring <robh@kernel.org>
Cc:     semen.protsenko@linaro.org, andriy.shevchenko@linux.intel.com,
        yuenn@google.com, digetx@gmail.com, devicetree@vger.kernel.org,
        tmaimon77@gmail.com, krzysztof.kozlowski@canonical.com,
        lukas.bulwahn@gmail.com, Avi.Fishman@nuvoton.com,
        JJLIU0@nuvoton.com, tali.perry1@gmail.com, jie.deng@intel.com,
        openbmc@lists.ozlabs.org, sven@svenpeter.dev,
        linux-i2c@vger.kernel.org, tali.perry@nuvoton.com,
        robh+dt@kernel.org, benjaminfair@google.com,
        tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, olof@lixom.net,
        wsa@kernel.org, kfting@nuvoton.com, avifishman70@gmail.com,
        yangyicong@hisilicon.com, bence98@sch.bme.hu,
        christophe.leroy@csgroup.eu, venture@google.com,
        linux-kernel@vger.kernel.org, arnd@arndb.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rob:

Thank you for your comments and they will be addressed.

Rob Herring <robh@kernel.org> =E6=96=BC 2022=E5=B9=B42=E6=9C=8821=E6=97=A5 =
=E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=8810:36=E5=AF=AB=E9=81=93=EF=BC=9A

>
> On Sun, 20 Feb 2022 11:53:12 +0800, Tyrone Ting wrote:
> > From: Tyrone Ting <kfting@nuvoton.com>
> >
> > Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
> >
> > Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> > Signed-off-by: Tali Perry <tali.perry1@gmail.com>
> > ---
> >  .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml       | 17 ++++++++++++-----
> >  1 file changed, 12 insertions(+), 5 deletions(-)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml:19:6: [w=
arning] wrong indentation: expected 4 but found 5 (indentation)
> ./Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml:20:7: [w=
arning] wrong indentation: expected 7 but found 6 (indentation)
>
> dtschema/dtc warnings/errors:
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/1595125
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>

Best regards,
Tyrone