Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 20 Feb 2022 22:22:57 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        Steven Noonan <steven@valvesoftware.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND v6 4/9] cpupower: Add the function to get the
 sysfs value from specific table
Message-ID: <YhJOwWkPfsGJt84L@amd.com>
References: <20220216073558.751071-1-ray.huang@amd.com>
 <20220216073558.751071-5-ray.huang@amd.com>
 <10708ac3-d33b-90b7-e096-14bccdfab942@linuxfoundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <10708ac3-d33b-90b7-e096-14bccdfab942@linuxfoundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JX2IlzNwATnp3D7Su3MdwUYNhUKM7Cc3HDc35T3b5QihUenOVwXfMnPWOR/z?=
 =?us-ascii?Q?C6SclfZeN31q8ARz6N5Aj2TGnzhFvpStPycUPEjlz5T81Kwbt8j1whKtb2Xc?=
 =?us-ascii?Q?QjdryMPQLvlIjG5zmDKzDq0F40lDOYq3KkLIvwRfZjLtQkE/IYttVzpKFGia?=
 =?us-ascii?Q?6IU2EBfRxmQ0oJ1+IHvtChd9Dz0xIOD+f+xwqRVU0khQMate0g03R6GFxPgQ?=
 =?us-ascii?Q?9XlzaoeXKB61c8k/CLffPCMAIa0MJ3EjOmdpe7SeCY/L2y91Nhv9JN1BeVqt?=
 =?us-ascii?Q?QJtaCk6NHl6HhHyySBG8XOH2JnaxcofC6m/pwDLD3PeYw88c/LfcZvRBGAUh?=
 =?us-ascii?Q?yRwI4+bY+5QhnHknh4kaX3tvRIlyCuNEC+Nk+vLcBQOCyy5X2G2V3vLBmMuI?=
 =?us-ascii?Q?9YNKAw++6fO55i8Llx4wNAxrGX6E3av7gPTjRf+HzQP5Hj9g2i8SlMnPEgHp?=
 =?us-ascii?Q?saNXlFDVsieIsFIeeyy8TXW9PkuZZROrkz5kudRVsxiXqx5wRIekOWwHWtjm?=
 =?us-ascii?Q?pMC304fsR08mveGjQMCDkkyrwO/MXnQaTo4qEUE1F1E97ZW+3Lm0EL09QjQ6?=
 =?us-ascii?Q?5psZofVMd41W0dCIvDxP+v0Xi+igQgnybfEX04iILEWOjCjYWLO4OXi9AqSM?=
 =?us-ascii?Q?KjFoZZK1ekA8d1Hn/N4s8kf1nmuEVbyleqnwZGjnIwEArnJlPUoOpW59b8yj?=
 =?us-ascii?Q?MzZQ29xSuoplQj2AZk7JZ5LSANCtIy7UnEvcuQb9JhDESdWci8xxSfa+UvQK?=
 =?us-ascii?Q?GsE56tHbMTjXxOhicVVdn6NK5u0JVBqD4bx+JLcMRzfLESScx2Da0sEWRLHt?=
 =?us-ascii?Q?GhuWqslUrlMM84TNWlqt2bYY2aVjFFKVdJE1cEdBDYcPFThf7lhnlFdQ0p+m?=
 =?us-ascii?Q?rSobSvwafLTvZSIecfqlQwnKNSr6z8xSQbZQemryD/y6SvkcuTtAvWkTBOtH?=
 =?us-ascii?Q?66aXzx8E5efWMS4Qh903qHwoIrx5KqdH6ACGboKrTpq5jFro5luhOmsL6o6E?=
 =?us-ascii?Q?mbZmjaF5WsvPJZP2Wy8wsmzM4mpAr4N7IzMI84ZiYZ6aPq+roe1nOiucOpcY?=
 =?us-ascii?Q?2q+It2JxNnPcuKvHXnAByHjrV+R235+M0zm6O26AYEuhje+ysM5x2jgIKsav?=
 =?us-ascii?Q?YlNd3QArG55UofltpPQLWOzxCzIIduhcDLdPXBkKJzis1/ml9MpITAuJydyn?=
 =?us-ascii?Q?04FzlPqy3vCnVvKQXqT0DJb/bRuagG/LDWvg38JOR1zm/BgO5VrJwl1J/2pM?=
 =?us-ascii?Q?2KuQsdCM/VWVavvZgNmNMeian/hzqhfu1On7VhRcIbvocUHd69GFu/WDZAt+?=
 =?us-ascii?Q?grb/Gquz4GFbw4IHE31laeaq8/C5QNDCpJfvHE8wyc/lqovHw0eto73vX7/z?=
 =?us-ascii?Q?lUFgOR8S14V1fr27G2axb38oBDn9UO/3zFNkF1/+UuroApGVdRuebYMnY0cp?=
 =?us-ascii?Q?Cn0fR1iBpEyBar2Zi5eXp6wqoBmXl9S8QR56R8ge9D1uqsgdLQfhzvRWSA6q?=
 =?us-ascii?Q?zCzd5D/2UAgWj8eLbYiFdlVJDHyf6DRmdnVWJNb9a8oRtkZGj9EWql1dw+vp?=
 =?us-ascii?Q?CuLHnA9/4Un9WmsCeb0unTel02LLODmquQe3q+0zKaxjmmxH+DxN2+L97iY/?=
 =?us-ascii?Q?LOrAAWoTXKeV3i+rHzAJXrY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db067790-1b26-4e5e-dde1-08d9f47c8c23
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2022 14:23:21.6731
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B2QHHIC56zM8nNcQj0fyvNlTYl8Awckqo+9xaf/Md8iqvGpizm30mY1aVktcRlQh8WxXTGscNOiE3BZyEhWRkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3364
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 19, 2022 at 07:46:46AM +0800, Shuah Khan wrote:
> On 2/16/22 12:35 AM, Huang Rui wrote:
> > Expose the helper into cpufreq header, then cpufreq driver can use this
> > function to get the sysfs value if it has any specific sysfs interfaces.
> > 
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > ---
> >   tools/power/cpupower/lib/cpufreq.c | 21 +++++++++++++++------
> >   tools/power/cpupower/lib/cpufreq.h | 12 ++++++++++++
> >   2 files changed, 27 insertions(+), 6 deletions(-)
> > 
> > diff --git a/tools/power/cpupower/lib/cpufreq.c b/tools/power/cpupower/lib/cpufreq.c
> > index c3b56db8b921..c011bca27041 100644
> > --- a/tools/power/cpupower/lib/cpufreq.c
> > +++ b/tools/power/cpupower/lib/cpufreq.c
> > @@ -83,20 +83,21 @@ static const char *cpufreq_value_files[MAX_CPUFREQ_VALUE_READ_FILES] = {
> >   	[STATS_NUM_TRANSITIONS] = "stats/total_trans"
> >   };
> >   
> > -
> > -static unsigned long sysfs_cpufreq_get_one_value(unsigned int cpu,
> > -						 enum cpufreq_value which)
> > +unsigned long cpufreq_get_sysfs_value_from_table(unsigned int cpu,
> > +						 const char **table,
> > +						 unsigned index,
> 
> unsigned int
> 
> > +						 unsigned size)
> 
> unsigned int
> 
> >   {
> >   	unsigned long value;
> >   	unsigned int len;
> >   	char linebuf[MAX_LINE_LEN];
> >   	char *endp;
> >   
> > -	if (which >= MAX_CPUFREQ_VALUE_READ_FILES)
> > +	if (!table || index >= size || !table[index])
> >   		return 0;
> >   
> > -	len = sysfs_cpufreq_read_file(cpu, cpufreq_value_files[which],
> > -				linebuf, sizeof(linebuf));
> > +	len = sysfs_cpufreq_read_file(cpu, table[index], linebuf,
> > +				      sizeof(linebuf));
> >   
> >   	if (len == 0)
> >   		return 0;
> > @@ -109,6 +110,14 @@ static unsigned long sysfs_cpufreq_get_one_value(unsigned int cpu,
> >   	return value;
> >   }
> >   
> > +static unsigned long sysfs_cpufreq_get_one_value(unsigned int cpu,
> > +						 enum cpufreq_value which)
> > +{
> > +	return cpufreq_get_sysfs_value_from_table(cpu, cpufreq_value_files,
> > +						  which,
> > +						  MAX_CPUFREQ_VALUE_READ_FILES);
> > +}
> > +
> >   /* read access to files which contain one string */
> >   
> >   enum cpufreq_string {
> > diff --git a/tools/power/cpupower/lib/cpufreq.h b/tools/power/cpupower/lib/cpufreq.h
> > index 95f4fd9e2656..107668c0c454 100644
> > --- a/tools/power/cpupower/lib/cpufreq.h
> > +++ b/tools/power/cpupower/lib/cpufreq.h
> > @@ -203,6 +203,18 @@ int cpufreq_modify_policy_governor(unsigned int cpu, char *governor);
> >   int cpufreq_set_frequency(unsigned int cpu,
> >   				unsigned long target_frequency);
> >   
> > +/*
> > + * get the sysfs value from specific table
> > + *
> > + * Read the value with the sysfs file name from specific table. Does
> > + * only work if the cpufreq driver has the specific sysfs interfaces.
> > + */
> > +
> > +unsigned long cpufreq_get_sysfs_value_from_table(unsigned int cpu,
> > +						 const char **table,
> > +						 unsigned index,
> 
> unsigned int?
> 
> > +						 unsigned size);
> 
> unsigned int?
> 

OK, the complier prefer 'unsigned int' to bare use of 'unsigned'. Thanks, I
will updated it in V7.

Thanks,
Ray