Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <14d6e454-49c3-0a85-68f1-3f003ad032e6@ugent.be>
Date:   Mon, 21 Feb 2022 01:03:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
To:     Adaptec OEM Raid Solutions <aacraid@microsemi.com>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Niels Dossche <niels.dossche@ugent.be>
Subject: [PATCH] scsi: aacraid: add missing manage_lock on
 management_fib_count
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFM3ZFN2dFdlazJlakpianBzbU92azhBcW5qeDdkZUlPWS90dlFJbmw2cEg0?=
 =?utf-8?B?NUR6YWdSVnV1YlR1dVY4QTlrVnFtL2hjQkFmTmFFb2ZXc3VEQ0p5emorWk1v?=
 =?utf-8?B?cS9NWHd4R0xzNzlVVGxlaXNnbXE5RW41bUU2NlRKa1REd1lSWVA2VkU1S2ti?=
 =?utf-8?B?K0lnaXh1VFkydUVPb0xnYU42ZHhqeUljaEtManpBM0h3Z2ovTFBGQjNYTnV5?=
 =?utf-8?B?WWF5M0x0WW5WVlZFR1JYeFJyT2ZEcDBlVkc0aVFMYnY4RVc5QlQvVzFpZlRN?=
 =?utf-8?B?UE91d01HYjEwMytMSmdaZit0TS9iNEtuNGxwRG5ZckdFVHhacTdXcERhdHpZ?=
 =?utf-8?B?UHdtNkZzNWdJeTZ4dEtXZXVzbncyWkxobGZ4c1FoZEYxYXNrL0RsNlJja2J6?=
 =?utf-8?B?TUJ0VFJ0YURjV2N0ZmZobE9oQmE3eEkzNitZQVExa2JwWm5RWlpLYXJlcG5a?=
 =?utf-8?B?SGEwVVFDSm5lZXI1ZVA0eWh4dmxEZy85UTVBYkQ1eXlzSENRMWxWaWFDaW5F?=
 =?utf-8?B?bUJwK0JvcGdXSVcvT3pTRUNXcWJZSktqOFIyWGNjYkowUG9aQlpqNDJKRVN0?=
 =?utf-8?B?djRGdWk2M1ZqbXk4VERJZ3hWRE5WVElWZk41Syt6bG4vaXBpU0hHTk0zYzNT?=
 =?utf-8?B?Nm1WTE1FYkMvcWRLMmNobXFlejJ1VW81eEVWcHBuNCtlL2daUGJZTFNlTytV?=
 =?utf-8?B?THFyL29yQnZqb2ZLSkhCTnNQeE14b3VlWUZqa1dvd3FDTHY0bDFOamlDS2xT?=
 =?utf-8?B?ai9BUlpRYmVoWnBzcmZ5SVBOeXFuZ3ZUSUxxZXFnVDRzbFhMV1BTeXFDRTA1?=
 =?utf-8?B?Z0s1OEt2WXJLREhtTGxhbk9TRG5wZlpzK1hzTHFFTHFCalBuZUFENlhiR3h2?=
 =?utf-8?B?UWd2Y2dndWU4ZjhxbFVjclkxNE95REZQdjZzNUtqWXdFck1UY243dkRKQkR3?=
 =?utf-8?B?RTJpR2NTMVFkcTdNMDhCVkhBc3lwN1VVUVFsTTJyODZKM0h6Q1I1amRjOXB5?=
 =?utf-8?B?cTRWNU16dE1UM2FveDhKOFN4U2c1dGc4K2FlVzNVQmM0SVJINHU2NVN3WjVE?=
 =?utf-8?B?bm13VERVZktLK2FaUlFkRllOUExPYjRud3JDcnEvN3cwdGlBRDUycUg4bklO?=
 =?utf-8?B?TTRNQUhtUVRJYXdreXdiZHB4OG5zSEJvSUhrVm9PM2YzaHhLS2JxNFIzMjhh?=
 =?utf-8?B?UnBzbysxWG9nWkxIRTVhNThJVW1pR1VZNVNQOURZRCsvL1B2Y2FxZ05vTHFL?=
 =?utf-8?B?YzNyNW9Pb1BBUFFDNFp5YmdIaDhWa2t0QlAyTjdYSkFWai9oMWZ4ZFFSZkVw?=
 =?utf-8?B?amM4NW84TjBxY3RUc0tRdnU5aXRkS3JPSEJtcUowMDRTbHNYaU54TTBCMjVT?=
 =?utf-8?B?cVhxVTRiUU0vUjdSMWhMMDRqSGJtdVRnY3RnTXdHNS9kVFJPZzFmYXFLV0Nu?=
 =?utf-8?B?Q09weTRSd1ZZbEZHVGIwdjhiYTNpNW1UaHczUG13MHJrRExFQXpWSkRFVkVn?=
 =?utf-8?B?L0FwdUVoUGZuQWhnU241U3VkYlNxYjdpYkdmSndNeTBMdmY1OU5DM1VpRnVU?=
 =?utf-8?B?d0FWRlQ0MkR5UTYzS0lhdkRDVCtRN2J6eUNKSkFvZ201anU3d3FmYTg4R3VS?=
 =?utf-8?B?ZitwUXFrN2NsWmJ2MlVrRUNVNExmOTd3U3ZpVEpoWit3ODlJV2ZxT3N0TnhU?=
 =?utf-8?B?bUUrTnloUzQ5NzFjd09icUVHRzN0RktmZlZJMVJ2elFUZkhtTS9UV1NGUVVy?=
 =?utf-8?B?Mko4U2pxMmVXNUNZQW81eUlDL2pNRC9Ya1JCSjdKOG1hdDRvZ1NSdW1rU2hN?=
 =?utf-8?B?dVhFem9ITHBWZ09XYmx2WVk2TlA5UjNZbXFXd3B1YmE2ZStQSE11ZTBXUzNI?=
 =?utf-8?B?dm5VWmFJYXlsQUl2RUNHZFhtSXdadFZNdmMrS1pRRW5mTzlCWlBXWHJzOEtT?=
 =?utf-8?B?OGtYVnpmWitQNXpycDJHTlZQU2lFVVo3SVFzRWlEYWZXYmFMUCtZY3dtSTBM?=
 =?utf-8?B?MnJNYTZJbnZsVnVkVUxVcFVhTm9DM29yejZOWjdZWGpyLy9MZFBmRVdMaTVm?=
 =?utf-8?B?RkxCaXZnMUU3TE4rQ3FncmJ1R2dsSHdCZEhxREdqN1Y1Q0lPOG11aW9VZWZE?=
 =?utf-8?B?WTFwaE13clRVUTNKcUZnQTF6R3RRV2htNUhQNTFkRVZHai8xSWZPWkJNVkJL?=
 =?utf-8?B?S2RlV09xc1hTeFRMUFQzZVpXVXNZbDZHaG5WdWNSakFITWRnZFZuZU5TU0RD?=
 =?utf-8?Q?QeHne9QB8dodRPWlmbv2TaXGVGBmymAk2wBDwXadek=3D?=
X-OriginatorOrg: ugent.be
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c2e2d67-ce6c-4e53-f325-08d9f4cda5d7
X-MS-Exchange-CrossTenant-AuthSource: AM6PR09MB2326.eurprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 00:04:06.9368
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d7811cde-ecef-496c-8f91-a1786241b99c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JykuW15WwK7a10aGjm+otXNIfhIXpp7KDifOnrAGb7Gg6OhBsWH82/t9IDgm7ejFZIa8lL80GnskgmW/UozAkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR09MB4395
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

All other places modify the management_fib_count under the manage_lock.
Avoid a possible race condition by also applying that lock in
aac_src_intr_message.

Signed-off-by: Niels Dossche <niels.dossche@ugent.be>
---
 drivers/scsi/aacraid/src.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 11ef58204e96..ca73439587ed 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -91,7 +91,9 @@ static irqreturn_t aac_src_intr_message(int irq, void *dev_id)
                                        dev->sync_fib);
                        spin_lock_irqsave(&dev->sync_fib->event_lock, sflags);
                        if (dev->sync_fib->flags & FIB_CONTEXT_FLAG_WAIT) {
+                               spin_lock(&dev->manage_lock);
                                dev->management_fib_count--;
+                               spin_unlock(&dev->manage_lock);
                                complete(&dev->sync_fib->event_wait);
                        }
                        spin_unlock_irqrestore(&dev->sync_fib->event_lock,
-- 
2.35.1