Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b674472d8c52a84002908e2248fd81ce11247569.camel@trillion01.com>
Subject: Re: [PATCH v1] io_uring: Add support for napi_busy_poll
From:   Olivier Langlois <olivier@trillion01.com>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     Pavel Begunkov <asml.silence@gmail.com>,
        Hao Xu <haoxu@linux.alibaba.com>,
        io-uring <io-uring@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Date:   Sun, 20 Feb 2022 13:37:26 -0500
In-Reply-To: <f070354c-b65b-f8b3-e597-2e756bcfa705@kernel.dk>
References: <d11e31bd59c75b2cce994dd90a07e769d4e039db.1645257310.git.olivier@trillion01.com>
         <cbf791fb3cd495f156eb4aeb4dd01c42fca22cd4.camel@trillion01.com>
         <f070354c-b65b-f8b3-e597-2e756bcfa705@kernel.dk>
Organization: Trillion01 Inc
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.42.3 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 2022-02-19 at 17:22 -0700, Jens Axboe wrote:
> 
> Outside of this, I was hoping to see some performance numbers in the
> main patch. Sounds like you have them, can you share?
> 
Yes.

It is not much. Only numbers from my application and it is far from
being the best benchmark because the result can be influenced by
multiple external factors.

Beside addressing the race condition remaining inside io_cqring_wait()
around napi_list for v2 patch, creating a benchmark program that
isolate the performance of the new feature is on my todo list.

I would think that creating a simple UDP ping-pong setup and measure
RTT with and without busy_polling should be a good enough test.

In the meantime, here are the results that I have:

Without io_uring busy poll:
reaction time to an update: 17159usec
reaction time to an update: 19068usec
reaction time to an update: 23055usec
reaction time to an update: 16511usec
reaction time to an update: 17604usec

With io_uring busy poll:
reaction time to an update: 15782usec
reaction time to an update: 15337usec
reaction time to an update: 15379usec
reaction time to an update: 15275usec
reaction time to an update: 15107usec

Concerning my latency issue with busy polling, I have found this that
might help me:
https://lwn.net/ml/netdev/20201002222514.1159492-1-weiwan@google.com/