Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Feb 2022 11:20:46 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Hugo Villeneuve <hugo@hugovil.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mp-evk: add support for I2C5
Message-ID: <20220221032046.GG2249@dragon>
References: <20220211153843.3721618-1-hugo@hugovil.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220211153843.3721618-1-hugo@hugovil.com>
Precedence: bulk

On Fri, Feb 11, 2022 at 10:38:43AM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> Add support for i2c5, which is used to access the
> external I2C bus on connector J22 of the imx8mp-evk.
> 
> Limit the speed to 100kHz since this is an external I2C bus.
> 
> Disabled by default, since it is shared with the CAN1 bus.
> 
> To enable i2c5, you need to disable the CAN1 function, enable the i2c5
> function and also configure the CAN1/I2C5_SEL GPIO to HIGH to
> select i2c5 instead of CAN1. This can be done by defining a gpio-hog
> inside the pca6416 node, in your board device tree, like in this example:
> 
> &flexcan1 {
> 	status = "disabled";
> };
> 
> &i2c5 {
> 	status = "okay";
> };
> 
> &pca6416 {
> 	can1-i2c5-sel-hog {
> 		gpio-hog;
> 		gpios = <2 GPIO_ACTIVE_HIGH>;
> 		output-high;
> 		line-name = "can1-i2c5-sel";
> 	};
> };
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Applied, thanks!