Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b009f64a-2516-e899-fb22-9973e78ffcd4@quicinc.com>
Date:   Mon, 21 Feb 2022 11:19:21 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy
 override params bindings
Content-Language: en-US
To:     Pavan Kondeti <quic_pkondeti@quicinc.com>,
        Stephen Boyd <swboyd@chromium.org>
CC:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Doug Anderson <dianders@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        Rob Herring <robh+dt@kernel.org>,
        Vinod Koul <vkoul@kernel.org>,
        Wesley Cheng <wcheng@codeaurora.org>,
        <evicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
        <linux-usb@vger.kernel.org>, <quic_ppratap@quicinc.com>
References: <1644952755-15527-1-git-send-email-quic_c_sanm@quicinc.com>
 <1644952755-15527-2-git-send-email-quic_c_sanm@quicinc.com>
 <f1b4b389-12f9-7c21-b117-f2fe6df58a89@linaro.org>
 <CAE-0n52G6Cu8douv_KuQEeVM-3vnwGT4dhai8kmiLJ4Fd9Qz8A@mail.gmail.com>
 <20220216034702.GA8486@hu-pkondeti-hyd.qualcomm.com>
From:   Sandeep Maheswaram <quic_c_sanm@quicinc.com>
In-Reply-To: <20220216034702.GA8486@hu-pkondeti-hyd.qualcomm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/16/2022 9:17 AM, Pavan Kondeti wrote:
> On Tue, Feb 15, 2022 at 06:10:45PM -0800, Stephen Boyd wrote:
>> Quoting Dmitry Baryshkov (2022-02-15 11:55:18)
>>> On 15/02/2022 22:19, Sandeep Maheswaram wrote:
>>>> Add support for overriding SNPS phy tuning parameters in device tree
>>>> bindings.
>>> This does not really benefit the users and does not help developers.
>>> Could you please change the dt bindings to specify values for
>>> thresholds, durations, impedance, etc. The values should be represented
>>> in the human units (e.g. us, Ohms, mV), not in the internal register
>>> 'bits' representation.
>> +1
> Agreed to this proposal.
>
> Sandeep,
>
> We have a similar implemention in QUSB phy driver. can we have something like
> that for SNPSHS PHY too?
>
> Thanks,
> Pavan
Okay. Will do in the next version.