Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Feb 2022 12:55:15 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Tyrone Ting <warp5tw@gmail.com>
Cc:     avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com,
        venture@google.com, yuenn@google.com, benjaminfair@google.com,
        robh+dt@kernel.org, krzysztof.kozlowski@canonical.com,
        semen.protsenko@linaro.org, yangyicong@hisilicon.com,
        wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev,
        bence98@sch.bme.hu, christophe.leroy@csgroup.eu,
        lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de,
        digetx@gmail.com, andriy.shevchenko@linux.intel.com,
        tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com,
        tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com,
        kfting@nuvoton.com, devicetree@vger.kernel.org,
        openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 08/11] i2c: npcm: Correct register access width
Message-ID: <YhN9o7IKl7M974Db@latitude>
References: <20220220035321.3870-1-warp5tw@gmail.com>
 <20220220035321.3870-9-warp5tw@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="atvLe0wtstfQwleA"
Content-Disposition: inline
In-Reply-To: <20220220035321.3870-9-warp5tw@gmail.com>
Precedence: bulk


--atvLe0wtstfQwleA
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 20, 2022 at 11:53:18AM +0800, Tyrone Ting wrote:
> From: Tyrone Ting <kfting@nuvoton.com>
>=20
> Use ioread8 instead of ioread32 to access the SMBnCTL3 register since
> the register is only 8-bit wide.
>=20
> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller drive=
r")
> Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> Signed-off-by: Tali Perry <tali.perry1@gmail.com>
> ---
>  drivers/i2c/busses/i2c-npcm7xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-np=
cm7xx.c
> index ee4757eff4b3..4715afcf9ac4 100644
> --- a/drivers/i2c/busses/i2c-npcm7xx.c
> +++ b/drivers/i2c/busses/i2c-npcm7xx.c
> @@ -360,14 +360,14 @@ static int npcm_i2c_get_SCL(struct i2c_adapter *_ad=
ap)
>  {
>  	struct npcm_i2c *bus =3D container_of(_adap, struct npcm_i2c, adap);
> =20
> -	return !!(I2CCTL3_SCL_LVL & ioread32(bus->reg + NPCM_I2CCTL3));
> +	return !!(I2CCTL3_SCL_LVL & ioread8(bus->reg + NPCM_I2CCTL3));
>  }
> =20
>  static int npcm_i2c_get_SDA(struct i2c_adapter *_adap)
>  {
>  	struct npcm_i2c *bus =3D container_of(_adap, struct npcm_i2c, adap);
> =20
> -	return !!(I2CCTL3_SDA_LVL & ioread32(bus->reg + NPCM_I2CCTL3));
> +	return !!(I2CCTL3_SDA_LVL & ioread8(bus->reg + NPCM_I2CCTL3));
>  }
> =20
>  static inline u16 npcm_i2c_get_index(struct npcm_i2c *bus)


Reviewed-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>


Thanks,
Jonathan

--atvLe0wtstfQwleA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmITfaMACgkQCDBEmo7z
X9u9dg//QF1S0S3Sayv/Y5POeRg7pV8i8t2OEfH9zCVaR+vr1PoolReqj3k2Ej9d
gYEjSbp+xbmuChkgWTj06BPc0LR319rmq26SUjHUNJJEEKFjFSzzMzPkNNau3+/O
47dyiOmGPMAlGDBM7JQwbk5Iry+rAiSSO+C0B4KDCkLitGsYXWzEIzyKQiAAwnpp
E5VX32do5W2wj0gUGQE2ccvPMf4bxFOmrRDgZ5TaVD9W+FSnZOX2aks9RNCub/FA
mucJMKSuTeC7TWQZplf3OitMVV/mcc14vZEq8gz8V+oR9LC+Z6jqyR7VTnvYao6S
Umc4BO0hNVt4otrcUfMfpveIUn7Hl9rCOzu3TkGH347urAX06UqLvPrGR/OZ+eN9
OLL6/idFdnpjZGeJuZKhF1cpOg3EXBtKLJLVIH0Q2S01Xime8JE/7tsfjDbTgEi0
e9A0lQgsr+gH5Fg1ch0/HSvB9JQkMJLPX9IRZmnzLBDTR/wgpk9wj+xHQ4eu+DaI
i45J9mdU5SpKJUenOxUT6OEqMLo7BZYNC0TiNJAj9Z9o80+0D+grf3PQGAbkRrXd
ANHC36MNKQoaVL9UepM/MApMjCbdGexFolHO+x1OAj+wc5ByBEx02761DbY3tGTy
+uoLcZbn3xZJBgEh9ItMeq6thuErcvsUgTKtiCYMSJcYu+whDLU=
=4Mfv
-----END PGP SIGNATURE-----

--atvLe0wtstfQwleA--