Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220219012433.890941-1-pcc@google.com> <7a6afd53-a5c8-1be3-83cc-832596702401@huawei.com>
In-Reply-To: <7a6afd53-a5c8-1be3-83cc-832596702401@huawei.com>
From:   Marco Elver <elver@google.com>
Date:   Mon, 21 Feb 2022 12:15:12 +0100
Message-ID: <CANpmjNO=1utdh_52sVWb1rNCDme+hbMJzP9GMfF1xWigmy2WsA@mail.gmail.com>
Subject: Re: [PATCH] kasan: update function name in comments
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     Peter Collingbourne <pcc@google.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        Andrey Konovalov <andreyknvl@gmail.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 19 Feb 2022 at 03:00, Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> On 2022/2/19 9:24, Peter Collingbourne wrote:
> > The function kasan_global_oob was renamed to kasan_global_oob_right,
> > but the comments referring to it were not updated. Do so.
> >
> > Link: https://linux-review.googlesource.com/id/I20faa90126937bbee77d9d44709556c3dd4b40be
> > Signed-off-by: Peter Collingbourne <pcc@google.com>
> > Fixes: e5f4728767d2 ("kasan: test: add globals left-out-of-bounds test")
>
> This Fixes tag is unneeded.
>
> Except the above nit, this patch looks good to me. Thanks.
>
> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Marco Elver <elver@google.com>

And yes, the Fixes tag should be removed to not have stable teams do
unnecessary work.

+Cc'ing missing mailing lists (use get_maintainers.pl - in particular,
LKML is missing, which should always be Cc'd for archival purposes so
that things like b4 can work properly).

> > ---
> >  lib/test_kasan.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> > index 26a5c9007653..a8dfda9b9630 100644
> > --- a/lib/test_kasan.c
> > +++ b/lib/test_kasan.c
> > @@ -780,7 +780,7 @@ static void ksize_uaf(struct kunit *test)
> >  static void kasan_stack_oob(struct kunit *test)
> >  {
> >       char stack_array[10];
> > -     /* See comment in kasan_global_oob. */
> > +     /* See comment in kasan_global_oob_right. */
> >       char *volatile array = stack_array;
> >       char *p = &array[ARRAY_SIZE(stack_array) + OOB_TAG_OFF];
> >
> > @@ -793,7 +793,7 @@ static void kasan_alloca_oob_left(struct kunit *test)
> >  {
> >       volatile int i = 10;
> >       char alloca_array[i];
> > -     /* See comment in kasan_global_oob. */
> > +     /* See comment in kasan_global_oob_right. */
> >       char *volatile array = alloca_array;
> >       char *p = array - 1;
> >
> > @@ -808,7 +808,7 @@ static void kasan_alloca_oob_right(struct kunit *test)
> >  {
> >       volatile int i = 10;
> >       char alloca_array[i];
> > -     /* See comment in kasan_global_oob. */
> > +     /* See comment in kasan_global_oob_right. */
> >       char *volatile array = alloca_array;
> >       char *p = array + i;
> >
> >
>