Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp3937468pxb; Mon, 21 Feb 2022 08:40:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzfTW4k8MpLSOAB0nVITK4ZN+iQXvPh5UqtaaeseZj25emUQiZvRSBPIBP4VZxtyFrsnznc X-Received: by 2002:a17:906:d047:b0:6c8:185c:aad with SMTP id bo7-20020a170906d04700b006c8185c0aadmr16660411ejb.341.1645461611462; Mon, 21 Feb 2022 08:40:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645461611; cv=none; d=google.com; s=arc-20160816; b=UuQp0iURR3f014J35woo+zPoBwVy9lGAshB1cumCAq+v3S+P4lzt7QAbfU1Duqh5F0 9elHTYnzQN71oCTvLFNHt4sGlxvS4zs7E8nUeJk7wW7XJ3bB5l6yLdxV+p9WZf00jTef YwkZ5kI21ULQg1CSr6IF/FBO3pxL1M9/nILJ0Yai7sxuFZegCt/lUkI3BwsCWPIJdzrQ J+pK2H7Qyd7wGD5hjk+UVHqDN8DfYmMwAabWlVu51l+BKpS43+/6uJLXVUfIN+bnaKnW C40qML23W1cOPRDpPXw8UbmPUvkozhsrJ15H3Odcu4G7adJ2zdL3lkFA+e4LlKxETY0i rAjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ad6pMafFuKoh5sHuoaKN4WCBkg6hpge8kEYbZzG0l/U=; b=GJJeLTU78VhGwzQsvr5uaSXgoeJlIy0vSzoIDtzotncqh37XFbPryPJANp27m3LIoD z9UtvSp/zp4P5ZF7vmVK1NTQZmAyEaM/QD2KyYavDaEILleue1cSvv7hByElo/cbcv9n Zg8/4/qw8y0ucEefH4qM9y4bFIJcjWNDScPiFohSZmN0QiscM3NGG6qGu6VpeD+CnU5c +1dyoTusKVbhaMFux48ZGHQuPa6a7oWyWx0KorxqG9LBK0ct3ElLSl/fSZx830l541Jr XNh+IukuE4klIq512e3axxjygFiApUReScoO5mrUAT300/GnOGwR4iUN1v/UKC2lOB8m 4mhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="BShNKK4/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q15si3305973ejs.700.2022.02.21.08.39.48; Mon, 21 Feb 2022 08:40:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="BShNKK4/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352354AbiBUJzj (ORCPT + 99 others); Mon, 21 Feb 2022 04:55:39 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353206AbiBUJsQ (ORCPT ); Mon, 21 Feb 2022 04:48:16 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3EE2226ADD for ; Mon, 21 Feb 2022 01:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645435344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ad6pMafFuKoh5sHuoaKN4WCBkg6hpge8kEYbZzG0l/U=; b=BShNKK4/BRPPO07L0KZiROY5AvXts06ccZyVVVCYlDtLuKnZ0uj/j5yXaQ1ZLDzJfhJCJD AP4xFGruoa8Y+E8Pw4Fi8UHj7knkM12CD/560yvT4BqDwwt1CDJSOCmJMgybVCN6J8MPH0 EZEdT8w5snYH6EFlwMaMEguCzZ9Ul3U= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-9pTVpVzEN0yKGiNRA4D5ZA-1; Mon, 21 Feb 2022 04:22:23 -0500 X-MC-Unique: 9pTVpVzEN0yKGiNRA4D5ZA-1 Received: by mail-lj1-f197.google.com with SMTP id v5-20020a2ea605000000b00246322afc8cso1894625ljp.4 for ; Mon, 21 Feb 2022 01:22:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ad6pMafFuKoh5sHuoaKN4WCBkg6hpge8kEYbZzG0l/U=; b=V8IOjExkCQ5JflR82qgsCZA70tEk7/0r8KK6kcAouAbN1cvHJqH2FG+kFSgp0R6JAh /txvLaD7rWIeDavDYzv4w49Na9w+hvCBHPW6fBDWxsl8t2jswruk1y8fP1qxSt57vP6p dyxdUa5i+snvHT/1pHU8N8919iWpcf+FWYpfn3BYOqfFy6VEiL93NGSfW/TIa7DvACqV sfuZ50Kx15IdVY0GLXXrV90ID0H5Qw7yzbgzBM/t8d2PIXGCyLYK2vTC33okqfyIp4hs bb+aCzskSCNQ0rQpnwfWjeiuRs+uUt5KgYLxElkCpW8YYaJo5Ulk35j37ao8VVpEuUK5 I2TA== X-Gm-Message-State: AOAM533Vvjry3ujQwL/NqhHZaoVfDOmnwb60bpRExexbuk8vniN4vJVX kQTnJlHtIYwp/EKE7LdML6yZ3rK6Iks2avrUXSRyDgRhqghaV0TnHTZ4BA/iJ69RFOHgCejMtOm 2pqApmcQQ/upJZ+zvFUZ3TeF1L7YA0WAt3IHR5X0= X-Received: by 2002:a2e:8856:0:b0:246:3bfd:dfc8 with SMTP id z22-20020a2e8856000000b002463bfddfc8mr4005584ljj.405.1645435341124; Mon, 21 Feb 2022 01:22:21 -0800 (PST) X-Received: by 2002:a2e:8856:0:b0:246:3bfd:dfc8 with SMTP id z22-20020a2e8856000000b002463bfddfc8mr4005570ljj.405.1645435340975; Mon, 21 Feb 2022 01:22:20 -0800 (PST) MIME-Version: 1.0 References: <20220218212511.887059-1-atomlin@redhat.com> <20220218212511.887059-10-atomlin@redhat.com> <98cff67e-d2ca-705b-7c83-bd3f41df98d9@csgroup.eu> <0ea89614-9bab-99f5-47a8-2a2996c38966@csgroup.eu> In-Reply-To: <0ea89614-9bab-99f5-47a8-2a2996c38966@csgroup.eu> From: Aaron Tomlin Date: Mon, 21 Feb 2022 09:22:09 +0000 Message-ID: Subject: Re: [PATCH v6 09/13] module: Move kallsyms support into a separate file To: Christophe Leroy Cc: "Luis R. Rodriguez" , "Lameter, Christoph" , Petr Mladek , Miroslav Benes , Andrew Morton , jeyu@kernel.org, linux-kernel , linux-modules@vger.kernel.org, live-patching@vger.kernel.org, Aaron Tomlin , Grzegorz Halat , Allen , Joe Perches , Michal Suchanek , oleksandr@natalenko.name Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2022-02-21 09:35 +0100, Christophe Leroy wrote: > Fixup: > > diff --git a/kernel/module/kallsyms.c b/kernel/module/kallsyms.c > index 6c8f1f390cf5..2ee8d2e67068 100644 > --- a/kernel/module/kallsyms.c > +++ b/kernel/module/kallsyms.c > @@ -171,8 +171,7 @@ void add_kallsyms(struct module *mod, const struct > load_info *info) > Elf_Shdr *symsec = &info->sechdrs[info->index.sym]; > > /* Set up to point into init section. */ > - mod->kallsyms = (struct mod_kallsyms __rcu *)mod->init_layout.base + > - info->mod_kallsyms_init_off; > + mod->kallsyms = (void __rcu *)mod->init_layout.base + > info->mod_kallsyms_init_off; > > /* The following is safe since this pointer cannot change */ > rcu_dereference_sched(mod->kallsyms)->symtab = (void *)symsec->sh_addr; Agreed. -- Aaron Tomlin