Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp3958550pxb; Mon, 21 Feb 2022 09:05:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxAYHd9P2H7Y5759lmrRe8bWGyvAreKQopI/fE5ELRJEdpU1ZncAi1B052U7CO8/bDR3wVR X-Received: by 2002:a17:902:ee45:b0:14f:b66c:dbad with SMTP id 5-20020a170902ee4500b0014fb66cdbadmr6176255plo.73.1645463146958; Mon, 21 Feb 2022 09:05:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645463146; cv=none; d=google.com; s=arc-20160816; b=cvsu+wVQq2X1+86zH3UZ+C9TdqSVm47vH0Y3OtJ0rW60/vYEVeMzTgQSfFbCGfhiMm 0SyvZpkXrim3HZ6joHDgAtn5g3Gabc5dVTcRuHXThElZGqyS5ckhEW3rwovLs1IYolEc mxdwIXCEfKUXMHKLqFg1nb1Fx3kGeoDgjy/6B7fUwACj06dd91ELSe+GTNl0Hm33j1eh L6P8Gacf/638IYd0LR7J+fq7W0eA5yrT4tRYezxLO58oTSiNxci0yqabSxBQRe1hIT6d Dn/y7k74NDRE0Ki9V4ag/DXMCoHwi0+xf/zr5pcId0Erz66o3GWJGQMO9Sy/f+jtpREJ cQ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=3XjT+yfOH0QV2J9nIhHSeLvHRCR6LYKtnCGPGJmYylI=; b=mVERCUH+olW11FnhU66d4Yh4ks7oFPcgxw1bL1zREccP1fSjLqMN36U8EorQR5soZC holt/hucXhBd9slCIuTz+oUkuIabIa1f1KD3Z3liJqD3F83YMjTcxuknRXCij0HGwpUC bUsM9GUsFTftm1l5qSqUs9ShpPs0vzoGYn2OFw/WFfkkMpvdJ8rhC5/y/AdQs10pfT1O QgS0KQtuOo/nQ6kAEN5xjA9QyXxPpCTvEZhy4w8PCGN7GoWoitK8XAU+tT4sUr0vyiBI SmnpWNhiYfinV3eyy5FX7kPnDsGnTOXfJLA6HiiY3fgnOMvFqsX5xIS1E/Q5ETWFDFNT c6fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=SdlvgkcZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u18si21473267pgm.512.2022.02.21.09.05.30; Mon, 21 Feb 2022 09:05:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=SdlvgkcZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359289AbiBUOu3 (ORCPT + 99 others); Mon, 21 Feb 2022 09:50:29 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378385AbiBUOuK (ORCPT ); Mon, 21 Feb 2022 09:50:10 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC93D616A for ; Mon, 21 Feb 2022 06:49:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 58AC56111C for ; Mon, 21 Feb 2022 14:49:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82760C340E9 for ; Mon, 21 Feb 2022 14:49:38 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="SdlvgkcZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1645454975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3XjT+yfOH0QV2J9nIhHSeLvHRCR6LYKtnCGPGJmYylI=; b=SdlvgkcZml4i6C0vb6+1mOPAQFSQ7hviER5DKCgScfz7AyQ+O2h8Fqg+GwuE36h9CfmLHk nP2rf3EWcFCFlxUl5x8X7koz7DWMBkiNNamPK7zpsxy/RaKHQD7lLAOoByoTvT8p7KUlpN +z3uoknzXI65Cbc3Cy92z5QFb9mzNUs= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 27168c16 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Mon, 21 Feb 2022 14:49:35 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-2d66f95f1d1so140487807b3.0 for ; Mon, 21 Feb 2022 06:49:34 -0800 (PST) X-Gm-Message-State: AOAM533Ni0bQ83R5LEx87CyqXk5k6QvvCOEaBZMD4lB+QsSkURjPRTdy qIpcP3jx1jI3X9Fmqnz7KYzT4Ed2dISQz2aGw5Q= X-Received: by 2002:a81:7d04:0:b0:2d0:d0e2:126f with SMTP id y4-20020a817d04000000b002d0d0e2126fmr19448715ywc.485.1645454974340; Mon, 21 Feb 2022 06:49:34 -0800 (PST) MIME-Version: 1.0 References: <20220212122318.623435-1-Jason@zx2c4.com> <20220212122318.623435-2-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Mon, 21 Feb 2022 15:49:22 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/10] random: introduce drain_entropy() helper to declutter crng_reseed() To: Eric Biggers Cc: LKML , Dominik Brodowski , "Theodore Ts'o" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 21, 2022 at 5:34 AM Eric Biggers wrote: > Looks good, but perhaps the comment should clarify that drain_entropy() doesn't > destroy the entropy in the pool, but rather just extracts it and zeroes out the > entropy counter? Will do.