Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20da6f55-682f-4b30-7be7-f425f8efa995@nvidia.com>
Date:   Mon, 21 Feb 2022 16:16:28 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 2/4] hwmon: (lm90) Use hwmon_notify_event()
Content-Language: en-US
To:     Guenter Roeck <linux@roeck-us.net>,
        Dmitry Osipenko <digetx@gmail.com>,
        Jean Delvare <jdelvare@suse.com>
Cc:     linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
        linux-tegra@vger.kernel.org
References: <20210618215455.19986-1-digetx@gmail.com>
 <20210618215455.19986-3-digetx@gmail.com>
 <9580f660-2a11-40e4-2986-f05703822d72@nvidia.com>
 <2aae3bac-c9b3-ab47-aae4-a3c7b6fb4bb5@roeck-us.net>
 <84ddad27-eb22-0ba6-594f-2fc6d098dc2a@nvidia.com>
 <bdb8b51f-93ac-9f99-914e-e1ce16c0076d@roeck-us.net>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <bdb8b51f-93ac-9f99-914e-e1ce16c0076d@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWxpODRZMkNhRWQ1alYyVENJN01oTGVwRmtHM3c3ZDVXUUpwZ0swcGhLamFZ?=
 =?utf-8?B?ZlZVVEZBRmRwREtUMTZWSERFUXJpN1MwUXRsYmp3UHhsNnBRNThjdWlOZ3lh?=
 =?utf-8?B?WGMzekFFazZ6bXBOQmRKQmFqeVdmVStOU3RXbm0zYWZIZTZ0MmVjM0FvRXhR?=
 =?utf-8?B?SXBON29jN04vbnl4VlZYQ1pPSDdKV3FyZVBpUWV5L2xlbjlxYkVjcysxaENG?=
 =?utf-8?B?UFJMUHdmYk5kbGhzbFZQQVgremtIZmh5WWVZeEJtcG41TUFPeXE5Q3JnZmxG?=
 =?utf-8?B?dFpiRW0yMkpLRm1hRnRJU01ZOXF1aUtLQ2R5TjlieUdTMEQwTk93UFVSTjVU?=
 =?utf-8?B?WWp5MnUyNzJDUmgzc2RUOFk0QzEwQnViNm1KWStBVWwxeVZFMWZJREVZcEtC?=
 =?utf-8?B?aHFuTnRPYjlyZHNuR2xFMzdqUDRLUHNPb2pTSnprK0xYVTlOTVlMYWpMaUF3?=
 =?utf-8?B?UWZ5Q0FBZU1vTWZTNmhwODBUWk12eUY4K3RjaWo2VktnYm42bFp0aWo3d2lP?=
 =?utf-8?B?NXd0ZU1ORS8rdER5UzJJa0FvVSswZE11VnZJMWI1L3VQcXBCYnFoSkt6NmxW?=
 =?utf-8?B?cWpLdkVlZ3NGdnY1T1NMUk92NGd1cU5kemwyNVI1NGZSRjVJZmZxTkcrdVVD?=
 =?utf-8?B?ZXdQSWVuS0g2ZGxZUTU0WDZQMS9nMG9ucGhScHhkb1pERXIvWm9BS1JZa2F0?=
 =?utf-8?B?WlNWSG5McVUwZmt0RE9ORGk3Zmw4UEM0RmJxZm04Z3Z2Nmo1NkoxVmtxSndk?=
 =?utf-8?B?cEp1RmQzVTFzSFZ5b3FlaHo3ZVhkd3lnWDJSSEljMkgyUnM5Qk5GQVFrbEpE?=
 =?utf-8?B?NXYwRE1yVmNMODRQWEZpSkVFMEJITnFPRTlVYU9BQmpTVGVmNUk5VnNVWXZM?=
 =?utf-8?B?dE5RQTZjeGFTQkk4Y2huUzFheVRxY3VkV2VJcGFDaGlPcXBZNDZ5dzhIYmNS?=
 =?utf-8?B?QjhIVUQwSWRSaWJRTVFuemZXQkpacmN0KzNkbnJXaXYwVjlWdENyVGE5eU9H?=
 =?utf-8?B?MnppOS8xUmxyelZndXNzNmNPYVZTSEZ3UVJGaWlRL2l4OWU4K0IzOWY0UHEw?=
 =?utf-8?B?cVhqL2VMeU5hNlpzNTliOVJMdUdtUUg2QnVKRUFYZlVFZ1cxUlE3d0g5Y3lS?=
 =?utf-8?B?TTJUdENHakxIcG96VjQyQlNub2NPaFRJdUhMTnA2UUt2Rk40Y0REWEtZNlZv?=
 =?utf-8?B?UmFpMnc1OXVDYTdNR3VNTmJhTjdZVUdsRDFxZ2M0SkEyaDhNdkhHbEFxbjJT?=
 =?utf-8?B?UFFudzhBZUVEbmZobTh2TWNHTEdOL20wTjRjcG9UbUNMNTlyMG5YUXlNZkk4?=
 =?utf-8?B?RC9BRDdaM2VxQmc4Tk1HZHpzN3ZqM0JzOUxvVWNBZ2twQ2wrRm53cXJ1V2Ry?=
 =?utf-8?B?QW9ackM3WjNuNkxHaDdmZVowUGdTOWtMblBLM2NhR005bXhHeGNTM1hIZlpV?=
 =?utf-8?B?K3V0UkNkc2U2OG0rTFVRSUdNNEJiVDFLZFBxQlRBeFJSclpsVzRQKytiQ0RB?=
 =?utf-8?B?Ym5IMlcvS3N5eWwxb1VvREZmRlUyMVl2VDlmREJma2hUSlBhOURPUkg3TWFu?=
 =?utf-8?B?NXNsY0ttWWdYbkpvWmhzaTZKRmlYeXg4a21MZ29HSU9FOVZBUnM2REZOTFRP?=
 =?utf-8?B?SGNkb2Z5VnpwdW1iRTFYbGpYYzZURDFkcm40OFdzVHJjQitIU3pyZE1Sbjcr?=
 =?utf-8?B?Y1NMV1Y5SDdLQytSZ2poWWphTXpKZWlLdC9GYmljS1RiN3hnUW5hbmwyemhG?=
 =?utf-8?B?S1poVzNPUjdBa2JqSG8xYzZTL1N5Ny8vcVJhS0FTZmJPT0pOZUZ2YnhoNkpx?=
 =?utf-8?B?cjRBelJwTjljc2VNZ0cwNWx1MEwvVGVhYkdkdkk0NUdvek95bit2SXhrMXRo?=
 =?utf-8?B?QVpyd2Y5UVJZRUdDZGtqd21tdHBrMGEvMHVxRmFVYjJ1bWNsaVArYzhaSmR2?=
 =?utf-8?B?VUdNZndOR2ZmV1NaVWJlUzdDU0VzQkNvTHNyaEw3MktxWGFsQTd5cDJoWm8w?=
 =?utf-8?B?QnM3cEZwWW00T3lhWXdYU1F6cE12N1pVemoySmVqdy83WmhURWJqaG1KZVNh?=
 =?utf-8?B?ZC9nTmU5RElOTFpSVDRURGVtQUZaa1hNVWhhVHdCS1RYTnJmK01XY2dybmVI?=
 =?utf-8?B?SU5zVXAxMmZkOE0vSmkwTHZkUnZwTk5aRFZUQnBMcGFsNkFGMU1mOW9waUdh?=
 =?utf-8?Q?HBVKrQLG0rXrXZLAC08uiIk=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b7a5368-68c3-4100-dda1-08d9f55588af
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 16:16:36.6543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VY0r9TEoqQUXX/2zau4Rd3qre3/wdHrR/gSbIurexVGq5o/pKxzIGVHJjEPwUlEeOAd5La8TLLAlk3l8iUh/lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4045
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21/02/2022 16:02, Guenter Roeck wrote:

...

>> The platform I see this on does use device-tree and it does have a 
>> node for the ti,tmp451 device which uses the lm90 device. This 
>> platform uses the device-tree source 
>> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts and the tmp451 node 
>> is in arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi.
>>
> 
> Interesting. It appears that the call to 
> devm_thermal_zone_of_sensor_register()
> in the hwmon core nevertheless returns -ENODEV which is not handled 
> properly
> in the hwmon core. I can see a number of reasons for this to happen:
> - there is no devicetree node for the lm90 device
> - there is no thermal-zones devicetree node
> - there is no thermal zone entry in the thermal-zones node which matches
>    the sensor


So we definitely have the node for the lm90 device and a thermal-zones 
node, but I do not see a thermal-sensor node. Maybe this is what we are 
missing?

Jon

-- 
nvpublic