Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8f1db40-33ce-671c-2041-5f12608afee5@linaro.org>
Date:   Mon, 21 Feb 2022 16:11:56 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 09/10] ASoC: codecs: tx-macro: setup soundwire clks
 correctly
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, quic_srivasam@quicinc.com
References: <20220221131037.8809-1-srinivas.kandagatla@linaro.org>
 <20220221131037.8809-10-srinivas.kandagatla@linaro.org>
 <YhOx+nQ/G+HNRXbq@sirena.org.uk>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <YhOx+nQ/G+HNRXbq@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 21/02/2022 15:38, Mark Brown wrote:
> On Mon, Feb 21, 2022 at 01:10:36PM +0000, Srinivas Kandagatla wrote:
>> For SoundWire Frame sync to be generated correctly we need both MCLK
>> and MCLKx2 (npl). Without pm runtime enabled these two clocks will remain on,
>> however after adding pm runtime support its possible that NPl clock could be
>> turned off even when SoundWire controller is active.
>>
>> Fix this by enabling mclk and npl clk when SoundWire clks are enabled.
> 
> A lot of these commit messages sound like earlier patches in the series
> introduced bugs which isn't going to be ideal for bisection.
Yes that is true, I did think about sending this as a fix.

Adding a fix tag would not really make any functional difference as we 
will be hitting the issue only when we enable pm runtime in codec and
SoundWire controller, so I did add this as part of pm runtime patches.

Without runtime pm the clocks are left always on, so it worked so far.


--srini