Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp4008457pxb; Mon, 21 Feb 2022 10:02:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwWTDlyJoqg5yM+bZxGSnO5mQxTu1C16F/8jqLPaf3xFpe6wU463FfMNHf0ATXOrVx2VrUE X-Received: by 2002:a17:903:24a:b0:14f:9dcf:e4b4 with SMTP id j10-20020a170903024a00b0014f9dcfe4b4mr9502463plh.27.1645466533512; Mon, 21 Feb 2022 10:02:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645466533; cv=none; d=google.com; s=arc-20160816; b=sVDjqGfgC1U+8xaXsdZmWPMC5MiJGP6Bmxl8etk/hVKngLi+lY11nTLw4NurO75J1P nSsS79EoGDzMqFdgtQO/35EqQPLmQGq5EKJee8j1mers3H4NLckJZz6/F6xCGt2yG8Dk 1lV8pAS01V8LARF9qExwHu71+ZXGvlpPGio5G39dLFPF888vVpCm2My35uQ8rqIVgIQ3 9z+YhG+wGrc3DWuR6kc8sPNdzfIU76+ASuKDKeq79WMVZ4oDPkLxvZdw6xdb2HWAcgaC MAYV4R/AXvgZNmjweK1vOQWPHBuDFLrcB3vsHo5vGvnZ1osRqavAIkIIgBstwOhRjRS9 rkqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ROTt5d+Z5m6ABOQRJMrXQHtW5xJGKSXW4X/W1Cjeq3Q=; b=PU18V70SCpiQOwk0bYXMlnZngGQx2BTzpE1r6g+rGT81cfQdEhAQNpxvefgFUn2Tud ql9QPY5oeOox0hJDnuRuj6XT+lO5kZeh6ypemzMdjErMOfhdrRfTJJlXsfZ+l2FLJ47K xTTjqlUMwP5taP6y21dFFJdcD3+4+wNdFenyad1zyfFX4+2MSN3Zf3Kzw14WiLDsUEkt e1QKmeahBonjzi5AiIGBPEwXATM03u5Hzbx7JMrxQfLfjf9S9A/YyCfdVU/bXHXuyInH VnDDVQVjA1zLtzmXHTzP1qX5QsOoWa2+k0AItaVpgCdmt9kCExaQuvmRusBJeR9sNv71 B0FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Qd0pUMEN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u69si13893213pgd.449.2022.02.21.10.01.58; Mon, 21 Feb 2022 10:02:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Qd0pUMEN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353334AbiBUKBd (ORCPT + 99 others); Mon, 21 Feb 2022 05:01:33 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352224AbiBUJxr (ORCPT ); Mon, 21 Feb 2022 04:53:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42FE936B66; Mon, 21 Feb 2022 01:23:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EB257B80EB9; Mon, 21 Feb 2022 09:23:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02CAFC340E9; Mon, 21 Feb 2022 09:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645435403; bh=nkcQxGdJDoVl8oaSFTYORMJhIKjObWqU0wdGclgp29w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qd0pUMEN1CsKnN5Bs/2JqM1MZZ6q9t8K8g1C/0zGpTlpc+nejwTkpvUvQ3eH+6wPr kVLEi6OQTazEToATz2dqnyajz5CHbSlFKrgHG0wXtJsRwJFL3gn1E3WVFegY7sfXb5 zUFikcRsuyNWgP7+7nS7mO92ONZhJZDMYYzLjUJw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mans Rullgard , Andrew Lunn , Florian Fianelil , Jakub Kicinski Subject: [PATCH 5.16 109/227] net: dsa: lan9303: fix reset on probe Date: Mon, 21 Feb 2022 09:48:48 +0100 Message-Id: <20220221084938.489786570@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221084934.836145070@linuxfoundation.org> References: <20220221084934.836145070@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mans Rullgard commit 6bb9681a43f34f2cab4aad6e2a02da4ce54d13c5 upstream. The reset input to the LAN9303 chip is active low, and devicetree gpio handles reflect this. Therefore, the gpio should be requested with an initial state of high in order for the reset signal to be asserted. Other uses of the gpio already use the correct polarity. Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303") Signed-off-by: Mans Rullgard Reviewed-by: Andrew Lunn Reviewed-by: Florian Fianelil Link: https://lore.kernel.org/r/20220209145454.19749-1-mans@mansr.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/dsa/lan9303-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/dsa/lan9303-core.c +++ b/drivers/net/dsa/lan9303-core.c @@ -1309,7 +1309,7 @@ static int lan9303_probe_reset_gpio(stru struct device_node *np) { chip->reset_gpio = devm_gpiod_get_optional(chip->dev, "reset", - GPIOD_OUT_LOW); + GPIOD_OUT_HIGH); if (IS_ERR(chip->reset_gpio)) return PTR_ERR(chip->reset_gpio);