X-Received: by 2002:a17:90b:3806:b0:1b8:e628:d88 with SMTP id mq6-20020a17090b380600b001b8e6280d88mr490755pjb.32.1645471895345; Mon, 21 Feb 2022 11:31:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645471895; cv=none; d=google.com; s=arc-20160816; b=thR4sxhjJcuibhlg089nQSL/nIwCk2FbzuTKunBjbz3lkJo++Ja/voG96QWaYFTBBZ CV1Rdy2uZj6uN8zbdZQcHgzKi79OM/Hztl8AhxkIbAr+idrfq5CZaGOty5iQ44xhrCrF gnMRHdMClxPKwOSDgPjI1ZuQsK2HS+CbgitL3B4fYsoaqKVn98K8O0MX7dRtfay/Ub/r hWNmtoNC7dZVO+e7cZOysIgZwxKKLl4CGVcaEF+whLIUkSw1GeiFf1OfqlSu3DP+PKkl vcokExZ+e6zwMCJEw3LcEj0F4tMu0ePWAodq54HQSh6ETKsT0Q1q7rzkNc8leDxJ+7IA n7Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=mdrfrzPkVa4D08eX0ciYi3sEcGcP73lRVTU26qVcqk0=; b=zr1oX+gBNk+dm3b/WGTRJbcXLpYrgAmbJaQvfVVEvCSXYHtEkffRvabpafVO+eCqpY MpEv/11k8sSQJHMbsi86+2wmVKInKx73kUd+EAjDsN7PBm4b/7V7KOEUy26xYRzfd4Ly 4GJXGyduATkl4KFc4BOWKgaqCx5/x0ArsuCucYDruoMhssPeogCz2rMAeOYTs3tLd4vI 4caV8d0rf44/pfvVI+n/BWx1h/cYi/ujnYW/qPkoByUiWC9JcMT+x7/E1FnWpw9LGvc5 XhvabeiHZqmMzvwYhNIqro/GjvCtQmFuVbP60fS/PeskScHDwC+CwGNGrZqtuuTnOVDS Iy8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JBZhs2eR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h12si8776607pgp.478.2022.02.21.11.31.19; Mon, 21 Feb 2022 11:31:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JBZhs2eR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356785AbiBULv2 (ORCPT + 99 others); Mon, 21 Feb 2022 06:51:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356768AbiBULuf (ORCPT ); Mon, 21 Feb 2022 06:50:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBEDD1EEED; Mon, 21 Feb 2022 03:50:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51620611DD; Mon, 21 Feb 2022 11:50:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id AECAEC340EC; Mon, 21 Feb 2022 11:50:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645444210; bh=2xK2DD6+961JwYR2MY2k3NcaI9MsfIk+TlPg/j9dtTI=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=JBZhs2eRz1VLTooCDRM+67eJkuBopTiSQ2xYl2Rc/dea51TN4Rq5W8Jb4fgbARoK8 8PgE7wVH9j+MLGov4JJeAm7Q8J0iXx/lkxkOE24hxdnXnmNvzNYMJilyxkQxavXqSu VuT2nKx6YJM/szQv265BPS7yh7ljDQ52+3VFe/CDXhNh2w+caQ0eF6pqQQ/RbpAtAU ldJ7UdV4UvImHhWIBMFS2cS3orAbt4x2YQPrTj5X0UuIQCi0Q/xk9guPvTzwSjBGUJ kIfPbetx70koi7rhl6yO5Cg6tTMANv1dqrlng4C6T9FGzSvHqQS/kRKX9tyyeNDwuJ /osJQ408O1wXg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 940C3E5CF96; Mon, 21 Feb 2022 11:50:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v3] gso: do not skip outer ip header in case of ipip and net_failover From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164544421060.17998.17041019336851197628.git-patchwork-notify@kernel.org> Date: Mon, 21 Feb 2022 11:50:10 +0000 References: <20220218143524.61642-1-thomas.liu@ucloud.cn> In-Reply-To: <20220218143524.61642-1-thomas.liu@ucloud.cn> To: Tao Liu Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 18 Feb 2022 22:35:24 +0800 you wrote: > We encounter a tcp drop issue in our cloud environment. Packet GROed in > host forwards to a VM virtio_net nic with net_failover enabled. VM acts > as a IPVS LB with ipip encapsulation. The full path like: > host gro -> vm virtio_net rx -> net_failover rx -> ipvs fullnat > -> ipip encap -> net_failover tx -> virtio_net tx > > When net_failover transmits a ipip pkt (gso_type = 0x0103, which means > SKB_GSO_TCPV4, SKB_GSO_DODGY and SKB_GSO_IPXIP4), there is no gso > did because it supports TSO and GSO_IPXIP4. But network_header points to > inner ip header. > > [...] Here is the summary with links: - [net,v3] gso: do not skip outer ip header in case of ipip and net_failover https://git.kernel.org/netdev/net/c/cc20cced0598 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html