Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Feb 2022 16:48:24 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, quic_srivasam@quicinc.com
Subject: Re: [PATCH 09/10] ASoC: codecs: tx-macro: setup soundwire clks
 correctly
Message-ID: <YhPCWDmS2PV/AD1E@sirena.org.uk>
References: <20220221131037.8809-1-srinivas.kandagatla@linaro.org>
 <20220221131037.8809-10-srinivas.kandagatla@linaro.org>
 <YhOx+nQ/G+HNRXbq@sirena.org.uk>
 <d8f1db40-33ce-671c-2041-5f12608afee5@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="N8HrxkquhfNLRnQ5"
Content-Disposition: inline
In-Reply-To: <d8f1db40-33ce-671c-2041-5f12608afee5@linaro.org>
Precedence: bulk


--N8HrxkquhfNLRnQ5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 21, 2022 at 04:11:56PM +0000, Srinivas Kandagatla wrote:
> On 21/02/2022 15:38, Mark Brown wrote:

> > A lot of these commit messages sound like earlier patches in the series
> > introduced bugs which isn't going to be ideal for bisection.

> Yes that is true, I did think about sending this as a fix.

> Adding a fix tag would not really make any functional difference as we will
> be hitting the issue only when we enable pm runtime in codec and
> SoundWire controller, so I did add this as part of pm runtime patches.

> Without runtime pm the clocks are left always on, so it worked so far.

You still need to pull this before you introduce changes that cause
trouble, not after - it needs to be preparation for those other changes.

--N8HrxkquhfNLRnQ5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmITwlcACgkQJNaLcl1U
h9BBWAf+LiLVaYi+pxISHIxMrZP/doKcCZFWS0PzcOWi4Nb1xxw5zfEHUYdnuscg
iPY6VOk8AVaU84YBgus5cN2YAZNT6lbbZwMCRNyGMps7vJJNLQuCQjPeekPzqGCM
VZfsV1bTMk3tkfQlSw+sixOxX8AVtEcOFyttH+yCt6s2PB2r4MZZrGiHi7kpGJil
Yq1NMNBdlsiFPdiWFmtlndqBEJlavMB17QG9lZjxC7mpUxT0zUPVRlevMp+0Q0/8
9gguv76axuD1+1N029zWYYjpTJYHXPSSqC1Zg1Yu9+V31w9lGpLcnMJAcmcEtYjq
Bbi9CcIy8mUff3ccxwI8lShQftioOw==
=5fQu
-----END PGP SIGNATURE-----

--N8HrxkquhfNLRnQ5--