Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422863AbXBPA26 (ORCPT ); Thu, 15 Feb 2007 19:28:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422865AbXBPA26 (ORCPT ); Thu, 15 Feb 2007 19:28:58 -0500 Received: from tomts40.bellnexxia.net ([209.226.175.97]:61853 "EHLO tomts40-srv.bellnexxia.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1422863AbXBPA25 (ORCPT ); Thu, 15 Feb 2007 19:28:57 -0500 Date: Thu, 15 Feb 2007 19:23:47 -0500 From: Mathieu Desnoyers To: Andrew Morton Cc: Tilman Schmidt , linux-kernel@vger.kernel.org Subject: [PATCH] sparse chokes on arch/i386/kernel/i8253.c Message-ID: <20070216002347.GB9851@Krystal> References: <20070215051408.a7fb7d81.akpm@linux-foundation.org> <45D483D7.2040609@imap.cc> <20070215144142.0c13580a.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20070215144142.0c13580a.akpm@linux-foundation.org> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.4.34-grsec (i686) X-Uptime: 19:12:44 up 13 days, 14:20, 2 users, load average: 1.08, 1.09, 1.21 User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 31 sparse chokes on arch/i386/kernel/i8253.c Here is a marker fix that puts the correct -i include/linux/marker.h in the top level Makefile so sparse works correctly. The tricky part is to keep the kernel compiling correctly with a kernel build directory different from the kernel source tree too. The fix applies on top the the Linux Kernel Markers for 2.6.20. Signed-off-by: Mathieu Desnoyers --- a/Makefile +++ b/Makefile @@ -309,7 +309,8 @@ AFLAGS_KERNEL = LINUXINCLUDE := -Iinclude \ $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \ -include include/linux/autoconf.h \ - -include linux/marker.h + -include \ + $(if $(KBUILD_SRC),$(srctree)/)include/linux/marker.h CPPFLAGS := -D__KERNEL__ $(LINUXINCLUDE) -- Mathieu Desnoyers Computer Engineering Ph.D. Candidate, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/