Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Feb 2022 21:19:12 +0100
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Mimi Zohar <zohar@linux.ibm.com>
Cc:     Yael Tzur <yaelt@google.com>, linux-integrity@vger.kernel.org,
        jejb@linux.ibm.com, corbet@lwn.net, dhowells@redhat.com,
        jmorris@namei.org, serge@hallyn.com, keyrings@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org
Subject: Re: [PATCH v5] KEYS: encrypted: Instantiate key with user-provided
 decrypted data
Message-ID: <YhPzwOREseaU3RA5@iki.fi>
References: <20220215141953.1557009-1-yaelt@google.com>
 <0aa47dfaada88f1cbd2162784f8b77f43566f626.camel@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0aa47dfaada88f1cbd2162784f8b77f43566f626.camel@linux.ibm.com>
Precedence: bulk

On Mon, Feb 21, 2022 at 12:11:22AM -0500, Mimi Zohar wrote:
> On Tue, 2022-02-15 at 09:19 -0500, Yael Tzur wrote:
> > For availability and performance reasons master keys often need to be
> > released outside of a Key Management Service (KMS) to clients. It
> > would be beneficial to provide a mechanism where the
> > wrapping/unwrapping of data encryption keys (DEKs) is not dependent
> > on a remote call at runtime yet security is not (or only minimally)
> > compromised. Master keys could be securely stored in the Kernel and
> > be used to wrap/unwrap keys from Userspace.
> > 
> > The encrypted.c class supports instantiation of encrypted keys with
> > either an already-encrypted key material, or by generating new key
> > material based on random numbers. This patch defines a new datablob
> > format: [<format>] <master-key name> <decrypted data length>
> > <decrypted data> that allows to inject and encrypt user-provided
> > decrypted data. The decrypted data must be hex-ascii encoded.
> > 
> > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> > Signed-off-by: Yael Tzur <yaelt@google.com>
> 
> Thanks,  Yael.
> 
> This patch is now queued in the #next-integrity-testing branch.
> 
> -- 
> thanks,
> 
> Mimi
> 

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko