Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp4386064pxb; Mon, 21 Feb 2022 19:53:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzfEYq98Y1kz9GSHrDPrsz+iKknNdkqboL3eR5I2ncSiUeZVU5bxS5XfH/L42E7W8W456LH X-Received: by 2002:a17:902:e88a:b0:14f:b488:a402 with SMTP id w10-20020a170902e88a00b0014fb488a402mr8184578plg.161.1645501994665; Mon, 21 Feb 2022 19:53:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645501994; cv=none; d=google.com; s=arc-20160816; b=UigtdH3SG/SgSjG4scj5i52iOGlzQSpib6ugZgSoaRcA7oRsDvrUzoptHQGv/QJtAk Rq0388+XNWZDAzOR1KvnsK4lT4FgQsjYc7ampfs72c7Ogg4bJvV/03y6e/apa6Te7F6k BTPOSWYuqj9JzOET6V5rIaqn+mjXVZ88NhX/XhhaBozXLm6rMFRq+o0oV8ycsJXDFz34 bUbUaP8pYGE0gPZ1iu1OZTIX49Y/P/e+C4lfWH6OwcpTM/ANv5y5+lY6DuLqi5GcvyDX HbAowEwQxWc/jy+LDoZ+vjOqzLQUVjDoWcCZjhkDIgrIXwAQZ3UYbHvtKb78P3PwgHkh xRZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iAqz2GmqnpNP4dAnFjtbOp+KfoSTEli02wVy6WIU/sY=; b=S0Odvz253mnFFQDjpKQjK3+PbZ6Gp6REf1DNWJoXWbuUzhicr/UpaejTtNS/fFNMBN oL3DZ7yIXwObAbCYfoehk7UHUQR9DrT1cD1y34xxgplxPvJQc5cOapvse+TQ0xMyKFTF qyJ40xl50Pkz+JujIvk7GCHc9/U+UNok6/+N/QhaLsv6IBh60mZyP00KnkeWdfxc1LVr +/lfl2Q9UndH2H8ie829O30TkdaGg/j+vMJ5HRZuHOGS8lRkGFhLSqt73Ip9o2XUR2cI Hhh5uHBlpqr6DlT0ZRkK4u7qbSy0RDGNfVv57tVq9aFQzRAeySv1WiBkcHdqkY6UzpwL jHYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=bGHFABVN; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id s23si5998457pfw.57.2022.02.21.19.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 19:53:14 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=bGHFABVN; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8B8B22AE05; Mon, 21 Feb 2022 19:53:10 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379536AbiBUPtp (ORCPT + 99 others); Mon, 21 Feb 2022 10:49:45 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379526AbiBUPtm (ORCPT ); Mon, 21 Feb 2022 10:49:42 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08B7F2458C for ; Mon, 21 Feb 2022 07:49:17 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A1B9D21129; Mon, 21 Feb 2022 15:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1645458556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iAqz2GmqnpNP4dAnFjtbOp+KfoSTEli02wVy6WIU/sY=; b=bGHFABVNObcxZuIpeS/MkEkEKjLs4+FDmQEX/eZIGet7JNcND34wTM20p8UXfCSEMgbqaK 3UDaIdtTsAjvkHeCxZkMrCuNEfZJT5p7icOEoT9zh+2+gu5iEm5paHphUiVxITqB6Zu5GX /3w5i5TXlqdJE2m6LjSZ4DtmSiDalAY= Received: from suse.cz (unknown [10.100.224.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 4943EA3B84; Mon, 21 Feb 2022 15:49:16 +0000 (UTC) Date: Mon, 21 Feb 2022 16:49:16 +0100 From: Petr Mladek To: Andre Kalb Cc: senozhatsky@chromium.org, john.ogness@linutronix.de, linux-kernel@vger.kernel.org, rostedt@goodmis.org Subject: Re: [PATCH v3] printk: Set console_set_on_cmdline=1 when __add_preferred_console() is called with user_specified == true Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2022-02-16 11:41:38, Andre Kalb wrote: > From: Andre Kalb > > In case of using console="" or console=null > set console_set_on_cmdline=1 to disable "stdout-path" node from DT. > > We basically need to set it every time when __add_preferred_console() > is called with parameter 'user_specified' set. > Therefore we can move setting it into a helper function that is > called from __add_preferred_console(). > > Suggested-by: Petr Mladek > Signed-off-by: Andre Kalb > Reviewed-by: Petr Mladek > Reviewed-by: Sergey Senozhatsky The patch is comitted in printk/linux.git, branch for-5.18. Best Regards, Petr