Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <8cb2722299ecf8b4c6d24ff28a0a19024dcb41f0.camel@linux.intel.com>
Subject: Re: [PATCH 1/3] platform/x86/intel: pmt: Remove bin_attribute mmap
 support to runtime pm
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Hans de Goede <hdegoede@redhat.com>, mgross@linux.intel.com,
        rjw@rjwysocki.net, srinivas.pandruvada@intel.com
Cc:     linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Date:   Mon, 21 Feb 2022 09:06:57 -0800
In-Reply-To: <5ba6e52c-d7e9-39fc-cb84-963a403385ca@redhat.com>
References: <20220214213258.1929462-1-david.e.box@linux.intel.com>
         <20220214213258.1929462-2-david.e.box@linux.intel.com>
         <5ba6e52c-d7e9-39fc-cb84-963a403385ca@redhat.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-02-21 at 10:05 +0100, Hans de Goede wrote:
> Hi,
> 
> On 2/14/22 22:32, David E. Box wrote:
> > PMT devices need to support runtime D3. However, binary attributes
> > don't
> > provide access to open/release methods that could be used to
> > control
> > runtime pm. Therefore, remove the mmap operation. The data may
> > still be
> > accessed with read() calls.
> > 
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > ---
> > V0 comments:
> > 
> > I expect that this is an undesirable solution because of the ABI
> > change.
> > I don't know if anyone is using this ABI outside of our Intel tools
> > which
> > are willing to make this change. I'd rather find a solution to keep
> > the
> > mmap support. I initially wrote a patch to simply add the missing
> > open and
> > release callbacks to binary attributes but this was thought to be
> > too heavy
> > handed in our internal review. I'm open to suggestions. Thanks.
> 
> We really cannot go and break userspace API like this. Even if you
> are
> dropping mmap support from the Intel tools; and we assume that the
> Intel
> tools are the only consumer, then we still cannot drop mmap support
> because users may install a new kernel without updating the tools.
> 
> The never break userspace rule applies here and that is a very clear
> and hard rule.
> 
> So please respin the series using the approach with open and release
> callbacks.

Thanks Hans. I'll send out that series for comment.

David