Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp4395206pxb; Mon, 21 Feb 2022 20:10:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfmctoUNI7ZHji2MwK1B5y7e6CzZo5UMBg69P45n/t5YcXOj3J6NwEngvZlZusEw3dL+FQ X-Received: by 2002:a17:902:8ec9:b0:14f:11f7:db77 with SMTP id x9-20020a1709028ec900b0014f11f7db77mr21240169plo.136.1645503038300; Mon, 21 Feb 2022 20:10:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645503038; cv=none; d=google.com; s=arc-20160816; b=Z8j/FOBRu4vDWy92hc1240REPQC5aljNdXpF75Ydfc/jQvdnWTGmeXE1W+qd66PVRG iPRIM0LBUaYPPHDoJ3FH1bC2QZmGV9Vrx9BK1oPE0uf7rF6ht9b8p0vzA65NvKH5nAK+ 6gf97s2HKgv7nyTNKY7bkkD8UTJXpyyUSR3Va7udaeDxVxtJgCQAJN6TwUZZ7JGLSjQB oABLiFsmbPB3bgb9n6rbIPLMYRufGV+PtWr/x+YVoh0zNC4sC+6IlVKp9AWlfbLccI85 C0I58j29vJuZZ+Klc1Dti1857Vpu0hQGWxgfdZdfNr0XdnqDyFqLUXl8EsCxwCnr0M9h wV7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Nx7eZaStv2LgG+mXMFfilU92NtIfLPcoP5Tu5NM75nk=; b=1LnBesTxZw0FNHUB1IRVsZfu7QXHKw1YxBt9nuLaqi+40NI6z5Cmo5hMpoL+s26O+D GQ/3ZT3wjS+95Y9wfiwxCYKHk1AFWzy+YDJhDGy2detNS27+ENkAYlUeZ2AoArCxUKcj C5Puy8TkioDQsvPnMbV/ptqtOB5N8+K2vE+7sUMR/g32oQXGHy5m21wmGo/izWxG9O4j u9CY45NGJzC442b5tQUsvN7D2aQ52tbiJByqil0sY/Osvx2/3fFk/G7LnsiPUtEsTD6w +SKsMqKUH7K4tSJ8HlTQrgX/DBGsZydeR/camN4rC+KLDLqn5Ok7L9HlR1O0+Y1P0ERl 2kDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W5ACgQ2o; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id n14si33211779plg.436.2022.02.21.20.10.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 20:10:38 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W5ACgQ2o; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 55FAB71C8E; Mon, 21 Feb 2022 20:10:28 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353681AbiBUJ5j (ORCPT + 99 others); Mon, 21 Feb 2022 04:57:39 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352624AbiBUJri (ORCPT ); Mon, 21 Feb 2022 04:47:38 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAF1C43493; Mon, 21 Feb 2022 01:20:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8579360EB3; Mon, 21 Feb 2022 09:20:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65FCEC340EB; Mon, 21 Feb 2022 09:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645435213; bh=MG0LT0WpiF9RrSxHDVMgtYZYTt4Y0WHzXS5mZYOvIYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W5ACgQ2oD/xH3169Lc0d5P3WGA+AfujknAJI66njCk0kOL2DwF1XpnOn6eGQRg0ut jImrk+dA2cXqKP+gs8myrwIZqOT+Hbhbnp47Dx1Tj4nGF5Ggr2D+DMvM3BK+u1dHt1 b4vNYTWuXYjzGbn4EHbyip0cb/9RTGlmhWQF/ito= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Jani Nikula , Tvrtko Ursulin Subject: [PATCH 5.16 085/227] drm/i915: Fix mbus join config lookup Date: Mon, 21 Feb 2022 09:48:24 +0100 Message-Id: <20220221084937.698308163@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221084934.836145070@linuxfoundation.org> References: <20220221084934.836145070@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ville Syrjälä commit 8d9d2a723d64b650f2e6423024ccb4a33f0cdc40 upstream. The bogus loop from compute_dbuf_slices() was copied into check_mbus_joined() as well. So this lookup is wrong as well. Fix it. Cc: stable@vger.kernel.org Fixes: f4dc00863226 ("drm/i915/adl_p: MBUS programming") Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20220207132700.481-2-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula (cherry picked from commit 053f2b85631316a9226f6340c1c0fd95634f7a5b) Signed-off-by: Tvrtko Ursulin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -4843,7 +4843,7 @@ static bool check_mbus_joined(u8 active_ { int i; - for (i = 0; i < dbuf_slices[i].active_pipes; i++) { + for (i = 0; dbuf_slices[i].active_pipes != 0; i++) { if (dbuf_slices[i].active_pipes == active_pipes) return dbuf_slices[i].join_mbus; }