Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751836AbXBPBN6 (ORCPT ); Thu, 15 Feb 2007 20:13:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751841AbXBPBN6 (ORCPT ); Thu, 15 Feb 2007 20:13:58 -0500 Received: from smtp.osdl.org ([65.172.181.24]:41950 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbXBPBN5 (ORCPT ); Thu, 15 Feb 2007 20:13:57 -0500 Date: Thu, 15 Feb 2007 17:10:35 -0800 From: Andrew Morton To: Marc St-Jean Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master Message-Id: <20070215171035.83918aae.akpm@linux-foundation.org> In-Reply-To: <200702151926.l1FJQT2o020816@pasqua.pmc-sierra.bc.ca> References: <200702151926.l1FJQT2o020816@pasqua.pmc-sierra.bc.ca> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 578 Lines: 15 On Thu, 15 Feb 2007 13:26:29 -0600 Marc St-Jean wrote: > + status = *(volatile u32 *)up->port.private_data; It distresses me that this patch uses a variable which this patch doesn't initialise anywhere. It isn't complete. The sub-driver code whch sets up this field shuld be included in the patch, no? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/