Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 21 Feb 2022 14:00:00 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: use BIT macro instead of left shifting
Message-ID: <20220221110000.GD3965@kadam>
References: <20220219183234.31216-1-mosescb.dev@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220219183234.31216-1-mosescb.dev@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9FDmnKGPDKOnDDva1OhqPXL3ebSPw7rbEfKKtA48W/ZnMcQWbGZCrKbyj5/y?=
 =?us-ascii?Q?nQ9RzopH+m8wHfcF4QtZE/7x5a/1ryJxWu2rXy/D/sQgJycJshnYHg3/Efd3?=
 =?us-ascii?Q?QGmDgzCT+upYM7FVdS02zLEj3AZgMGZaxdfNLRT/D9UVJpoq+AvaeHV7CqMn?=
 =?us-ascii?Q?/3WlSFcqEbMy+46XRZRHKsEkjA/SoaRLvuCwRbQaMQVudiQp+cgCXZoG6lzP?=
 =?us-ascii?Q?RIq0Ncob7OiY9A4McldWik78uA7t5MzvcWEPIjbnxWri4BrHJHHi7/RdDcqM?=
 =?us-ascii?Q?POMqybg5GhUCF0eOsQ7rEMWHJGQhv2AkHrXLphCnSNK/7AAKS1KWg5izxzaL?=
 =?us-ascii?Q?W0XOi7E9zYrDjBYL6VCNamf7+UqZcFYmVTjdmqJk0eR57ldFqNhlrRdAyC94?=
 =?us-ascii?Q?ZLU53PchBQNW4kN/6f/NytQFuXt0RP7tCc42Amp3XZK6dupgtSmzFtIs9oRQ?=
 =?us-ascii?Q?rM3h8Ag3vxdufnTSnjHKrI2IVwpM5UEy0fJIC3uFPPxbvoitjpHUlweogq41?=
 =?us-ascii?Q?SScK20GlVvscqP+1OvnNOnMN1OhhLCwAz1Wg3ji87oA8dleoRTSAYtY9jIj2?=
 =?us-ascii?Q?6Vlp0e6QPP4/Q2ZokSDmUsDOegF7HTfxmKxyIwE2nvLUimLKWDnxHfKPiJE6?=
 =?us-ascii?Q?Is69sONBYgXkeLjbHb61Ocu2MYDmrWo3HdvBCyq2OVnFm/7EJOi4W/W/cyW5?=
 =?us-ascii?Q?RspmRPD+ks4M9sERUiWAm8xzgLWQOAiYNSsosAduQtlt7WezTn4NjRgvl8Nk?=
 =?us-ascii?Q?xKsskc9zQSkdHGsFsZ56tEnS2KMki5wqH3HzwDxOYrewZ7vL5CR0VVknYobK?=
 =?us-ascii?Q?KkL+6IksWwTxVog9Ctw7Hwsa7ODxvgWeZnLOGIXE7dSK+4pu52KZ/RVJvJbh?=
 =?us-ascii?Q?r7HAwlBoQu+gIBPCmxy0d7Oajl7C5Yvc5h8N1cNicWLdX4il57Kq0Xj6uEIw?=
 =?us-ascii?Q?UrLGTuRmO2UlE8rVq3XxhlQLkwAWjYtfDloSXMap/yKPjt+odkRd5G+0Q6vk?=
 =?us-ascii?Q?755+zpyBvS0wWzq7DuS1nhjRibxQykdRcQwVOx1Jw84Wr4pzI4RQ+a3WraPs?=
 =?us-ascii?Q?Faz2798OzS9G5V+DGzQfrPzNCe+dPAFBA6F9Lyw96qE3TqjCNxUMVtMVdywl?=
 =?us-ascii?Q?32Fko9W7U8S6vkANhrkFuA48pgcW3/LrqjrsHLi/YJ4p9K6mi217z8ttN8pw?=
 =?us-ascii?Q?hD56CJPQGUtj7fiDLUuv8cvjmdNmJs++j4HVLOp8cjEwVOHxxkmU9z6YKFdj?=
 =?us-ascii?Q?XkHov/0qyQC7KDH9AHZNdxpw4eHKljsnWAf3vUT7f3NeZ/ljQJdnezp8AC11?=
 =?us-ascii?Q?/LLfAoXKptzeydiBp2uREwuCmeTpXNFC6BmkYeRY7SNwJcX72/1Me1EicF16?=
 =?us-ascii?Q?HkOxAA5rpIFarcPP9krJn19Lil10AfRkazPfFdgNOOBxU5UzjniwB9HPm4bn?=
 =?us-ascii?Q?ZLiEKhEZzHenwkmCTiQN1zTEfKt5CBN+17JV+yISZw9OzZ8VcZdoxu3h4g3c?=
 =?us-ascii?Q?y/Td7yoSQbHWP/2X2/5w7DPWepTpBPS07kd1e7jVIdUhgoIVxnLwgZkFTgP3?=
 =?us-ascii?Q?JOSt0lpTrGpZl/jj8AdJLe3NXKqv0mo4JKb7c3Rd+5fiMwrLcfNuKuezWo5c?=
 =?us-ascii?Q?5Jkt2VtSpdv2oT/JoN0bIYyT01xaVm0BHbEhARjVLwaqt3q2hGpb3RotAs7N?=
 =?us-ascii?Q?R//pjA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3817fd9d-d3b4-43ff-78df-08d9f52957ce
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 11:00:17.2436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: APNSfEgJiN9tkLeJr5tWcX/umIeWWUiRaocjeFkd/5b/Xo9hxr9P8k3na+nN7n6SgBIMoit/438exDoDMxzhcqcB2ChDhoc19kEsAwoQla0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4450
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10264 signatures=677614
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202210065
X-Proofpoint-ORIG-GUID: H4mdm_mFc2aCrEXHALFWPZrZh6dEYBZm
X-Proofpoint-GUID: H4mdm_mFc2aCrEXHALFWPZrZh6dEYBZm
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 19, 2022 at 07:32:34PM +0100, Moses Christopher Bollavarapu wrote:
> There is a BIT(nr) macro available in vdso/bits.h
> which is doing the same left shift operation
> 
> Example: (1 << 7) == BIT(7)
> 
> Signed-off-by: Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
> ---

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter