Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <80fce7df-d387-773d-ad7d-3540c2d411d1@amd.com>
Date:   Mon, 21 Feb 2022 15:31:49 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 3/3] KVM: x86/pmu: Segregate Intel and AMD specific logic
Content-Language: en-US
To:     Like Xu <like.xu.linux@gmail.com>
Cc:     seanjc@google.com, jmattson@google.com,
        dave.hansen@linux.intel.com, peterz@infradead.org,
        alexander.shishkin@linux.intel.com, eranian@google.com,
        daviddunn@google.com, ak@linux.intel.com,
        kan.liang@linux.intel.com, x86@kernel.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, kim.phillips@amd.com,
        santosh.shukla@amd.com,
        "Paolo Bonzini - Distinguished Engineer (kernel-recipes.org) (KVM HoF)" 
        <pbonzini@redhat.com>, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220221073140.10618-1-ravi.bangoria@amd.com>
 <20220221073140.10618-4-ravi.bangoria@amd.com>
 <1e0fc70a-1135-1845-b534-79f409e0c29d@gmail.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <1e0fc70a-1135-1845-b534-79f409e0c29d@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGUvZlZ5aW56M3VvenpDWDF6bFI5dmVCT2tNQ3lEOWlOUWh1ZlRBYTVmOXZq?=
 =?utf-8?B?TTlTYThyNUZWQzlmcEx0bGp3V29ycjh4Wk54S3NzcG9FRThkQUVWbDhSdVFH?=
 =?utf-8?B?d0Ntb2ZUVFFaUmNYSHFXdG8vZW44OE9VYm9mdVQ4THNSM0JuVFpmcitwMmJw?=
 =?utf-8?B?OXYvOGlJQzRSRHdiWWVOVEZubWc2WW9TOGlnTXFJcHZxeUVFbUttMmtkOWhM?=
 =?utf-8?B?c1JTaU5sV003NUZ3dzJtOE9pck52VDQxK2hHNkFySk5mR0FNNjZnZXV3NkVy?=
 =?utf-8?B?YTZnL2l2VEQ5MUtZUWMwNjh2QjUrTEhEckVWeFdHdXNwZnlWdzlVOU44Y2xT?=
 =?utf-8?B?VjZpTmVvU0pLT1JoY2pWVFZLYzhGcjBjbUVwSTdFRTEvbThpNFZEenhpeGdQ?=
 =?utf-8?B?SWROZ21yNjE4U0dRVFByQjFyRjcyazFTY29IeGRGcmlqbVFPYXdvWlIwejJp?=
 =?utf-8?B?TUZNZlRvRFVqNncyVGhyRlZzTmNIZmJ5Nlg4Z1J5YStzcWlRTWZpb09qd3R3?=
 =?utf-8?B?K2xQdllhUXFCeG1SNG5YVzZOeG5nN3ZTekZEMyt3eVFvU001YW5KTHZEOFFL?=
 =?utf-8?B?UWJTRERGenlYaVZsWVYvcmZKSmxlZVJ3WTdveDJpOFVVdnZLRUJaYUhwaVNJ?=
 =?utf-8?B?YjZUL09jeHFPQVdvUE1CeVlFRHVKT0NKcEJZVkdDTmQrbkYvY2o2aEppNTNW?=
 =?utf-8?B?YTh6R2N1MEZ4NitGRWt0aHhjd2lhczB0WU9OaHNGZFVyeGx5b0JELzJsVzB5?=
 =?utf-8?B?Z1ZmL2xiQ2FZenU0Qmx4dlJZM04zd0RXUmUrYUVtTjRSanc3NjZsQm9mMCs0?=
 =?utf-8?B?REh3M0oxUnZOVS9UazlRbnlVUW85NXBVNCsxSUdhRlM0aUNHL0E4UjdxSldD?=
 =?utf-8?B?NElhM3JMZDJ1dnArTm5VblZQS1dDNTRmR0s5NDF1UzhlME84NWNXMjhnKzBN?=
 =?utf-8?B?aFRzWEg3RjREbnorTHlNMFpmOGpqY0hTU3VpdWZuNWdpN3ZjVUdmbWxlczdh?=
 =?utf-8?B?aUp5RDhER3UxMU5qWlJIYUppdUUrRzM2VVczQkpZZ0hxVFZSQlZyK2pmRHkr?=
 =?utf-8?B?ekRwTkhIVXZZUXVOTkJGQWp4dGJTdnQ1WVd0dXU3ejRWYlJESzJQaDhxWkZ0?=
 =?utf-8?B?SFMzUGNGbTZBRUVlWUdDcGVOY0FrY2kxc091L3VVazk2SkhPUndrUytMcWJh?=
 =?utf-8?B?Q3FwU2tCZU5HY044aDlIZzVOKzJJUjluUDA2M0RmNm1yeFFzOVN3aHRsZW5U?=
 =?utf-8?B?UHlvSnd0SFhsTllPblpzekllSk8wVHRBd00rRGJnaXVVbCswc1JyN0hpZU56?=
 =?utf-8?B?cHYva2E2cUdFbFpnMFRDWjQyRDNKbDV4YnNYSmV2aTdvb2lDNFovc0hxWWZp?=
 =?utf-8?B?WHhvUkRTMWRGeUZtQ1VUYTdPdW5tTjE0bW1JYnF0NXFIUjAxTnJ0eUoxYmZZ?=
 =?utf-8?B?T050ZjQ1TGE5VS8wWDJzMHlHa0xJWFB0TDMzZXpnRFNCRHVNaTNKYlVxUmpX?=
 =?utf-8?B?VWZ3S3ZNMmdBbjBYMmM2eitWVzB5V1hSRlkxbGJ1cm9QOHVqUFdIelZCU1FC?=
 =?utf-8?B?U1RlOXVRSWV0c2M1eEZoRllSbTB4NmRZNnF4eERhNEIydndxNnlNVVkrTU93?=
 =?utf-8?B?YVAyZG1iTm5sUnFKT21CNGQ0anRIRGtrdy9zczBSMVZ6ZDBoL0Nsam5VMVJ1?=
 =?utf-8?B?TTZhb25RRlEzcmEzRVFCTlB2clJjN1NteHQ3aWRDakRLWG9HRVM5L3BLalE3?=
 =?utf-8?B?NHJKTFpsVHlJSG1rS25yakh5UFdxdmVnM3FZdXdkNUhjdEdNbkVIbE1HWFZM?=
 =?utf-8?B?SmwvK1gvZS9CV3Q5azVKYmtwa2JrS3l3YWhDUm91MWNwaFhvazN5SFp0cEZ2?=
 =?utf-8?B?MHp5ckIxOVZxTUJxbmZHR3pNSGd3OFVFTFBERGlnRWEvcEswQ3A4TlU4S3NR?=
 =?utf-8?B?QlhjcUlwU3hUTSt2T3RQeFdVb0Z6ODJOdXlibDVqbVZ0Yncwbmh3T2NEZ21G?=
 =?utf-8?B?TFlQRjFHdWJMMURCZG93UXhwTXdNYmF6aFB5UVpmN2hMYnQvQWV4VC90Z0J1?=
 =?utf-8?B?UjFEalJyS1djR21MekJrcG50T2pVNXlUdysrS2VhNGtQdGN3MHZkNkoyU3dO?=
 =?utf-8?B?QlFRZ24rUDJreGRlR1I1SEhRaGZYRHVudzVNdGtwMnB5TnpZQmI2TW10K2p6?=
 =?utf-8?Q?IzyZbcVtQRfX29eXj2aIjs0=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 263ddc83-cb52-421c-d54d-08d9f5213927
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3053.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 10:02:09.5492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6jBGEljQY1/b7VZT847plKicw8ah9PtL5f+0dpurSEkrsm+UFWWR+obTell/AATzyVmNL6WaHVPR0+O8+bo3xg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5196
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21-Feb-22 1:27 PM, Like Xu wrote:
> On 21/2/2022 3:31 pm, Ravi Bangoria wrote:
>>   void reprogram_counter(struct kvm_pmu *pmu, int pmc_idx)
>>   {
>>       struct kvm_pmc *pmc = kvm_x86_ops.pmu_ops->pmc_idx_to_pmc(pmu, pmc_idx);
>> +    bool is_intel = !strncmp(kvm_x86_ops.name, "kvm_intel", 9);
> 
> How about using guest_cpuid_is_intel(vcpu)

Yeah, that's better then strncmp().

> directly in the reprogram_gp_counter() ?

We need this flag in reprogram_fixed_counter() as well.

- Ravi