Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp4423735pxb; Mon, 21 Feb 2022 21:09:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzJcmCFzpGc4XF1QlzjtTYpo6TGJnRdW+hno22XC2te5QqRrUaY8B811Nuj04pjNq9QX129 X-Received: by 2002:a05:6a00:a8f:b0:4e1:2619:11a2 with SMTP id b15-20020a056a000a8f00b004e1261911a2mr23061558pfl.53.1645506584583; Mon, 21 Feb 2022 21:09:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645506584; cv=none; d=google.com; s=arc-20160816; b=gtrX70iTXTMENWgh/88eXSfkGUxOSwQ5iG3lctNbJdUBx/sLRFTOX4YMUMc4JBWeih 1dqkuUdxoE4cp68HhP439tyAh7nRqFaFF2twK886Arzlj7gE8bHkOALNr41pQDD5IKz7 UE4Y45yECQ41QY2w/iVffR9j7/KwVgFsXgBH3mx6MpIDlyIKIxB5KASvJ604rXf2lGms 8EFYEBPb80mtxkZCYNVHsp1MDTMKBFyLijYqwXS2PLyJQeK2a3h60ZucIzMbNMmvCCyu HAl468OQKVOJpQjIDjTAB2T0rUqMSSznQSo2fiA2eLwBXB+m7C4oh2dSPqbSdfnQ6Q8N 9+Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nEMxcOTTGeQD0PZ5JBr3mRXBVAXYUTuBZ6q2k/sTO6I=; b=f4tXchGxsOui27XO4ETIHjk7OyY57VkZgipYp+s3M/PD7vg3QHHvmL4KU2jpz3+Woy 3fpHO8slaQSWK+BhB+o33Kbqc4geJhqMIZFUFUEJ5UWmEZqIZpkedW6yIneOuVQ7ndxs dvKEl0KwKZucn0xOO+fbPz8sLgMNMFhZC6uFNpe3pTSsDAVbReC+DVqumoH+0WMpNW+q X58Vt05er6aL7tW4CI2HnIuQbYeDE/dyAkxlZmVXffvMsOQvWp8m3hXRFkLyEaYqmc0l /opuK1woSNzoeARVLJfezPmRc/wXkCWauYIy2Do1ZriTFloKK+uDTbEZPE2IgbDoAv2a 5hyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RvYvsJX7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id u190si18693827pgd.578.2022.02.21.21.09.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 21:09:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RvYvsJX7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9ADA3C7EBE; Mon, 21 Feb 2022 20:42:44 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353253AbiBUKK2 (ORCPT + 99 others); Mon, 21 Feb 2022 05:10:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353381AbiBUJ5X (ORCPT ); Mon, 21 Feb 2022 04:57:23 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DCC347543; Mon, 21 Feb 2022 01:25:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 38630B80EC8; Mon, 21 Feb 2022 09:25:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76B4DC340E9; Mon, 21 Feb 2022 09:25:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645435529; bh=+xU+t0NzArgC2mwJX47PWr8hw6Accvne3hpMD/rsWAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RvYvsJX7MphlUbysFpEPs6CLlZZH7CGZRTfNuevq2eHbXKbVlaQs0T+7QZZnOCKbr trB6decZbjN/I1mRMVOSeRPcM6tlm8NbIz6zO19SeUFY6g808MQDIV+wtL3Lv80Iuo KhHureFPUO6jFWEMMY7OjUwEjHFGaYxv7J77EM3o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stephane Eranian , Jim Mattson , David Dunn , Paolo Bonzini , Sasha Levin Subject: [PATCH 5.16 196/227] KVM: x86/pmu: Dont truncate the PerfEvtSeln MSR when creating a perf event Date: Mon, 21 Feb 2022 09:50:15 +0100 Message-Id: <20220221084941.333970410@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221084934.836145070@linuxfoundation.org> References: <20220221084934.836145070@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jim Mattson [ Upstream commit b8bfee85f1307426e0242d654f3a14c06ef639c5 ] AMD's event select is 3 nybbles, with the high nybble in bits 35:32 of a PerfEvtSeln MSR. Don't drop the high nybble when setting up the config field of a perf_event_attr structure for a call to perf_event_create_kernel_counter(). Fixes: ca724305a2b0 ("KVM: x86/vPMU: Implement AMD vPMU code for KVM") Reported-by: Stephane Eranian Signed-off-by: Jim Mattson Message-Id: <20220203014813.2130559-1-jmattson@google.com> Reviewed-by: David Dunn Signed-off-by: Paolo Bonzini Signed-off-by: Sasha Levin --- arch/x86/kvm/pmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c index 3b3ccf5b11064..944137ed1f901 100644 --- a/arch/x86/kvm/pmu.c +++ b/arch/x86/kvm/pmu.c @@ -95,7 +95,7 @@ static void kvm_perf_overflow_intr(struct perf_event *perf_event, } static void pmc_reprogram_counter(struct kvm_pmc *pmc, u32 type, - unsigned config, bool exclude_user, + u64 config, bool exclude_user, bool exclude_kernel, bool intr, bool in_tx, bool in_tx_cp) { @@ -173,7 +173,8 @@ static bool pmc_resume_counter(struct kvm_pmc *pmc) void reprogram_gp_counter(struct kvm_pmc *pmc, u64 eventsel) { - unsigned config, type = PERF_TYPE_RAW; + u64 config; + u32 type = PERF_TYPE_RAW; struct kvm *kvm = pmc->vcpu->kvm; struct kvm_pmu_event_filter *filter; int i; -- 2.34.1