Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "dsterba@suse.cz" <dsterba@suse.cz>,
        syzbot <syzbot+087b7effddeec0697c66@syzkaller.appspotmail.com>
CC:     "Mason, Chris" <clm@fb.com>, "dsterba@suse.com" <dsterba@suse.com>,
        "josef@toxicpanda.com" <josef@toxicpanda.com>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "syzkaller-bugs@googlegroups.com" <syzkaller-bugs@googlegroups.com>
Subject: RE: [syzbot] WARNING in kthread_bind_mask
Thread-Topic: [syzbot] WARNING in kthread_bind_mask
Thread-Index: AQHYJoehTUhlgvCkqEmrg5tJq/UDJqyeEEQAgAC8pWA=
Date:   Tue, 22 Feb 2022 01:51:11 +0000
Message-ID: <PH0PR11MB5880628B1A335AC389D980ACDA3B9@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <0000000000005ca92705d877448c@google.com>
 <20220221142358.GE12643@twin.jikos.cz>
In-Reply-To: <20220221142358.GE12643@twin.jikos.cz>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.200.16
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hupwrfck06JgiO8lhvDEPjR+LpFLpImIio2HEI25HjTP515gvmF13zmHK6h5?=
 =?us-ascii?Q?iTbne6ZF3MPIrZ5TNcNUZfLyHxWEArJXI0dNxybxH1gDL29ZyZmmq4cBB6U/?=
 =?us-ascii?Q?14iXM6qQ31Zv4skb5EngNE9dCawjXC995IDtJ3nADFTWJfoQQ0tX7RXn2qx0?=
 =?us-ascii?Q?kkKT9LF3M90QSWo4Ke0mruVRltTiSPpG5y7ctrxOblJpcE30jsmTZ9647fnt?=
 =?us-ascii?Q?a5kmUP6INi+ku8FFyyj3GKOMl9qApZcoOM29+BGnxafDv9u+24e9KRSX1dbj?=
 =?us-ascii?Q?/ced7JDZVOMw5wwEtpwLESrLN4ipqP/UDBcN+0XK4XC2tDQW4D08agcxGSGU?=
 =?us-ascii?Q?SQBUOZvtw0JF/mQ6BIuHckITDitit/EAUP05XkPpOaJEsRjGnwg3YC8iAUSc?=
 =?us-ascii?Q?Ap7Fhb27XkigrclTPTvXkQzRajiNLsFz1XkOFpqi3sZesBGTdGp0JVGpNliI?=
 =?us-ascii?Q?UeTh62ybtXS5om+7g1Ne7IcmBliWRSxoCVPf/Fmt/UJmhHhzChvTw96f+4o5?=
 =?us-ascii?Q?QaeK0xTUYKGEHTFWeX2QDgictz4IEThQo6pfWoX7X2jqJN0noSavautJ9mdp?=
 =?us-ascii?Q?Ct7ZKU/kZasz02q8dTGOgBLS4SymSxJ0vF+7dbZCBTrNib/1DVoXfXZZ8DI/?=
 =?us-ascii?Q?2c3O43kLufN33nUU7Le/aseMCE6BqJUhuxbhkm1PplHxsvrL9l+8+d0Gir1P?=
 =?us-ascii?Q?mcrK7LOGvH8cgxVdKk3RbDQgW79VCJpxYWJYgRtaT+3MSD7kOKuwVE5vCcYO?=
 =?us-ascii?Q?XuwDsYO27xnSq/4jQqLkWfNwAZDmh7/d1fmxkDAyKJYKHDz3GJ+ywZmNXx4U?=
 =?us-ascii?Q?XHS4es73nTUXcKs3Gan5yXK1y0Jc/PZgqmYFZZ/BN4O28ITAGPEcFrzdJEpr?=
 =?us-ascii?Q?HPP9i9l/BT2FLpUYx71rN824dpbAJbKHwJVKB7VFUz3DpF2/XHKGWFVzbURM?=
 =?us-ascii?Q?osu/4xhwdTBQJYD0rEpJHiWZfDWfO9KStcf3mYfOYDWYyQvaKwgRIg4HF9O1?=
 =?us-ascii?Q?ZAuNyzx7FaLPcrdAuqNW2rXzj8iWmJPnVgi+9rv1JKtLKvDCm0HkTCeLGukt?=
 =?us-ascii?Q?Cgl4E3ic4HWgHHBvQeblSHz4n5FVwfOqxyy6xGPIdDMq1L5uLw0qo7SMS4y9?=
 =?us-ascii?Q?hX+8IF8e3OmRqQW26utpgIl0MfHb/7iysE4FAW5AFt02Zy9x24IbEnuCcw88?=
 =?us-ascii?Q?wP7KuIk4UwbRNBgOtcqKJ0qXV9mb7/gBfTPyUA6RpJPv1odG8iLySoqrl4ww?=
 =?us-ascii?Q?AJjpcjgszSnPm0tkJSEh/Khd5pmM091phYgGHL/LbhiuTP7m/jCchM4j/H1x?=
 =?us-ascii?Q?qzzZLhj1Nre/lkuqMldI9p7R2eOn7egQcTau/oVB1I1PKkhkDfwUc0HLyA3h?=
 =?us-ascii?Q?L7CvFmtzTy1yAB3UyGVr2LwMENnqb1JtTOPkVzaIpsYrHFQQ9hEn+H78gVZq?=
 =?us-ascii?Q?z79Z1px+dqZVbf4R+kFaevKoge/emCJOHhiKR5JKu4E4+RWCd8xQLjqV6hYP?=
 =?us-ascii?Q?mmOxLgNiDgLqwIeYtDPSEbFxM3O5Ze265KyG+ops1g1SpxAJ8qR5g0huZdjO?=
 =?us-ascii?Q?TKxYTWKbrguTrB6/jtzhsdfqlrldQDR3QlzdqJ76MAC9ahS1U8DtbLlZUEQD?=
 =?us-ascii?Q?rA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 639aa88a-1115-4b75-ecc4-08d9f5a5cdc8
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 01:51:12.0073
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p/ddnl+mHOP2pdrpBGEnVdN6wYaQGuFIRDiRCy/a5ZwbImA7mPc1fv2rCcKthswBCToeBrIQldm3wRbPztM9yA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2264
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Sun, Feb 20, 2022 at 10:27:23AM -0800, syzbot wrote:
> Hello,
>=20
> syzbot found the following issue on:
>=20
> HEAD commit:    c5d9ae265b10 Merge tag 'for-linus' of git://git.kernel.or=
g..
> git tree:       upstream
> console output:=20
> https://syzkaller.appspot.com/x/log.txt?x=3D11daf74a700000
> kernel config: =20
> https://syzkaller.appspot.com/x/.config?x=3Dda674567f7b6043d
> dashboard link: https://syzkaller.appspot.com/bug?extid=3D087b7effddeec06=
97c66
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binuti=
ls for Debian) 2.35.2
>=20
> Unfortunately, I don't have any reproducer for this issue yet.
>=20
> IMPORTANT: if you fix the issue, please add the following tag to the comm=
it:
> Reported-by: syzbot+087b7effddeec0697c66@syzkaller.appspotmail.com
>=20
> BTRFS info (device loop3): disk space caching is enabled BTRFS info=20
> (device loop3): has skinny extents ------------[ cut here=20
> ]------------
> WARNING: CPU: 0 PID: 10327 at kernel/kthread.c:525 __kthread_bind_mask=20
> kernel/kthread.c:525 [inline]
>
> 520 static void __kthread_bind_mask(struct task_struct *p, const struct c=
pumask *mask, unsigned int state)
> 521 {
> 522         unsigned long flags;
> 523
> 524         if (!wait_task_inactive(p, state)) {
> 525                 WARN_ON(1);
> 526                 return;
> 527         }
>

Maybe we can add some additional debugging information  to view the status =
of the process.

diff --git a/kernel/kthread.c b/kernel/kthread.c
index 38c6dd822da8..e707e86ee64b 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -29,7 +29,7 @@
 #include <linux/numa.h>
 #include <linux/sched/isolation.h>
 #include <trace/events/sched.h>
-
+#include <linux/sched/debug.h>

 static DEFINE_SPINLOCK(kthread_create_lock);
 static LIST_HEAD(kthread_create_list);
@@ -521,8 +521,8 @@ static void __kthread_bind_mask(struct task_struct *p, =
const struct cpumask *mas
 {
        unsigned long flags;

-       if (!wait_task_inactive(p, state)) {
-               WARN_ON(1);
+       if (WARN_ON(!wait_task_inactive(p, state))) {
+               sched_show_task(p);
                return;
        }

Thanks,
Zqiang

>That seems to be some internal task state inconsistency.