X-Received: by 2002:a17:90a:3f09:b0:1b8:e615:a261 with SMTP id l9-20020a17090a3f0900b001b8e615a261mr2467956pjc.196.1645507659717; Mon, 21 Feb 2022 21:27:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645507659; cv=none; d=google.com; s=arc-20160816; b=hId10OdoSi3RsQMbaVuCZOMV2JIavI74sG1CNxkLosPK2ErFkmVx2te7CH1vXcp6Vy LHwKkbw7Rpp0+43O7xIDnM8K+x9UrlWOktP66b7/yoiLU03PrqcKB8yn9Bz1NDkd1LCs Br+v7CdpKcT/NiLaAKORFhT1gAIDDiOLg6+R02dDP5Om4CJXIk25eydUrXSby99vwQi7 zGVJRzttPOyNLW5waPHXYN6mhUijyrlMJjCGWig29NfrVTuBTANv+RrqyUpyqKHACyHN S2PIhPFEBQdxHrS+werypwh2FUMzw4nDhBq6Ef+iMe5fKd4eg6yEkzdG4CVTXN9/ZGie 4J1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sSv0HmTBvPQGGsw5gnGusdRvXA7M0AM7UlCxqCT2e9g=; b=Btez7NspXDGVnBKFgzG1n1/YFMQ1W9c3YHEQtXax1H1k6P7x/jVGSs6obKHgMGz7kX enRz3l85qJVeUsZKef2bAeiAb+Xo6ygGH8HzEB0UDRLqvPMqRuuNwio3+yuXK+SMco95 bmTG2ljIepVVet7Xo/C3/XmswMG6qghMctcYtghkMTlzJhF3m9trsfr1idH5AXYfI5Hh RG5KD+TB4NvLKC9wN+qNo7n+Cp1j2HLXxkzswC3mBJ9iKSUNsaDhWFBUHj/mY16sDjWX sO0QbDX92I6be3edvNSyoDepnSU6gw9ajfYwf9767u0c8iCCKZOqS85B7KaJH6lTzXnv /tkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i7XJABFy; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id e19si18871889pgl.818.2022.02.21.21.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 21:27:39 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i7XJABFy; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AE9D75597; Mon, 21 Feb 2022 20:57:10 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240407AbiBUJyb (ORCPT + 99 others); Mon, 21 Feb 2022 04:54:31 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352521AbiBUJrd (ORCPT ); Mon, 21 Feb 2022 04:47:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CCF533E8E; Mon, 21 Feb 2022 01:20:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F66060B1E; Mon, 21 Feb 2022 09:20:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAF60C340E9; Mon, 21 Feb 2022 09:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645435204; bh=OSHo2PJpIYtB2DIHy0v4CkW2SRFnO9seM4Vk8G09WJg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i7XJABFyNBCCh7qRL5X9MoKI2z+qSpcnEwSGMqs1DznJbYalBwHUBYY4Cjqx6z+xv qYImAPrXxD+bjme+1W13JH/Fl1iOeQwGFpkojvCiDRobBtY5eqP6olWAIa4sWi8m8Q VsLf3T4K+oc6DWZ6s/RNgbraU16I6LZ8eSb9dT4w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Xu , Shuah Khan , Sasha Levin Subject: [PATCH 5.16 040/227] selftests/zram: Skip max_comp_streams interface on newer kernel Date: Mon, 21 Feb 2022 09:47:39 +0100 Message-Id: <20220221084936.197002900@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221084934.836145070@linuxfoundation.org> References: <20220221084934.836145070@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Xu [ Upstream commit fc4eb486a59d70bd35cf1209f0e68c2d8b979193 ] Since commit 43209ea2d17a ("zram: remove max_comp_streams internals"), zram has switched to per-cpu streams. Even kernel still keep this interface for some reasons, but writing to max_comp_stream doesn't take any effect. So skip it on newer kernel ie 4.7. The code that comparing kernel version is from xfstests testsuite ext4/053. Signed-off-by: Yang Xu Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/zram/zram_lib.sh | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/tools/testing/selftests/zram/zram_lib.sh b/tools/testing/selftests/zram/zram_lib.sh index 6f872f266fd11..f47fc0f27e99e 100755 --- a/tools/testing/selftests/zram/zram_lib.sh +++ b/tools/testing/selftests/zram/zram_lib.sh @@ -11,6 +11,9 @@ dev_mounted=-1 # Kselftest framework requirement - SKIP code is 4. ksft_skip=4 +kernel_version=`uname -r | cut -d'.' -f1,2` +kernel_major=${kernel_version%.*} +kernel_minor=${kernel_version#*.} trap INT @@ -25,6 +28,20 @@ check_prereqs() fi } +kernel_gte() +{ + major=${1%.*} + minor=${1#*.} + + if [ $kernel_major -gt $major ]; then + return 0 + elif [[ $kernel_major -eq $major && $kernel_minor -ge $minor ]]; then + return 0 + fi + + return 1 +} + zram_cleanup() { echo "zram cleanup" @@ -86,6 +103,13 @@ zram_max_streams() { echo "set max_comp_streams to zram device(s)" + kernel_gte 4.7 + if [ $? -eq 0 ]; then + echo "The device attribute max_comp_streams was"\ + "deprecated in 4.7" + return 0 + fi + local i=0 for max_s in $zram_max_streams; do local sys_path="/sys/block/zram${i}/max_comp_streams" -- 2.34.1