Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220217162710.33615-1-andrea.merello@gmail.com> <20220217162710.33615-13-andrea.merello@gmail.com>
In-Reply-To: <20220217162710.33615-13-andrea.merello@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 21 Feb 2022 21:32:00 +0100
Message-ID: <CAHp75Vezc+ieFE23unzNdcz5YeuduOO7OJWyS=HvEUAE4=x7Ag@mail.gmail.com>
Subject: Re: [v3 12/13] iio: imu: add BNO055 I2C driver
To:     Andrea Merello <andrea.merello@gmail.com>
Cc:     jic23@kernel.org, mchehab+huawei@kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, lars@metafoo.de, robh+dt@kernel.org,
        matt.ranostay@konsulko.com, ardeleanalex@gmail.com,
        jacopo@jmondi.org, Andrea Merello <andrea.merello@iit.it>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 17, 2022 at 5:27 PM Andrea Merello <andrea.merello@gmail.com> wrote:
>
> This path adds an I2C driver for communicating to a BNO055 IMU via I2C
> bus and it enables the BNO055 core driver to work in this scenario.

...

> +#include <linux/i2c.h>
> +#include <linux/regmap.h>
> +#include <linux/module.h>

Keep it sorted?

...

> +static int bno055_i2c_probe(struct i2c_client *client,
> +                           const struct i2c_device_id *id)

You may switch it to use ->probe_new() (you may leave I2C ID table for
possibility to instantiate this via user space).

...

> +       struct regmap *regmap =
> +               devm_regmap_init_i2c(client, &bno055_regmap_config);

Please, split the definition and assignment.

> +       if (IS_ERR(regmap)) {
> +               dev_err(&client->dev, "Unable to init register map");
> +               return PTR_ERR(regmap);

return dev_err_probe(...);

...

> +       .probe = bno055_i2c_probe,
> +       .id_table = bno055_i2c_id

Missed comma.

-- 
With Best Regards,
Andy Shevchenko