Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Subject: Re: [PATCH net-next v3 0/3] tun/tap: use kfree_skb_reason() to trace
 dropped skb
From:   Dongli Zhang <dongli.zhang@oracle.com>
To:     netdev@vger.kernel.org, bpf@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        rostedt@goodmis.org, mingo@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, imagedong@tencent.com,
        joao.m.martins@oracle.com, joe.jin@oracle.com, dsahern@gmail.com,
        edumazet@google.com
References: <20220221053440.7320-1-dongli.zhang@oracle.com>
Message-ID: <213e06fa-13be-f9c1-f9dc-613e0cb6a39d@oracle.com>
Date:   Mon, 21 Feb 2022 14:53:12 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <20220221053440.7320-1-dongli.zhang@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTIwVUdybklBeGNIREtUWjJHMzN2ejQxaTJvZzNVUTVtSlV0cCtlcDNHZ1d3?=
 =?utf-8?B?OS9zbkVhbXJNT1gxM0hXQ3hzcloxbW9pUmtOZ24vNFRkUzJLcmViaVd3MTdC?=
 =?utf-8?B?VmN3eVlmNlNDNzJhNkJtb25qODNKOXZrVDd4TW1jellwQTNLSzhuajFHVHM5?=
 =?utf-8?B?U0thNGt5djVjOWw2NC9Udy9GV0M5Uml5N1BRWkQ2ZTRTZmJiZDFzY3UvMGlK?=
 =?utf-8?B?U2NkSi8vSHFyUklxL1l4bXFFbFRZSWliaUlWNGdhZ2tiYWFFcWVabVU1czU1?=
 =?utf-8?B?MWZHaGZqcGpQODhrZEhScmpIdS9RNThobElqcC9NMEkrR1lLdmxydWYrM3FQ?=
 =?utf-8?B?T25pMVVMeHdhalIzUmRlQVFhUytvWlYwQVhZT0kvQmpIZGYwUjdCdUp5aHIx?=
 =?utf-8?B?RmtZUGRRdTZtb0NLaTVsRVRrMkxpbUlSQkg0d2FObDdIRlMzckJBV01hcW1q?=
 =?utf-8?B?MWlDT2ZYMGwveFRpV0lpWTdkb1JRSjJCbWRIeGhZbi80WE1VZ05ob0IrY29q?=
 =?utf-8?B?M3RtT2did1dzeFlmdjdSSm1NeUJJcTUvdk9Id2tiNnN2RnFuRGFlMWVxeVVu?=
 =?utf-8?B?ODRFeERKT243VUFWclgvdjhoWVBwb2lkdGlNQ1RiSjhrUTFpZEZ4OFR0T2ZP?=
 =?utf-8?B?cDRnZ1VyQ2VLM0ptWjF4cU5ib1NmVk9uTDJQZ1R0Q1E2aW9RaENCY0NIYjBh?=
 =?utf-8?B?Mjc3OXJDQjRJaHhQY1hsQzNyNGhOSW9GWGRIcWJvUUNWNCtJUjdDTVE2ZVpt?=
 =?utf-8?B?SStlZUpTUkhmVlM4bFNIWkNzaTRHZ2FVRi84UERoZGJOd3RZb0MzajNKbFpY?=
 =?utf-8?B?Ry9Hc3N5TXZMMWZWZXNXeEt3UWZpZ1ljUFRwVERna0E3M1lZNU50bm14ZnBE?=
 =?utf-8?B?Ny9aUGllcURhTFAwc05pY1JtOURiSFd4VkkxZnV6L2d5WjhPZFljMlRxenNq?=
 =?utf-8?B?cXVSa3RNQUxDV1VOWTJRTUk0OWp2bUVOcHJXbDMxdEpsOFJyR2x6TEZKWkxm?=
 =?utf-8?B?MnFaRk1ia2YxMXZ5WkJIWnE5R0VaeGpjM01rd0hWek5SV0dhL0JnRlowSXhR?=
 =?utf-8?B?K0tUUloyTTlvaUFYUHFIMWx5dHk5dUs4UFhka3poNzRLNW1Cemw4WkJMazBv?=
 =?utf-8?B?NnR0bUFucXVscG9IMXJpWUw5WGczb1M5c2NQN2Vpdm9XNE5tMzZTZmZuOFJo?=
 =?utf-8?B?Y0tQUE1GZ1lXTG9sbEoxUXVwdUJpRnpuUm1IWlFRTFBOREtTR3dsc2lMdEpE?=
 =?utf-8?B?VFpwaTF6V0NreVhhd2xmdnlPS2d4K2RwUFhYaGRpMmtMWE5QWEF2RmVXSXZ3?=
 =?utf-8?B?bldySUJ4QnRlYlpNTTVOOHAyRmluOHA5TkN0TnE0dkNwZVVqL1Z5Y0pqb3Zn?=
 =?utf-8?B?RlJjeWVHMFFqWnBuTFAxbm44RVUzNVRQa002NTkxMkNxbkxISzVPN1d4dHQ4?=
 =?utf-8?B?WVo4K2dkM0E4eUFDMXhWWE1jdy9TM3lVSTN3S1NIcjZJOEZHQlF6MXlJUDJE?=
 =?utf-8?B?Wm1wZlJkZjFRaVhHSzEvanUrT0JEMmRtc3lhYnd6TmRsZzFGUkRhQWFCVkxF?=
 =?utf-8?B?YU1DNURqRStxVkYyeVA3ZUtYeTBYZFRDWm1JR2RZbFMzTlR2WStEY0tnekxW?=
 =?utf-8?B?OHNzVWNJaVpvR1lZNFR5WVhIZkx3bFZQc2JqRzVHelhwZTI0dEUybVNDNmto?=
 =?utf-8?B?U1UrNlFxQ0phRUh4b2V4MUtQaXc0Z085Z3h1dVdRTmFBRjhwTERBTHo3Smxn?=
 =?utf-8?B?a2tza2dTblQ4dHBKbFFCRDZ2akdkOCtIb2NQOUdyZVdIK3p0aDlTL3huYmZU?=
 =?utf-8?B?Qit0WHlFYlNmZmovYnZHNUVndWNTVWRCUmYxaWVDaXlZUHp6dlJhM2hKaEZu?=
 =?utf-8?B?Tnl4N29NRTVMdmdsQXNGVkxjQUhZb3NjWG1FVUgzL2FwckszMmNyN0lxeXBF?=
 =?utf-8?B?RE1ZV3ZiS1B1bHhEeFVqU28rRDlmZFFuRm5KNkxlTEppK1FTMlVrc3FjTDhG?=
 =?utf-8?B?NjB2eFNGK3VWSFBpM1Uwc1FzbUhZQzlMYjNUL3l4RVk2WXVGd1lkVi9aZk9p?=
 =?utf-8?B?MEJ4eTR2Z2RmdUc3Z3lHdkNCM1RhcWMxbWlWcWdHMm4vazB2R3hNY2ZBYmtH?=
 =?utf-8?B?QWNQN3JabFBkczhnUFJBdXZ1cFg4cnZJaW80VWg4dmtqSzdadXRWc0hLVUg2?=
 =?utf-8?Q?rQyD5b4So5FwPRdf0Ttg8KWBvygqvjWgVE34Tz6SStun?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b616325-98dd-4f60-7204-08d9f58cf468
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 22:53:19.7316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QJT+9oCty4XRfGakkIlNC11DHEFGAsrTIbbqThJ0+MmkhAbtSTUG46efekbxHCcPNeLxqPkB9twAfrrwL9SPWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2816
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10265 signatures=677614
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202210136
X-Proofpoint-GUID: 43BR7JH7yVRpz11f1d5XHYLt-u7P_6HY
X-Proofpoint-ORIG-GUID: 43BR7JH7yVRpz11f1d5XHYLt-u7P_6HY
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The subject should be [PATCH net-next v3 0/4] but not [PATCH net-next v3 0/3].

Sorry for the mistake.

Dongli Zhang

On 2/20/22 9:34 PM, Dongli Zhang wrote:
> The commit c504e5c2f964 ("net: skb: introduce kfree_skb_reason()") has
> introduced the kfree_skb_reason() to help track the reason.
> 
> The tun and tap are commonly used as virtio-net/vhost-net backend. This is to
> use kfree_skb_reason() to trace the dropped skb for those two drivers. 
> 
> Changed since v1:
> - I have renamed many of the reasons since v1. I make them as generic as
>   possible so that they can be re-used by core networking and drivers.
> 
> Changed since v2:
> - declare drop_reason as type "enum skb_drop_reason"
> - handle the drop in skb_list_walk_safe() case for tap driver, and
>   kfree_skb_list_reason() is introduced
> 
> 
> The following reasons are introduced.
> 
> - SKB_DROP_REASON_SKB_CSUM
> 
> This is used whenever there is checksum error with sk_buff.
> 
> - SKB_DROP_REASON_SKB_COPY_DATA
> 
> The kernel may (zero) copy the data to or from sk_buff, e.g.,
> zerocopy_sg_from_iter(), skb_copy_datagram_from_iter() and
> skb_orphan_frags_rx(). This reason is for the copy related error.
> 
> - SKB_DROP_REASON_SKB_GSO_SEG
> 
> Any error reported when GSO processing the sk_buff. It is frequent to process
> sk_buff gso data and we introduce a new reason to handle that.
> 	
> - SKB_DROP_REASON_SKB_PULL
> - SKB_DROP_REASON_SKB_TRIM
> 
> It is frequent to pull to sk_buff data or trim the sk_buff data.
> 
> - SKB_DROP_REASON_DEV_HDR
> 
> Any driver may report error if there is any error in the metadata on the DMA
> ring buffer.
> 
> - SKB_DROP_REASON_DEV_READY
> 
> The device is not ready/online or initialized to receive data.
> 
> - SKB_DROP_REASON_DEV_FILTER
> 
> David Ahern suggested SKB_DROP_REASON_TAP_FILTER. I changed from 'TAP' to 'DEV'
> to make it more generic.
> 
> - SKB_DROP_REASON_FULL_RING
> 
> Suggested by Eric Dumazet.
> 
> - SKB_DROP_REASON_BPF_FILTER
> 
> Dropped by ebpf filter
> 
> 
> This is the output for TUN device.
> 
> # cat /sys/kernel/debug/tracing/trace_pipe
>           <idle>-0       [018] ..s1.  1478.130490: kfree_skb: skbaddr=00000000c4f21b8d protocol=0 location=00000000aff342c7 reason: NOT_SPECIFIED
>       vhost-9003-9020    [012] b..1.  1478.196264: kfree_skb: skbaddr=00000000b174fb9b protocol=2054 location=000000001cf38db0 reason: FULL_RING
>           arping-9639    [018] b..1.  1479.082993: kfree_skb: skbaddr=00000000c4f21b8d protocol=2054 location=000000001cf38db0 reason: FULL_RING
>           <idle>-0       [012] b.s3.  1479.110472: kfree_skb: skbaddr=00000000e0c3681f protocol=4 location=000000001cf38db0 reason: FULL_RING
>           arping-9639    [018] b..1.  1480.083086: kfree_skb: skbaddr=00000000c4f21b8d protocol=2054 location=000000001cf38db0 reason: FULL_RING
> 
> 
> This is the output for TAP device.
> 
> # cat /sys/kernel/debug/tracing/trace_pipe
>           <idle>-0       [014] ..s1.  1096.418621: kfree_skb: skbaddr=00000000f8f41946 protocol=0 location=00000000aff342c7 reason: NOT_SPECIFIED
>           arping-7006    [001] ..s1.  1096.843961: kfree_skb: skbaddr=000000002ec803a8 protocol=2054 location=000000009a57b32f reason: FULL_RING
>           arping-7006    [001] ..s1.  1097.844035: kfree_skb: skbaddr=000000002ec803a8 protocol=2054 location=000000009a57b32f reason: FULL_RING
>           arping-7006    [001] ..s1.  1098.844102: kfree_skb: skbaddr=00000000295eb0da protocol=2054 location=000000009a57b32f reason: FULL_RING
>           arping-7006    [001] ..s1.  1099.844160: kfree_skb: skbaddr=00000000295eb0da protocol=2054 location=000000009a57b32f reason: FULL_RING
>           arping-7006    [001] ..s1.  1100.844214: kfree_skb: skbaddr=00000000295eb0da protocol=2054 location=000000009a57b32f reason: FULL_RING
>           arping-7006    [001] ..s1.  1101.844230: kfree_skb: skbaddr=00000000295eb0da protocol=2054 location=000000009a57b32f reason: FULL_RING
> 
> 
>  drivers/net/tap.c          | 35 +++++++++++++++++++++++++----------
>  drivers/net/tun.c          | 38 ++++++++++++++++++++++++++++++--------
>  include/linux/skbuff.h     | 18 ++++++++++++++++++
>  include/trace/events/skb.h | 10 ++++++++++
>  net/core/skbuff.c          | 11 +++++++++--
>  5 files changed, 92 insertions(+), 20 deletions(-)
> 
> Please let me know if there is any suggestion on the definition of reasons.
> 
> Thank you very much!
> 
> Dongli Zhang
> 
>