Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 21 Feb 2022 16:05:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tong Zhang <ztong0001@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Colin Ian King <colin.i.king@googlemail.com>,
        Saurav Girepunje <saurav.girepunje@gmail.com>,
        Johan Hovold <johan@kernel.org>,
        =?iso-8859-1?Q?Cl=E1udio?= Maia <clrrm@isep.ipp.pt>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: cleanup proc fs entries upon exit
Message-ID: <20220221130548.GK3965@kadam>
References: <20220220231554.2510567-1-ztong0001@gmail.com>
 <20220221130006.GJ3965@kadam>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220221130006.GJ3965@kadam>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?teJgnLC4vdlyUK9dekborg4EAMcpa8tpYOiY2FYiG+mLEnRJFYZliaZF1ipK?=
 =?us-ascii?Q?K3KHVAJjvsdMhWqc6EHT0xwNjbRiQSCM+vldFbwJ9mqXK27JZLfpht2iVJ2I?=
 =?us-ascii?Q?k3/6WlmFZMuFqaR7EainUSuhSk07d3IxmlwUq+PsiphNt5A8mSs3a4NEem1a?=
 =?us-ascii?Q?/ewp67p0OkW7K0000BBuwgduUzpAniULixgMoElGC4vWP96+BMMhZ0twTyxO?=
 =?us-ascii?Q?i4jazrbp9tC2pZwlNFd6pdNYxJpega3VoFQxog3u7uk9LTTc0BOWFHwpqK65?=
 =?us-ascii?Q?t2VY6IZbRhZayb4GjU+4tqiHgqVJCR9DwHsaT3q2wmTtNKxBQ7UuznnLPruA?=
 =?us-ascii?Q?1ChlXA/MGdcZPMVf6IgglFLt3HKiS3h6ZfvF14nDkWMJHkIxnMaTUJYEKo9E?=
 =?us-ascii?Q?Y6Xe0D4z2oMvDx+aZnSsHrF0S4yTuMvDirRPNqXqCPWXDW+t3eX2f+nPdQO/?=
 =?us-ascii?Q?Oh4extP8MNjrrJdxBFwYfRQpwCNgxq58iMMJNuEhxwvTvFwDyD5V64Tlhy7Z?=
 =?us-ascii?Q?5yloymYlM7JKgALPqreYZVyT+c1MxoTWbHNI8YT6rk6/fLogDAsrmSu3C5xB?=
 =?us-ascii?Q?MGyoubNriGLuZ3De3qdImqWaQbNpJ52+HFBxHo774DCsihHL1uAcno5PyZMD?=
 =?us-ascii?Q?VqIJvddpM1/AdQPIbpROTDAMW+tAHe01Spv0891hRyy/JENM3AWwH1/CL33J?=
 =?us-ascii?Q?Sq1N/Zaj1qHTZ82kJ8d3R7uoIAFKKT9c8OW1jg7Ez7EUKQlOs4599XV2CDS4?=
 =?us-ascii?Q?4+sczDDK5vOrgoZiIVoMxE+yIZW9lBxA2EoBQIotgpGBR/e1qSWt1aKYEm+g?=
 =?us-ascii?Q?qZhnk95eJw01oUcP0jFQONwzKxml/ppCEtabOLmVHioHrCq2luYvjAGgIAAC?=
 =?us-ascii?Q?Q5dUTHfAFZ9yInyc432J07WA929uSbWTlSoBozhZSEdwmNBBRyb0CESOrz1A?=
 =?us-ascii?Q?6uMeEKtmOeYIPNDsX1s704v4oBOxToF4KfuRbgOz5g7JQqSvuRImQvC67DCs?=
 =?us-ascii?Q?8/sJ80wx5YPMkvBD44TXT6oeBLdEQVAbh3HYvXTSyDMVlGXuVLcP+U07hovN?=
 =?us-ascii?Q?Xlpuma+b6VN7RerYb7Lp6UHE0wDFR+Va0AA7bRiUzpMQqpZGlBeE8TNFMIv4?=
 =?us-ascii?Q?q6kCwxYcfIy/aYWYnOcYZqGtlLjIRZMfH4noK4DywqluJRJEF251cmRbKc/P?=
 =?us-ascii?Q?Tpg9lQ76UBWuwITJnhW0VSmeNbNfehpYrhtar3mXuic+xdGuE8NI0bhJrtWZ?=
 =?us-ascii?Q?PsL6LCHpEqWwtvyVCOQD3QFm4uQ2XyIiMHX3nbBU81BGQB8v+7JUQdTLhNC5?=
 =?us-ascii?Q?LOn3jqvgBHdK71Ii2yE7y8os26JMIaEcqP7rJQmzwF5V6ElXlXXVawLF2uO9?=
 =?us-ascii?Q?TBGxF2abrYphEOdA7tCwO7clD2miAedeuKuU5F8rGUnw4/k2kgcpP181PDKm?=
 =?us-ascii?Q?YNeh/LA9ld8OBozMm3fLENcRn/+RLvNSGqThuuNMlJTxFqYxMv5zHTDJuN0+?=
 =?us-ascii?Q?qiBiUn+CucvMsIw1rQlIfhkfMpzWP6V1xHhrpp+0E2b2G53/EjspV5S/T67y?=
 =?us-ascii?Q?+lRO5V0J3FohTo3W2QmYwzsEs80NmAb/W9EN35Tg5FZmUE3XuxCzpFiUjn8p?=
 =?us-ascii?Q?thhYfnYjeQMUd43m37iKyAPLzvRabKcO8iQq+Jg7fft1PZtdIi5jgjUj/md8?=
 =?us-ascii?Q?eBQ2kg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ada2be97-f593-46f4-923d-08d9f53aee57
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 13:06:10.9791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oG2mBKLdbSCa5zh+5GYWdtkXfMoQRRhaiZWzAgEmhDAmQNfGLEh/XpwAO1m2QntPUX4Ab+aqHLaumIxJp5caxbNX8xOMlbWYlf9/HWxDnF0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5367
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10264 signatures=677614
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 spamscore=0 mlxlogscore=950 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202210078
X-Proofpoint-GUID: Q_7vto0Mhk4wW5wZrLgz_hE9lhk3u48v
X-Proofpoint-ORIG-GUID: Q_7vto0Mhk4wW5wZrLgz_hE9lhk3u48v
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 21, 2022 at 04:00:06PM +0300, Dan Carpenter wrote:
> On Sun, Feb 20, 2022 at 03:15:53PM -0800, Tong Zhang wrote:
> > proc fs entries need to be removed when module is removed, otherwise
> > when we try to insert the module again, kernel will complain
> > 
> > [  493.068012] proc_dir_entry 'net/ieee80211' already registered
> > [  493.271973]  proc_mkdir+0x18/0x20
> > [  493.272136]  ieee80211_debug_init+0x28/0xde8 [r8192u_usb]
> > [  493.272404]  rtl8192_usb_module_init+0x10/0x161 [r8192u_usb]
> > 
> > [   13.910616] proc_dir_entry 'net/rtl819xU' already registered
> > [   13.918931]  proc_mkdir+0x18/0x20
> > [   13.919098]  rtl8192_usb_module_init+0x142/0x16d [r8192u_usb]
> > 
> > Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> > ---
> 
> This is a partial fix but there is a lot wrong with both the init() and
> exit() function.  It's not hard to just fix everything and it saves
> time.
> 
> Here is how to write Free the Last thing style error handling for init()
> and when you finish writing the error handling code then the exit()
> function is just a matter of cut and paste.
> 
> The rules are: 1) Free the last successful allocation.  2) Every
> function must have a matching release function. 3) Every function must
> clean up after itself.  No partial allocations.  4) Name your labels
> with descriptive names to say what the goto does.

I meant to add:

5)  Free things in reverse order from how they were allocated.

regards,
dan carpenter