Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp4441353pxb; Mon, 21 Feb 2022 21:43:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJycz6iTNjSN+bqSaezHEvMDZlNYQybqCiCo9FzlDqWTlJBHEq+Ou1jkMDtGDfHhX93ovzXy X-Received: by 2002:a17:902:e84f:b0:14d:8437:5130 with SMTP id t15-20020a170902e84f00b0014d84375130mr22043365plg.60.1645508617277; Mon, 21 Feb 2022 21:43:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645508617; cv=none; d=google.com; s=arc-20160816; b=WOqneEdZbD4jNs2hB5qsFKlORDLUaiE2ZX9rPZZw+zw9ikCkVfHtBnKqzhtg+/TC/U oCq7+Q6RqIb0qDtHs9ZbLlmhYzM6gSAsFSr7LDdDeLycmsCYroI9Z39M4gn2hZDtIiXR HmcchoPGPTHYSHHKHakcJkcgaeN7xiTHyObs/9uFEIPStmgyT9dlFKoHyWKnhJACrUDc J/VSiadKz8Vzxlm8JxwAiv498thY16W2Lid1gm+rUzqgtpGWjbUAbCElL5w8CWWp21Rm qizBx0UKvF4B7ko3Qbjz+i6piCXid/vSRJ9fsaWOIs+/1MN4p911MRUKR0J5tQnRVMcn MO5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=FQ/Oyj3CQfmniV07x3o++/fZN+iiONMTqxiWxhJRUlY=; b=FbSpqw2DgciQkCbKajrUcUyjGhvwNy3fivOMLS5HK8Fer9d4F2FWynHOzNQnB2i3ao 0cAinJoEZVrrWpbrRZ2RoJDZgvPOVKNm/fg61fxLxP27DwoIgxoRJ67WPjtBCphKIRfV aktXJDZlXF74UVCG42H9FpMlD1UJ0u1KvPTUwGyFfQPCuLx801IP+IltUMJVrZ8z8fGb oY4bxWjWI0aZubyaI9BkOJssd7n5QbYbA4h/58AejzewII+KbTE/Oko2SX9DtN/qvvNV rsp/cx3mOgattn44VuGtUKAs59FbDnddw/OkaHYnLOlLt010GMCWE7GjwjXxYdf+TMXJ 2YkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u18si19205715pgo.828.2022.02.21.21.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 21:43:37 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 42BB0C623F; Mon, 21 Feb 2022 21:09:22 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231372AbiBUSFP (ORCPT + 99 others); Mon, 21 Feb 2022 13:05:15 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232463AbiBUSEY (ORCPT ); Mon, 21 Feb 2022 13:04:24 -0500 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71D071AD90; Mon, 21 Feb 2022 09:56:03 -0800 (PST) Received: by mail-wr1-f53.google.com with SMTP id d27so28483240wrb.5; Mon, 21 Feb 2022 09:56:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FQ/Oyj3CQfmniV07x3o++/fZN+iiONMTqxiWxhJRUlY=; b=IaeQ3I2f6ayb3wpZCA4cKOoVf/SepEdNbhwAXPV23UjaibSB9oUR47V4Lekl+g3G0S LaOiWiQLmD/hMKwb19+0IENZXqkkeBMUFmfN66PE7vkpwak5ryQEXgzuyym/b5u/47O0 AkXEx3HY4KgDv0inu88D68NNoj2ag9vRwKG+PsIjSgLjPSexGxAmmYNdxoWqU4J/Zgv1 Q16XWGyeI42WIxFOt2fRBjQSYti3ZqZenvhIW/fDE+arwIBQePPAAv/1nrMST7L+f+Yx h1eRjhjXocerZqjz05hOE5ZNnRHAt96BT+Omv9no/rrfl/Q/MWV26+mLMTx3cSgNV2YG 1J+Q== X-Gm-Message-State: AOAM530ufGRl7J9qPKqmj7EUBPJu0wfgfd8DQhizr03IVaf7kivWPaWI BqmDKOwPPpsOz2vK/yCZNoE= X-Received: by 2002:a5d:4d0d:0:b0:1e7:a9e7:ad31 with SMTP id z13-20020a5d4d0d000000b001e7a9e7ad31mr16266827wrt.281.1645466161856; Mon, 21 Feb 2022 09:56:01 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id d2sm22558483wro.49.2022.02.21.09.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 09:56:01 -0800 (PST) Date: Mon, 21 Feb 2022 17:56:00 +0000 From: Wei Liu To: "Michael Kelley (LINUX)" Cc: Boqun Feng , Lorenzo Pieralisi , Wei Liu , Sunil Muthuswamy , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Dexuan Cui , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , "linux-hyperv@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH v2] PCI: hv: Avoid the retarget interrupt hypercall in irq_unmask() on ARM64 Message-ID: <20220221175600.gxbphsnbytgytcpz@liuwe-devbox-debian-v2> References: <20220217034525.1687678-1-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 17, 2022 at 04:31:06PM +0000, Michael Kelley (LINUX) wrote: > From: Boqun Feng Sent: Wednesday, February 16, 2022 7:45 PM > > > > On ARM64 Hyper-V guests, SPIs are used for the interrupts of virtual PCI > > devices, and SPIs can be managed directly via GICD registers. Therefore > > the retarget interrupt hypercall is not needed on ARM64. > > > > An arch-specific interface hv_arch_irq_unmask() is introduced to handle > > the architecture level differences on this. For x86, the behavior > > remains unchanged, while for ARM64 no hypercall is invoked when > > unmasking an irq for virtual PCI devices. > > > > Signed-off-by: Boqun Feng > > --- > > v1 -> v2: > > > > * Introduce arch-specific interface hv_arch_irq_unmask() as > > suggested by Bjorn > > > > drivers/pci/controller/pci-hyperv.c | 233 +++++++++++++++------------- > > 1 file changed, 122 insertions(+), 111 deletions(-) > > Reviewed-by: Michael Kelley I expect this to go through the PCI tree. Let me know if I should pick this up. Thanks, Wei.