Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <3cd0fd16-2d59-d3ac-7a73-4209311b2b97@amd.com>
Date:   Mon, 21 Feb 2022 09:46:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Cc:     brijesh.singh@amd.com, sathyanarayanan.kuppuswamy@linux.intel.com,
        aarcange@redhat.com, ak@linux.intel.com, dan.j.williams@intel.com,
        david@redhat.com, hpa@zytor.com, jgross@suse.com,
        jmattson@google.com, joro@8bytes.org, jpoimboe@redhat.com,
        knsathya@kernel.org, pbonzini@redhat.com, sdeep@vmware.com,
        seanjc@google.com, tony.luck@intel.com, vkuznets@redhat.com,
        wanpengli@tencent.com, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCHv3 27/32] x86/mm/cpa: Generailize
 __set_memory_enc_pgtable()
Content-Language: en-US
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@intel.com, luto@kernel.org, peterz@infradead.org
References: <20220218161718.67148-1-kirill.shutemov@linux.intel.com>
 <20220218161718.67148-28-kirill.shutemov@linux.intel.com>
From:   Brijesh Singh <brijesh.singh@amd.com>
In-Reply-To: <20220218161718.67148-28-kirill.shutemov@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVpjcjBwampQOWcxMVhCWjJEcnZLWitna2g5djBNQ1V1WmNEWXFrUzlLMm56?=
 =?utf-8?B?aU10RTV6OUpjV0d4eW5naDJOb2l2ZUptYmt0UW9FUmtmT3RoOUNUNGczNTJU?=
 =?utf-8?B?ekxlRzhHOHM1QkdyRlh5bWM1T2o2dnM0dDJyazFqMFBzb2ZpMnhpZ2dyWnBa?=
 =?utf-8?B?aG9HUmRQSzJzcmtlNFo0bis0aThnSWxKZGtHZ1JzaW9yVFh6dy9Tbmp6bktF?=
 =?utf-8?B?Vk96ckNmTkdxTy9nZkRYcUxSUUFEZGJLMDdVdk9Zc2xYc2g1MGFqbElhWWtX?=
 =?utf-8?B?c0ZVeHZqUTJPcE0vR1lzRGc3UVdqNU1aZFJUMzNuQXJxalZxRUpXZjR6bmJ6?=
 =?utf-8?B?TVJuZ3Z4aityRUU0WVExd2pRaUN0NXk1WFM0UmhGaWZaUHptTE0vdGJFa3ZP?=
 =?utf-8?B?ODNRNk9BSFNRc3BmVGRLdjRza2ZoVVNQMnVacWY2VzdNNG1JWWxBVDd1VFln?=
 =?utf-8?B?TW9EMm1wdVorcFdvRlZtYk4rVHhxYWFYWXFWbmRrSVZKSElNT05rNWx4SU03?=
 =?utf-8?B?TXViRXA5RElqeXNlVVcxNmJpWWxRV1NvampsT3hNTGpDUVlCbHd6YkVnbGdv?=
 =?utf-8?B?aXJCYjJqQmF2TS9uU01EZHVEMHhRNE5zSXc4bkwraHRoOXJhRzlmcVRXazQ0?=
 =?utf-8?B?OXd3dVBuQmErOWlCTThnQ1QzMWVNNzVpekl6TXZ6clRtdjZPcXpvcXdNcytB?=
 =?utf-8?B?TEp5Ty9IemRoMWRhVDNybzhWTDBrb3dYVnNXSTNVU2tNNjZMbFRlRWRZN2xE?=
 =?utf-8?B?WjFLUmxybVBVbjdiclhzeXZsUFFyamp4SFc1WVNjV0ZSQWFKMTZGeUFnTDV4?=
 =?utf-8?B?OSsrMEVSazI1VnUvc3ViaU5nSkkxL2RRV3o5NlN1c044V21oTFdHUDlmaXhD?=
 =?utf-8?B?ZnNLZDhSMmdiMmRmaUJNQzk4WHUyR0FVTEZTbmN0NW03U0NySHB1VlgvN3lP?=
 =?utf-8?B?U2JzUCthUlREdy9RbkRZVFNmbnNPQVBHenMxcHhwWjVJa2Myd2p1T29BQ3E3?=
 =?utf-8?B?NzlHWFkrYmk5YnBuVUhLNEpJSUxkUW1IcDM5Q25GVFQ3WHhRaHRLeVVPZkda?=
 =?utf-8?B?RlpnR0V1VjA3UWV5VGZHTS8wZ1ZibHpVN1pGVHQ0c0xtT2xhZmNVTVRtdlRy?=
 =?utf-8?B?TEtLUCtjZTNWZ2w4QnRmbXpuWGErRU1nS1hHN3NQaCttL2YxTURvZmdzdmJs?=
 =?utf-8?B?djdUOU51TW5pMUhzZDc4VldxVnRFUEdzazlrc05qTHFIQmhjelZHQTdram9j?=
 =?utf-8?B?bWhrRlRVbzN2eWZnbzNJSGVMUFk5cFN0TkdTanNKdkN3cDdhNXNwVW85TFpt?=
 =?utf-8?B?MlVjaW11bFAvVkQ4ZHFLNGpFZnFCUk9XU05DcTIzN09XaVI5MGROeHJhanZq?=
 =?utf-8?B?eUxXejNlWEY0YncyelZCbGo0cEFzRmUxaHRVTXBlSU9xVDR2clQwRVh6TFpO?=
 =?utf-8?B?bW1USXZ1UFAzdVRMYkQwNDVWRHFLN0hvSVFxaE0zak5COCtRMXFPalpoWlpY?=
 =?utf-8?B?Y1V5LzlvbFMrQUY1SGVmblVFVTJwcHZnZDRjRVlQME50V2Z1U0pVeGZoK0x0?=
 =?utf-8?B?Z1MzdzdMQkFTdlBzV3ZvZG1wNy9FUUhCU3B6STdPMStZM2tKbnNRd3puSnNv?=
 =?utf-8?B?MjlCRk9UZnY3V2xqbytrMGlHNTFJSkFjdTRmOEl3Y3g4aFhydkFQQnEzVVl1?=
 =?utf-8?B?UWJjeFlyaVdPM3F5ZngzUldFL3p4cWNvVWU2VlpEODJQaVRQV25GT3lKSm85?=
 =?utf-8?B?dnUzenNJSjA4N2FJMmhOQTJIYVRMcUlRWW5ybzlabXgyeGdyWm9qR01NQzFI?=
 =?utf-8?B?cnQ5NmhHVUVpOEM4N05zazgzb2F1d2tzUnMvY3I0aENCdndvNVdmT3FxNGFU?=
 =?utf-8?B?WDFJUktEMFhPcktidC9QOEFzbW9EK0lsNU0yZVhYemt6NGVLeVZFRUpva0hp?=
 =?utf-8?B?Q1paM3ZWMWNNTDV0RGE4UURNUHFwZVRBUmYvcGVPU3FxNzVsMkJsek1teWF1?=
 =?utf-8?B?YW1xZ2NmWUd3VHgyUDV3NmtiZ0ZEQlFFVUcrVFpXbVYrdHR5Z2UyUHVnVHQr?=
 =?utf-8?B?UmM3dGZVR3luaWcxeVF4eHNxd01IY0NrQ08va3k1Q294bVp0bjFUS0tXR25Q?=
 =?utf-8?B?KzFUU0JlY1U1NFREdkU4WldaazlseUkwSUNkTjZjM3YrNUpwRlN2N1VKelFX?=
 =?utf-8?Q?lToeoUCyeY6Cpw6U4urdVpA=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd97a944-b9f1-443a-6201-08d9f5515030
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 15:46:23.8483
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Q8T7zvkFkQEm0hSW1sXRg6yN2F8YeogxcwF3TYy27yt9hmRCBKyg8780OmWRokkNmCaFrSLSafmwOGyIFSGvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4631
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/18/22 10:17, Kirill A. Shutemov wrote:
...
>   
> -	/*
> -	 * Before changing the encryption attribute, we need to flush caches.
> -	 */
> -	cpa_flush(&cpa, !this_cpu_has(X86_FEATURE_SME_COHERENT));
> +	/* Flush caches as needed before changing the encryption attribute. */
> +	if (x86_platform.cc->enc_tlb_flush_required(enc))
> +		cpa_flush(&cpa, x86_platform.cc->enc_cache_flush_required());
>   
>   	ret = __change_page_attr_set_clr(&cpa, 1);
>   
> @@ -2027,7 +2026,8 @@ static int __set_memory_enc_pgtable(unsigned long addr, int numpages, bool enc)
>   	 * Notify hypervisor that a given memory range is mapped encrypted
>   	 * or decrypted.
>   	 */
> -	notify_range_enc_status_changed(addr, numpages, enc);
> +	if (!ret)
> +		ret = x86_platform.cc->enc_status_changed(addr, numpages, enc);
>   

Boris has given similar comment on SNP series. This area of code have a 
very similar requirement. Boris proposed it here [1] and I followed up 
[2] with SNP specific comment. It will be good to get your feedback and 
do a generic implementation outside of the SNP/TDX series.

[1] https://lore.kernel.org/linux-mm/Ygz88uacbwuTTNat@zn.tnic/
[2] 
https://lore.kernel.org/linux-mm/20220216160457.1748381-1-brijesh.singh@amd.com/T/

thanks