Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp4441633pxb; Mon, 21 Feb 2022 21:44:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyVFYtQFLKl3urut+TETN+5EGsnmmfTi3y9kXQXbr92upTaKXFoNILHQYvdpL+7Rwgr196E X-Received: by 2002:a63:3111:0:b0:373:a1fa:8998 with SMTP id x17-20020a633111000000b00373a1fa8998mr18441374pgx.415.1645508652791; Mon, 21 Feb 2022 21:44:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645508652; cv=none; d=google.com; s=arc-20160816; b=y6dC47Jl6J2sjAS+lNymRSs7w0gVbJJ65Trj4goMNONJBLNWOjY5G0qlUjUIKfxavY TdDLW0FnwYgXAIPE3tEsPLBHzQDnk2yDVOOH7SvzcJR3Wuklk0qsbYv0xj2EKriqTg70 VamfHyO+J04xcuJImNd1c+h1niLNNwnajei0ie0q1bIk1yqI3nU7+Qbajw7bqaZN9u4L xJSOyDzSx1XaLyNM156Ozh6Ytp1zSs1cPBlbpxToJoDvMiT2tx3HqTyjbeLbMQaMq8jj /3JVaU98Xfvd1+Y0FcRlllJLJMKAVP1Q6Fm47xDmV/MFlZHOCRdJOEdDu0nYUH0uYNF7 udlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:dkim-signature; bh=WCBQPRAXNKEOqzap7VzxRpf2OcOGWxCXupmF+QqH0S4=; b=O6dlS4lWXp94Rl0WhHfaNfOkraSWuFMcQAdDlr4BKUxuWTFaowCf4eWDH186gVi6Qc butc67WNLxLFTsrHsKij4giD2llgOh2GnGpsk7hRHBTrb799oQPX7cUy2cPy7P2w3mBJ WRS5c5kpTNaUDOD6IR2RGE4qax70jfrTWEPK7yexREBUY2Og3WRy8EnHnfZ8yYvIXpWh OWZVi5WvAxlz7H+BlaTEUpTVyZogYImM+wQwuOelzImwZ6+9pUbkbpb4fFvrx3IDcomq 05nLZTetHiBMPhtz9BCr8yvgkVegg0R3GESWNl1hQ3vNgHJkAHouFnutoJPf8TurBuhm vYFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=O1R9sTeh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 17si10307089pfo.197.2022.02.21.21.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 21:44:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=O1R9sTeh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C5D23C8F8F; Mon, 21 Feb 2022 21:09:46 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233100AbiBUTmL (ORCPT + 99 others); Mon, 21 Feb 2022 14:42:11 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233129AbiBUTlv (ORCPT ); Mon, 21 Feb 2022 14:41:51 -0500 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 722B322B02 for ; Mon, 21 Feb 2022 11:41:25 -0800 (PST) Received: by mail-oi1-x230.google.com with SMTP id s5so12007258oic.10 for ; Mon, 21 Feb 2022 11:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WCBQPRAXNKEOqzap7VzxRpf2OcOGWxCXupmF+QqH0S4=; b=O1R9sTehWUO2FhfEhPLXFpuRRGqs/4WmmT9xIlNb2dZMdG7/haGYG3VL2aLpjbZsVZ scnGpQJ9Fk7D+AWCZ+w6mqepFjaGSHRSRXJHO5+atd3kI9ipJdSTnC5aEHjC7+XVV/WM qQKeVkCM66N+2oi9vJoEw1aBldeGQ1z/p+JaGHGxuvBqhdhoWpRpvMbJaTMHhOAruoFF tvnW0MvTycN2WYoeqtj3I09TAOU489NJ1JmMqmSXEyWIg4rVCxaV0OqtwsVKx76q9vQv KcHRPMDuPaCiz4Gjc0DT+mmxtG8UxlpFJlHcJrl5ZVDTp5R75gRZ4+aN5cltMIUvY0mK qLuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WCBQPRAXNKEOqzap7VzxRpf2OcOGWxCXupmF+QqH0S4=; b=GvKa+8fi7rIQLyUL3Hv1bQkbOEQiJfwn/08toXIA0plwbRzHT6gwrMtxHB4Rm2MDIh gwAhL8nBYbxZ9jhhncwNOLMWRCRZrGfmqbKJA3FZwBPEDrVz+6thRaguWRpwqKbzTPFF L+VwZxqpO+onzTaBYian70eT9vVsXg0Qzkl7Q2vTPhS2nR5GHZ/KtyDuWb5/grNHmLgZ TZHz6iQxxwNyDy/o7Q5Wps8CWWcm/sU3Mhg0RS2iD/UMUQnar/a8IcGKCwAis7IxozBz ujxgvb9l9NuIPaVjL/iHfgq5jKB8lzUVhd0ieiNrVqi5hiTGcH6Ra39BiDXB2/zCtvYP LDGQ== X-Gm-Message-State: AOAM531CKr1O9Oqvs9jiiYo4L+JBv1VpmlqedwYzXdIUccU/UIo6Q8c0 9rJu4DXTwVtlAi40bQWGcrM1csF6nus= X-Received: by 2002:a05:6808:30a7:b0:2d5:2957:f98e with SMTP id bl39-20020a05680830a700b002d52957f98emr283339oib.183.1645472484838; Mon, 21 Feb 2022 11:41:24 -0800 (PST) Received: from [192.168.1.103] (cpe-24-31-246-181.kc.res.rr.com. [24.31.246.181]) by smtp.gmail.com with ESMTPSA id b16sm4801662oti.69.2022.02.21.11.41.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 11:41:23 -0800 (PST) Sender: Larry Finger Message-ID: <636080dd-ab8d-a572-0f81-5f72b14ec1e4@lwfinger.net> Date: Mon, 21 Feb 2022 13:41:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/3] staging: r8188eu: remove 5 GHz channels from ch_freq_map Content-Language: en-US To: Greg KH , Michael Straube Cc: phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220220154847.7521-1-straube.linux@gmail.com> <20220220154847.7521-2-straube.linux@gmail.com> From: Larry Finger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/21/22 11:13, Greg KH wrote: > On Sun, Feb 20, 2022 at 04:48:45PM +0100, Michael Straube wrote: >> This driver is for chips that operate only in the 2.4 GHz band. > > How do we know that? > > thanks, Realtek (https://www.realtek.com/en/products/communications-network-ics/item/rtl8188eus) states the following: "The Realtek RTL8188EUS is an 802.11bgn 2.4G single-chip that integrates Wireless LAN (WLAN) and a network USB interface (USB 1.0/1.1/2.0 compatible) controller. It combines a WLAN MAC, a 1T1R capable WLAN baseband, and WLAN RF in a single chip. The RTL8188EUS provides a complete solution for high-throughput performance and low power consumption integrated wireless LAN devices." The reason there are 5G snippets in the driver is because Realtek uses the base code to generate drivers for other chip families such as RTL8192DU that have radios for both 2.4 and 5G bands. The RTL81288EU and variants have only a single radio. Larry