Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp4442364pxb; Mon, 21 Feb 2022 21:45:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBslHxNU6oameBcWkD74W6PmAUoLNnPyKXU+hmuYknSMgcvVPoZQdPWb7xrLRD7VXmUw4H X-Received: by 2002:a05:6a00:190d:b0:4e9:57a9:af13 with SMTP id y13-20020a056a00190d00b004e957a9af13mr19972153pfi.43.1645508746057; Mon, 21 Feb 2022 21:45:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645508746; cv=none; d=google.com; s=arc-20160816; b=ORz7LsD8X6TbuIBz418Fyspf9WEIMMn3Fkf+TQ4ZCrCBVPvIgn0JrHZwqcOnYL9StO tzKA/h4uXO19a7wX20unGW7q1J4bRQ8M720ZB/6ezQ39u2B603ckxScllK9RHLoPZ46M vXg/q1sF82slfJ+r46vaz+1zgte6AHfAhQvfYiRpqFsEWgQofjWfTVhTKq9eukASN39Y PY1e2SE/6rEOIldAlXpZTK3A2m/uWdLI5QLfAw3/HlcQS+EjW/i7vorUHVKwFDoWG3R5 KotzWTb00DKE4HwBJ92lq3PKRUIJCVWHp1XqrExrrcP601kh+j1AC4Oqm2SrXu92pvVJ u0hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=/s0JV8j+1YupYO8dBCzqwrXqZxRIYGMSmNoYAmfd/cE=; b=vqZp/Bi7hK8rtCVwn8gtk2pVTcEQzyNuizEXVMClMghtZirnFWxan47Fc68fUrtgYY cGh5qdKMy8MaJ+F116EwmvFiPrswQi6wgbGMZltVVTNHIZV59OSBS1gwLpMN1tfdGTuC XuBVVXAUlIiGnFc4AkWIRuQmNVJGQYkfnw9ADFjv9nsyyjK6fR7cSC+Atz+Va+8hBcVz WcGBJwbnPAk6IeWu6QqgcFMDpBMBPBuVByWNEji86vNcfA78ieLi4eMjkPGq54RqdEQk MZCF3dNBQOVA0ggnGRwKsuJj5agWGh24V4LvDKovc7RSPg1IkBs/jx65Mb/l6pJKzL2K QqRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XPuGCmcb; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id o29si2082182pgm.46.2022.02.21.21.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 21:45:46 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XPuGCmcb; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 42D72CC51E; Mon, 21 Feb 2022 21:10:52 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236470AbiBUX0T (ORCPT + 99 others); Mon, 21 Feb 2022 18:26:19 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231261AbiBUX0T (ORCPT ); Mon, 21 Feb 2022 18:26:19 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4908124BFE; Mon, 21 Feb 2022 15:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645485955; x=1677021955; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TXFKi+FO7tpuHFgos+IuWF/gtek8UCE3SDD93kgS1+Q=; b=XPuGCmcbyTix7vx9Bc7n6Tl0R09RuOJS1o7yzCk+DXrwtTw0OxDAJNC2 azwvX8BkvrnTx6LT/QVeZyv1Daw9OUlB7pQfyrh85XkVVI0+dOdHsyIvd OxaA20lwLD96UZYB5K0L7XA1fmQTg5++Y1xYlytkrCxb/y3qdvmx0329l idDoIJt2j0fH1dvUeazTppE3WACdmxcMFtZVb+bpAXu5s5Cq7afkmA5Fi ywE97ezVzsG1b9TmA+unWngIHpN8SuGSVdRzo0lhUMXcXrF5rhtore1yg GPU/9PCpHMIXZMn8BUJLb8SPVTaj5miekJ5KmhkWbMj4oM+A1IOwtbLSt g==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="338011867" X-IronPort-AV: E=Sophos;i="5.88,386,1635231600"; d="scan'208";a="338011867" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2022 15:25:55 -0800 X-IronPort-AV: E=Sophos;i="5.88,386,1635231600"; d="scan'208";a="706396966" Received: from lab-ah.igk.intel.com ([10.91.215.196]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2022 15:25:51 -0800 From: Andrzej Hajda To: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev Cc: Andrzej Hajda , Jani Nikula , Daniel Vetter , Lucas De Marchi , Chris Wilson , Eric Dumazet , Dmitry Vyukov , Jakub Kicinski Subject: [PATCH v3 00/11] drm/i915: use ref_tracker library for tracking wakerefs Date: Tue, 22 Feb 2022 00:25:31 +0100 Message-Id: <20220221232542.1481315-1-andrzej.hajda@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Appearance of ref_tracker library allows to drop custom solution for wakeref tracking used in i915 and reuse the library. For this few adjustements has been made to ref_tracker, details in patches. I hope changes are OK for original author. The patchset has been rebased on top of drm-tip to allow test changes by CI. Patches marked "[DO NOT MERGE]" are cherry-picked from linux-next (they are not yet in drm-tip), to allow build and run CI on the patchset (it works only on drm-tip tree). Added CC to netdev as the only user of the library atm. v2: - replaced list_sort with ref_tracker_dir_stats, to avoid potentially extensive sorting, if number of reports is expected to be big enough (???) we can replace linear search in ref_tracker_dir_stats.stacks with binary heap (min_heap), - refactored gfp flags, - fixed i915 handling of no-tracking flag. v3: - fixed mess with duplicated mails Regards Andrzej Andrzej Hajda (6): lib/ref_tracker: add unlocked leak print helper lib/ref_tracker: __ref_tracker_dir_print improve printing lib/ref_tracker: add printing to memory buffer lib/ref_tracker: remove warnings in case of allocation failure drm/i915: Correct type of wakeref variable drm/i915: replace Intel internal tracker with kernel core ref_tracker Chris Wilson (2): drm/i915: Separate wakeref tracking drm/i915: Track leaked gt->wakerefs Eric Dumazet (3): [DO NOT MERGE] ref_tracker: implement use-after-free detection [DO NOT MERGE] ref_tracker: add a count of untracked references [DO NOT MERGE] ref_tracker: remove filter_irq_stacks() call drivers/gpu/drm/i915/Kconfig.debug | 19 ++ drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_display_power.c | 2 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 +- .../i915/gem/selftests/i915_gem_coherency.c | 10 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 14 +- drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 13 +- .../gpu/drm/i915/gt/intel_breadcrumbs_types.h | 3 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 6 +- drivers/gpu/drm/i915/gt/intel_engine_types.h | 2 + .../drm/i915/gt/intel_execlists_submission.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 12 +- drivers/gpu/drm/i915/gt/intel_gt_pm.h | 36 ++- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 +- drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 20 +- drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 5 +- drivers/gpu/drm/i915/gt/selftest_reset.c | 10 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 17 +- drivers/gpu/drm/i915/gt/selftest_slpc.c | 10 +- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 +- drivers/gpu/drm/i915/i915_pmu.c | 16 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 239 ++---------------- drivers/gpu/drm/i915/intel_runtime_pm.h | 10 +- drivers/gpu/drm/i915/intel_wakeref.c | 10 +- drivers/gpu/drm/i915/intel_wakeref.h | 112 +++++++- include/linux/ref_tracker.h | 35 ++- lib/ref_tracker.c | 198 ++++++++++++--- 27 files changed, 480 insertions(+), 344 deletions(-) -- 2.25.1