Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 21 Feb 2022 16:16:44 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     "Bayduraev, Alexey V" <alexey.v.bayduraev@linux.intel.com>,
        Jiri Olsa <olsajiri@gmail.com>
CC:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Antonov <alexander.antonov@linux.intel.com>,
        Alexei Budankov <abudankov@huawei.com>
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_core=5D_perf_data=3A_Adding_erro?= =?US-ASCII?Q?r_message_if_perf=5Fdata=5F=5Fcreate=5Fdir_fails?=
User-Agent: K-9 Mail for Android
In-Reply-To: <f5a97d51-fa64-0e48-d150-e8a983f88a32@linux.intel.com>
References: <20220218152341.5197-1-alexey.v.bayduraev@linux.intel.com> <YhLEHCttvXmRu78G@krava> <60253e6d-e8c5-550e-73b5-40720114c2a4@linux.intel.com> <YhPY3B3QumIZWukQ@krava> <f5a97d51-fa64-0e48-d150-e8a983f88a32@linux.intel.com>
Message-ID: <C5DD162C-1991-40F1-93ED-62924E7916A9@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On February 21, 2022 3:45:55 PM GMT-03:00, "Bayduraev, Alexey V" <alexey=
=2Ev=2Ebayduraev@linux=2Eintel=2Ecom> wrote:
>
>On 21=2E02=2E2022 21:24, Jiri Olsa wrote:
>> On Mon, Feb 21, 2022 at 04:24:28PM +0300, Bayduraev, Alexey V wrote:
>>> On 21=2E02=2E2022 1:43, Jiri Olsa wrote:
>>>> On Fri, Feb 18, 2022 at 06:23:40PM +0300, Alexey Bayduraev wrote:
>>>>> There is no notification about data directory creation failure=2E Ad=
d it=2E
>>>>>
>>>>> Signed-off-by: Alexey Bayduraev <alexey=2Ev=2Ebayduraev@linux=2Einte=
l=2Ecom>
>>>>> ---
>>>>>  tools/perf/builtin-record=2Ec | 4 +++-
>>>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/tools/perf/builtin-record=2Ec b/tools/perf/builtin-reco=
rd=2Ec
>>>>> index 0bc6529814b2=2E=2E0306d5911de2 100644
>>>>> --- a/tools/perf/builtin-record=2Ec
>>>>> +++ b/tools/perf/builtin-record=2Ec
>>>>> @@ -1186,8 +1186,10 @@ static int record__mmap_evlist(struct record =
*rec,
>>>>> =20
>>>>>  	if (record__threads_enabled(rec)) {
>>>>>  		ret =3D perf_data__create_dir(&rec->data, evlist->core=2Enr_mmaps=
);
>>>>> -		if (ret)
>>>>> +		if (ret) {
>>>>> +			pr_err("Failed to create data directory: %s\n", strerror(errno))=
;
>>>>
>>>> errno will be misleading in here, because perf_data__create_dir
>>>> calls other syscalls on error path
>>>
>>> Mostly I want to output something like:
>>>
>>>   Failed to create data dir: Too many open files
>>>
>>> This will trigger the user to increase the open files limit=2E
>>> Would it be better to place such message to perf_data__create_dir afte=
r=20
>>> open() syscall?
>>=20
>> how about something like below (with your change)
>
>Looks better, I will apply this to my patch=2E


Thanks a lot, I'll check when you post it=2E

Thanks for splitting that original patch, it was the correct thing to do i=
n the first place, and now one of the patches got reviews I even missed :-)

- Arnaldo

>
>Thanks,
>Alexey
>
>>=20
>> jirka
>>=20
>>=20
>> ---
>> diff --git a/tools/perf/util/data=2Ec b/tools/perf/util/data=2Ec
>> index 15a4547d608e=2E=2Ed3382098d6f9 100644
>> --- a/tools/perf/util/data=2Ec
>> +++ b/tools/perf/util/data=2Ec
>> @@ -52,8 +52,10 @@ int perf_data__create_dir(struct perf_data *data, in=
t nr)
>>  			goto out_err;
>> =20
>>  		ret =3D open(file->path, O_RDWR|O_CREAT|O_TRUNC, S_IRUSR|S_IWUSR);
>> -		if (ret < 0)
>> +		if (ret < 0) {
>> +			ret =3D -errno;
>>  			goto out_err;
>> +		}
>> =20
>>  		file->fd =3D ret;
>>  	}