Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp4445787pxb; Mon, 21 Feb 2022 21:52:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwb0u3xvSxXBTwf2we/yOiPVe3UFCghuN0BBLIn8HrcaHwAWus9wvYuTT61qKKaHN485uFv X-Received: by 2002:a63:c04c:0:b0:363:d7b7:1cb7 with SMTP id z12-20020a63c04c000000b00363d7b71cb7mr18615304pgi.309.1645509156047; Mon, 21 Feb 2022 21:52:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645509156; cv=none; d=google.com; s=arc-20160816; b=bC8IjTwR0JrKVc+ISiZfAq7TdhQ2sQ1Ml5WEbc0JtgD/6KPdByJLYmJ9gU5zsZGIrl TwqHrhZj0/L+5PkU5OYsV3s84KB1vC0A6UaVkwwTrfU4RcyHXFzV7qX5DgvK18rdmshx MpW+VDiuWfl7XaVAQJG3+kgxSC0RXgP4X5SUga427ynY8ZbFlhWWai8ziEYMVd3HdPuY yhdRlfya1NVYhrmE+aO/yluEmcxOaFZRztBcy7YRaP2ozWz6a0SrxRwlu5NK2a8C6e7G hj57DvCa5GBucvpfLhTswp4P4P4Abbwf9xZCAGrC1KqPxUTKT0d7LzsT9HQQrBtSxKpY Jmgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dGCiAyklfT0Kwf81B9jDnos/NCz7Q3C3wzFKv2X9l/c=; b=pW5UicHtBcdNjzaOaZqnzJMt3RFcQ6KB89//2nhnbgqA8qSbBdSt6nIkBOd+SotDoA UH+YTnFUUnL6meQw9aCivof1T8VAvgNCXC8fOdL5Ve/1l2S+we2w2qgRZz1yiO23nPRP 3tNL8i6NXy5Dw/4ihkBLfAfJbU5ePIh7wPnGM0X/plGkI11BTK3L1Xqop+zr0BoWEJnf lUnABGGeXhUd4+d1iNfAE3zqdPRubnVHoSTH6hE2hODsVHkMsswQmQZ92bZbKGyH8lwh xKY6JkA2Yowzjd7d3sPKq3gSRVMM4ekqJLDBOk722yo6AD6x56/Fxe23xVeCYdC/1nHu 2FIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EAQbwebl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q20si22044830pgt.802.2022.02.21.21.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 21:52:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EAQbwebl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7C79A137755; Mon, 21 Feb 2022 21:15:44 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350851AbiBUJgG (ORCPT + 99 others); Mon, 21 Feb 2022 04:36:06 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345134AbiBUJ1X (ORCPT ); Mon, 21 Feb 2022 04:27:23 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB8776344; Mon, 21 Feb 2022 01:11:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 56CBECE0E79; Mon, 21 Feb 2022 09:11:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36B83C340E9; Mon, 21 Feb 2022 09:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645434709; bh=mc0aKOxSsDuTXpmJoC/IG9w3zf1N4r0QHjUEA7j//a4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EAQbweblt57duCKMUIgnBPpaCUpksBKhzn/jvBZDRjdZnHdLptyMrqWWxXqokdYP+ ZMzYA+b2dKMsJq8BgKtRsju2Zs4NdIZ18TjigdBnnz18x92UKC2nT97mp0/hq4yQti 6nUVYZg6pDkFB0X5Vxx95/zq0bGMc5WHLy9dnoYs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gatis Peisenieks , Jakub Kicinski Subject: [PATCH 5.15 103/196] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC Date: Mon, 21 Feb 2022 09:48:55 +0100 Message-Id: <20220221084934.382608307@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221084930.872957717@linuxfoundation.org> References: <20220221084930.872957717@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gatis Peisenieks commit bf8e59fd315f304eb538546e35de6dc603e4709f upstream. If NIC had packets in tx queue at the moment link down event happened, it could result in tx timeout when link got back up. Since device has more than one tx queue we need to reset them accordingly. Fixes: 057f4af2b171 ("atl1c: add 4 RX/TX queue support for Mikrotik 10/25G NIC") Signed-off-by: Gatis Peisenieks Link: https://lore.kernel.org/r/20220211065123.4187615-1-gatis@mikrotik.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c @@ -900,7 +900,7 @@ static void atl1c_clean_tx_ring(struct a atl1c_clean_buffer(pdev, buffer_info); } - netdev_reset_queue(adapter->netdev); + netdev_tx_reset_queue(netdev_get_tx_queue(adapter->netdev, queue)); /* Zero out Tx-buffers */ memset(tpd_ring->desc, 0, sizeof(struct atl1c_tpd_desc) *