Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423287AbXBPFeK (ORCPT ); Fri, 16 Feb 2007 00:34:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423288AbXBPFeK (ORCPT ); Fri, 16 Feb 2007 00:34:10 -0500 Received: from mail.queued.net ([207.210.101.209]:2893 "EHLO mail.queued.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423287AbXBPFeJ (ORCPT ); Fri, 16 Feb 2007 00:34:09 -0500 Message-ID: <45D54260.7080302@debian.org> Date: Fri, 16 Feb 2007 00:34:24 -0500 From: Andres Salomon User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: Dmitry Torokhov CC: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [patch 1/3] Input: psmouse - create PS/2 protocol options for Kconfig References: <45D43115.6060806@debian.org> <45D50101.60802@debian.org> <20070215173024.adc54d6c.akpm@linux-foundation.org> <200702160028.09251.dtor@insightbb.com> In-Reply-To: <200702160028.09251.dtor@insightbb.com> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 31 Dmitry Torokhov wrote: > On Thursday 15 February 2007 20:30, Andrew Morton wrote: >> On Thu, 15 Feb 2007 19:55:29 -0500 >> Andres Salomon wrote: [...] >> Perhaps a nicer implementation would be to have a separate .c file for each >> variant. >> > > Having completely separate sub-drivers is very hard because of very delicate > PS/2 protocol probing.... > > What do you think about patch below? It somewhat reduces #ifdef clutter in main > module moving it in .h files... > Normally, I'm a fan of that sort of thing. However, in this case, I think it makes sense to have the #ifdefs right in the probe function; at least for me, it makes it easier to understand what's going on. The synaptics stuff is especially tricky; with a cursory glance over the code, one might assume that all the synaptics functions disappear when CONFIG_MOUSE_PS2_SYNAPTICS is unset. However, if the #ifdef's are in the probe function, it's pretty clear that some synaptics functions still get called even when CONFIG_MOUSE_PS2_SYNAPTICS is unset. Just my opinion, anyways. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/