Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 22 Feb 2022 08:30:17 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Stefano Garzarella <sgarzare@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Mike Christie <michael.christie@oracle.com>,
        Stefano Garzarella <sgarzare@redhat.com>,
        Jason Wang <jasowang@redhat.com>, netdev@vger.kernel.org,
        Asias He <asias@redhat.com>,
        virtualization@lists.linux-foundation.org,
        Stefan Hajnoczi <stefanha@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] vhost/vsock: don't check owner in vhost_vsock_stop()
 while releasing
Message-ID: <202202220707.AM3rKUcP-lkp@intel.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220221114916.107045-1-sgarzare@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?DupoMAYxO4Ag8VOUCizWUVbkL3lL+UcMtn8sRuTyFprZsdDW1t+efV2q4j?=
 =?iso-8859-1?Q?qb6DpgmdmzSW1y1Y7qdwUpEVADsD4BDp+X7Vw3k7Xx2xneM7/dZslhWdFS?=
 =?iso-8859-1?Q?AajBvhAM6l8b5dFc93dy0wMMwKk3nYXMgeh++BgBm4EsjBf/Bd6lETCABB?=
 =?iso-8859-1?Q?V8DZw5cyI1NKB87IAcUqk7av+zR+riY1ggRX57ox7QxoKj29+wf0NVmjQy?=
 =?iso-8859-1?Q?a9CHiTN0J0W7sxZ9cQwmHOz+9KZfNC4a05RxjG7Z+zy0WkpBnRKEImuLrn?=
 =?iso-8859-1?Q?p7cM3z76U82MgjGdRAgr87RSzuGbyx3bkkAUZha1VhUar/LbZswemTCmC+?=
 =?iso-8859-1?Q?NgP1cs+J6o0+3U8IT10KkTOMvmBd2B+kO5SnCn7NLXlcXesfjoD0MvEQ5r?=
 =?iso-8859-1?Q?1+SNcVtBm1MK5h6zzsNetstfUFHch5/+y2dtLqOpchy5u6J0a2B8bZRyaL?=
 =?iso-8859-1?Q?n5I19s3rtF1VDBhJR4WnEfl7eaLUgzxASs1/ETTA5LV4j/CUBz0JP78P4v?=
 =?iso-8859-1?Q?xku+MIG9WQ/FD60XDT+4hA2HMAJYMsM4Vi32m/dXUt8VU+SyK5KgIkNUO3?=
 =?iso-8859-1?Q?HzSlcH5qNet+kgowNsrVxEBWTgNc59JMbR0GwIp0L3JVnj7ktHXDxhfRRr?=
 =?iso-8859-1?Q?PU9G+VT9XSpgO0YbMHcUJhAlMPOL61k8In0g/MGBWmP/6q6GWYBBcm3tbg?=
 =?iso-8859-1?Q?eU3GfFbQ+1xMeYF78+h6LUcc8WbFrmEVtv5w1qHnKcBrJaey6/0MeYBDop?=
 =?iso-8859-1?Q?16QsXfbDOnt+dyHu2s+NbnUYzqFsEthsj3/r0/TkEqXLZb+4qSFKw7n4DA?=
 =?iso-8859-1?Q?zPVGnYNhWoTJ9QeXsrYRItVmAhrdLQmVsbRf6QBPaYIFQkdY8+j7ECb7n5?=
 =?iso-8859-1?Q?xnRDzAOABIW/dkUXDga03/zXhRiqHLrtSQsiZo584aN8sabyempWAasEyZ?=
 =?iso-8859-1?Q?gAkB/ulX5sQqiHwkMkzeoO9p/6TJTq5UrYwPpingDwIH+0JJUAb5qKuAvb?=
 =?iso-8859-1?Q?lkXzc0LMuh+bVRZ3MxDjioZkWpKMD0d4BVIBX53V3sKrP3Q4o9sd/MWMfA?=
 =?iso-8859-1?Q?vww+BiliIFd4a1MOwtqri9cvMDMxeg39fc4bQA4uodukd4f1Jf/rORh47C?=
 =?iso-8859-1?Q?tQhIQSoi3yOl9AKGKVEgBl/YJZ4HjRG2f+BMZI2J55gHZYMIqGGU0LTT9c?=
 =?iso-8859-1?Q?MMFRRU6a7AK+7j9deMpNAVudKyE/HyjomAg1hxrl8hpffz6VDwwg6/NE9t?=
 =?iso-8859-1?Q?Eg3AdHqm3Jrtk1RGVKMj4FYc29bE4IMvuK6nQRzIx+ly55kxSrAwABG36X?=
 =?iso-8859-1?Q?THa2ryqY+cbdei6ck2OQGuFfji8fIVD9MfUczu+cix/wRH9/ZGRpsAwVeO?=
 =?iso-8859-1?Q?ecYJLYo6XXzKdxFrRq3dlnEsv0YWfzfV6titaWAViJ11YBEInfFYULaWrh?=
 =?iso-8859-1?Q?Q5lMQ60pJXjhuOvQHX6oeDiaQPZwFMZOQEkHSsInJDY0N3vLA9QLtTJkbH?=
 =?iso-8859-1?Q?zH38efn73q3IY6bXZtr2AwXSvOxgj05dY0MIEh+9kUmsWvVq41IT/LHBfy?=
 =?iso-8859-1?Q?pJ51Lsy+NvmKuzaPCc4fLDfUURUVuWG0WmRm9FeB/a40odkBpWuG4bX4cy?=
 =?iso-8859-1?Q?gNVTaExM6A6CA3hwz21NxlG1fFLCrnA/OlaOy+opRjl+XqHphK7zKefgde?=
 =?iso-8859-1?Q?j4dAkREmlGUCtd0EGg3+Wnspw301nNgNmZQjZlbvSM2L07cr//MtoXam7k?=
 =?iso-8859-1?Q?5tbQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a56b1505-b9ad-4796-4673-08d9f5c470f5
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 05:30:30.9653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SBxV4m5AQJET+FL1WKil9PZ+ZdmvGe9MGszRBTOuWnPGLwMFr4aF1veTB5cCn3fquoGuUTQmcu1CypAzmODFIMTyuBnxvE6Fq73b3YU7SeA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3759
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10265 signatures=677614
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202220032
X-Proofpoint-ORIG-GUID: J2duwGvUQJN2q0vilUVN2G3PJ1Eop8Cy
X-Proofpoint-GUID: J2duwGvUQJN2q0vilUVN2G3PJ1Eop8Cy
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stefano,

url:    https://github.com/0day-ci/linux/commits/Stefano-Garzarella/vhost-vsock-don-t-check-owner-in-vhost_vsock_stop-while-releasing/20220221-195038
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-randconfig-m031-20220221 (https://download.01.org/0day-ci/archive/20220222/202202220707.AM3rKUcP-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/vhost/vsock.c:655 vhost_vsock_stop() error: uninitialized symbol 'ret'.

vim +/ret +655 drivers/vhost/vsock.c

3ace84c91bfcde Stefano Garzarella 2022-02-21  632  static int vhost_vsock_stop(struct vhost_vsock *vsock, bool check_owner)
433fc58e6bf2c8 Asias He           2016-07-28  633  {
433fc58e6bf2c8 Asias He           2016-07-28  634  	size_t i;
433fc58e6bf2c8 Asias He           2016-07-28  635  	int ret;
433fc58e6bf2c8 Asias He           2016-07-28  636  
433fc58e6bf2c8 Asias He           2016-07-28  637  	mutex_lock(&vsock->dev.mutex);
433fc58e6bf2c8 Asias He           2016-07-28  638  
3ace84c91bfcde Stefano Garzarella 2022-02-21  639  	if (check_owner) {
433fc58e6bf2c8 Asias He           2016-07-28  640  		ret = vhost_dev_check_owner(&vsock->dev);
433fc58e6bf2c8 Asias He           2016-07-28  641  		if (ret)
433fc58e6bf2c8 Asias He           2016-07-28  642  			goto err;
3ace84c91bfcde Stefano Garzarella 2022-02-21  643  	}

"ret" not initialized on else path.

433fc58e6bf2c8 Asias He           2016-07-28  644  
433fc58e6bf2c8 Asias He           2016-07-28  645  	for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++) {
433fc58e6bf2c8 Asias He           2016-07-28  646  		struct vhost_virtqueue *vq = &vsock->vqs[i];
433fc58e6bf2c8 Asias He           2016-07-28  647  
433fc58e6bf2c8 Asias He           2016-07-28  648  		mutex_lock(&vq->mutex);
247643f85782fc Eugenio P?rez      2020-03-31  649  		vhost_vq_set_backend(vq, NULL);
433fc58e6bf2c8 Asias He           2016-07-28  650  		mutex_unlock(&vq->mutex);
433fc58e6bf2c8 Asias He           2016-07-28  651  	}
433fc58e6bf2c8 Asias He           2016-07-28  652  
433fc58e6bf2c8 Asias He           2016-07-28  653  err:
433fc58e6bf2c8 Asias He           2016-07-28  654  	mutex_unlock(&vsock->dev.mutex);
433fc58e6bf2c8 Asias He           2016-07-28 @655  	return ret;
433fc58e6bf2c8 Asias He           2016-07-28  656  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org