Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 22 Feb 2022 08:34:52 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Michael Straube <straube.linux@gmail.com>
Cc:     Pavel Skripkin <paskripkin@gmail.com>, gregkh@linuxfoundation.org,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq()
Message-ID: <20220222053452.GC3943@kadam>
References: <20220220154847.7521-1-straube.linux@gmail.com>
 <20220220154847.7521-3-straube.linux@gmail.com>
 <cb7db1ac-8e7e-d549-a5c0-fcd072ae815e@gmail.com>
 <94160654-ec16-cad2-3cc2-46628caaa17e@gmail.com>
 <20220221122250.GE3965@kadam>
 <32a2b74b-f541-ddf6-d8c9-6bd6ca0ad07b@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <32a2b74b-f541-ddf6-d8c9-6bd6ca0ad07b@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?syAmC869AOo1OEYhx733HKRbVtzMMJlsNqcwHOqFhSG5UHxAXOCdidTlOMTl?=
 =?us-ascii?Q?nahbuygu1DYmTlOmcXpsNW7x3/2K6+9s8X+yvHSEMrm8QpSaXjBLlBCODUg7?=
 =?us-ascii?Q?niqwyHjgrO0KiyBmcpuwS9Tb3WUQalN/LFBoSmGot5VkUkgt1zHbVAitMlm2?=
 =?us-ascii?Q?RcMFbYTsoaFwRqKSZPuSUE3IBlJFaX2xmwYzuECixlNZ3IS21pILl4E6kB+o?=
 =?us-ascii?Q?efy1Xn662Yq1rrx5qL+YBKKniVnHogi8cCF6J77LO5xf8h2SCRDTaPgogFRD?=
 =?us-ascii?Q?g92TQLrXYzP/VNqfRW0fiN30MZ1sUf5JQcoPrGqRwUv0OEMsuu6deJP5P/Ap?=
 =?us-ascii?Q?7BTw3yMrnzStHm9OBSIiaoYsOGrcTXjI22F0QB6NJbcAOuNS1kk26aMv3KhQ?=
 =?us-ascii?Q?3dOc8M8/mhE4zOHXeZib7OkcWqrwT/ZXTyZg274ra5JjK4+2FKi0KegmL5HH?=
 =?us-ascii?Q?o/+wi0KUaHZB02RG4o/895BqWXx0S5ETvTYI0ISNwa2ZAoFLAGWgYYS0GBvR?=
 =?us-ascii?Q?OQAVT3j2DOamwlM+N+0h7F6PqLbGm5bfVUZBbX06Ya8+r5CV0I4mzgQIcbze?=
 =?us-ascii?Q?3D3R/4ZTyv2HlPmFsWidk2+ZvrdoRs9WaAp5RuGGxyvvfneb2LjdQNkOLRuZ?=
 =?us-ascii?Q?hnXyxC/FrSOr7KOMGCDETBIVo2bU3n5gubyZJ8+9zrcsNMYFwzrhKPMnMrR6?=
 =?us-ascii?Q?WvIL8yDafjdhWz373KYPo6hWMEKd0BqJnMdwz2RAf4CJDScgVIceN+3QJVKT?=
 =?us-ascii?Q?A+5nrCub6BBp3oqlutHRDyqxv8d9gywJ67TiLCb9QBT3kDYrWTaAvaiDbgkZ?=
 =?us-ascii?Q?g5yg+ojQc5vESsjy2N/U5hOH9F2Nni+rxTWFSf803Airlss5pZqBBUlfGwdm?=
 =?us-ascii?Q?E9vj+ht7Mt0wwnohQ89pDA67suN2cutSuU0IXWnZP3g58xvBmsanUgDJ0HLW?=
 =?us-ascii?Q?5kZjHoBt9/oxXmlg9PtBxSfBfl//88jw+robNjnwZrnXmib/LYMvq6HJuBPY?=
 =?us-ascii?Q?k38U0IOEK0yX/ojzjHLJ8ssv9w8XDM3Sokb5LPzAh34RfxA2Y0i8A7vnNAxV?=
 =?us-ascii?Q?QciEnwyt0BVqBe7TK61iWysDMwa0w+QZL0BLdYmGs8jJcl8vvWeGikXvJIKb?=
 =?us-ascii?Q?2SH2GbzK7KA72yKWIAS/9onBu6qt/ZvNzs18x6OCFMOCUafvuBN3nw1Ydk0y?=
 =?us-ascii?Q?nIMG7bbOpe07t3Nhy3gvtbE7yEK0tsSy5Nda5Ig07qmg6braxkSwoF5Z1c7u?=
 =?us-ascii?Q?AjdQOOLukvMjPfRTF4vd/JErb/RuiYBg0ZFcYCRtnANd3Oc2xLYFAzJYPFWF?=
 =?us-ascii?Q?vX8lDmvNYQjrGFrAHdm4wfAiNwcVXmAKdlSNQJaoKHdLoi+dcLJt9GYDaQOe?=
 =?us-ascii?Q?legGiRnVavuiMTTgJmZwsDvn+GDhtGALdC0zaW/ZDUYta7/0gnTOjvSXoiGQ?=
 =?us-ascii?Q?MP86RFZSVcHC1GFzQq2XuJ6dJ6x3uzYkPYBxcPBmnLnhJJko+Lv3nDX7huAI?=
 =?us-ascii?Q?ba3wRiUNqwEa7+NBUJNbf+HaW9u7jn2SMcNIqgnmK1P79AnDT8hnB4deFtww?=
 =?us-ascii?Q?lBadojdf8gwBHZUunNcASSnOmuR/m/9HhYGu5Uwtf9eSsnCeL6iDQlwc1Sqs?=
 =?us-ascii?Q?ntK16H2ZjZXU+yNSkyfTuGM7xIkCL9gx7gucKjxIKs2MYCD36HO8H94SaTUj?=
 =?us-ascii?Q?1T/DTw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fefb049-5ee8-4bab-a62e-08d9f5c51717
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 05:35:09.9111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nkXpGia8J4qWyr0FhD10xJPnc8o4unQVBzcUkqBA8RYFvgAc+DZ1/D7UCnLk5UcJM4AFmK1R+sxkVn4Indzttw7RM3Y0KXsytXVajmQdll4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2196
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10265 signatures=677614
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202220032
X-Proofpoint-ORIG-GUID: HqtFSy0kIXoK3J-hfdxxA7n7fRDvuJ_F
X-Proofpoint-GUID: HqtFSy0kIXoK3J-hfdxxA7n7fRDvuJ_F
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 21, 2022 at 08:20:14PM +0100, Michael Straube wrote:
> On 2/21/22 13:22, Dan Carpenter wrote:
> > On Sun, Feb 20, 2022 at 05:30:08PM +0100, Michael Straube wrote:
> > > On 2/20/22 17:20, Pavel Skripkin wrote:

> > Just from a review stand point it would be best to leave the original
> > behavior.
> > 
> 
> Do you mean to leave the whole original code including the 5 GHz
> frequencies? Or returning a default value if we have a channel value < 1
> or > 14?

I meant what Pavel said:

	if (channel == 0 || channel > ARRAY_SIZE(ch_freq_map))
		return 2412;

	return ch_freq_map[channel - 1];

> 
> I'm a bit confused now, because Greg asked how we know that the driver
> is only for 2.4 GHz chips.
> 

Haven't you been deleting all the 5GHz code for some time now?  Greg
isn't saying you have to keep that if there is no reason.  Just put the
reason in the commit message and resend.

regards,
dan carpenter