Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <fd1bf218-c1b1-7a8f-7481-211d6f675177@amd.com>
Date:   Tue, 22 Feb 2022 12:39:29 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [RFC PATCH 11/13] KVM: SVM: Add logic to switch between APIC and
 x2APIC virtualization mode
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
        jon.grimm@amd.com, wei.huang2@amd.com, terry.bowman@amd.com
References: <20220221021922.733373-1-suravee.suthikulpanit@amd.com>
 <20220221021922.733373-12-suravee.suthikulpanit@amd.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <20220221021922.733373-12-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2x6MDZaY0IwL2dVWlFZcnhNbzNOemdHUzdicjRPKzYyYWtTMTVDeHlRdkhs?=
 =?utf-8?B?OUwxUm5YVGVhMGJSMjJDSDF0YmtsNkJPQ3ZHSXhnMS9uc0ptc0xsTlJXVk0x?=
 =?utf-8?B?YW5nd3JSdXhwbXpaYjkweklLRjhJNENyTndQWG1CV3hKMUhWZGh6MkEzbENz?=
 =?utf-8?B?cTBRdzBYNUpRMVI0eVJqK0J3UTRXdTd3T01FWTJZYUF1SG1KcHRqelYxRTRK?=
 =?utf-8?B?dnIzZHk0SERsZVdHQm45SGEwTmhPZzB5azNmdWVqNDBpdGtnbVAweXd3QWxB?=
 =?utf-8?B?WVUxMVEwN3BDOU9taXJnNXE0U0hCY0VnYkFkdHdjeVk3TlJWcFh0RGliRVBt?=
 =?utf-8?B?Z3Ftd0didXhEWkthRTlSVk56RllWMTBJSmx4Wm01MGQ5OEtQeloyN2NvY3Y2?=
 =?utf-8?B?V25hZ0lkYzlMQjE5NEdUMm9RTmRMbitSZHNmK2Nzdmt2VlpZdlp6R3pSWGw0?=
 =?utf-8?B?Z2g4MWhmKzA5MWN4VTdGZlVhd0dZeW03N3k4R1ROTUJaQmpzQVBMbGVEL0x1?=
 =?utf-8?B?S0JiUStzcmtnOEdRV2xmTXRkZzVhUmFHbWdQS2YwbHVwZEhLZmpSVVJtcW5W?=
 =?utf-8?B?UmxVVnNMY01WcENGdy9nSnkyckYxTHUxWmJ6WUtOVy9WTWNJMnY5YktkYldW?=
 =?utf-8?B?Nk1qYVRlNk5nYkdUYXYrV0JFZVpuMGQ4YlpZWWg3MzF5RW95d0lwcHUyTGJ6?=
 =?utf-8?B?cjRWT3I0enpWVTF6eXg2c3lxN0ZvQ1BhMEZPUFFTdU94VS8ya1hGSVNXSnZu?=
 =?utf-8?B?dXdiNi9qNEpxNUFsU01uUlgzYUxIWEhRc0RTekNGOGZ1b0tzYUtUblBvNlkr?=
 =?utf-8?B?VnRYZFM4OVFKK21SSUo0bm1RazA1czJYNU9vaXBEQ1ZVbzc2K1NmaERCaVVs?=
 =?utf-8?B?WmY3Zk9hV05vSHd6L0MrT2VOdkFaR0FPVUpIQkhxOGUrMS9CdXBzdWEvUVRR?=
 =?utf-8?B?T2xzbmo2YkdNRy8wMEwxa1AvcWdHTlNtdjVTSzBOR2o3TXNFS2hWVENpaG1K?=
 =?utf-8?B?dEgrUWtTMXdGbzU4SU80TzdTYWxIZzFuSnNnZGExWEZ1blFlcXZaeTI5SE1M?=
 =?utf-8?B?TCtQL1h1RGIzMkdhNEhBazRYYlRTRnNsc0ZNakhwWjVEQmtJY2JlT0FxODdE?=
 =?utf-8?B?R1BzZDRmNzFjbGd3SzdxakMyQUxnRUo1T0haeVNHSnNmWm1uZFdja1dSSXJ5?=
 =?utf-8?B?UitjeldKek9GTXI1U2k1R2J0UktDMXZJTEYyY216VEROZDZYUkpzUFFZNzBR?=
 =?utf-8?B?Y2xBLzlVemQvQU5wVXVxbC9hNG4xRlFJVTlPRGtPdjVVd1B0RU9leFB2QTRt?=
 =?utf-8?B?bEY3dmV4REE1b053OFkzbEdKY3hSVklWODBjcmkxN2MwR2x0Z3pLejIreU5W?=
 =?utf-8?B?bnU5UCtRcktvdnhPTDVrWTZ1YTVLa2RhZGFCNFFJRnpXRzRLeGRpMjk4Uk5l?=
 =?utf-8?B?NGp2TUdFWGNORW1NWllQVmw4YUdEM0RnSmhGQkhtMG5xTnkrbEhjdnNYZ1FQ?=
 =?utf-8?B?NGhOQS8zbXQ0b2pHMnBBa25SRW1NbUozaEwxTy9MOGR4WkNWT01rN1JuMjZ0?=
 =?utf-8?B?eWFYNjVGemxYb0NwRU5CQ25iT0VwZ0t0L1phQ0JYcUZSWUg4dTJMM2dFQVEr?=
 =?utf-8?B?OG9yUEVndTJOVkhPZmJLV1djWS9LWkduM25hdU52NU16b0tadEZKZWl4NE0w?=
 =?utf-8?B?TFM5RHF2UkRRQURIV1ZNNENaT2dKWlVoekNXNHlXbXJUa1lmWnp4YWtyTm9a?=
 =?utf-8?B?SDBHc1pnTkcxMGtTbDRYSWRFb2d4M253dGlBSmJoZEIwcDZOeEdXRDRINVY0?=
 =?utf-8?B?N2pKL0VnUXZyM0pjZitjNEVDcUJMc1BsQUo2Z0x6alQxaExPai9DMk5zVEhr?=
 =?utf-8?B?TmJpRHJqUVlZRFFlSU96VVdLUTkrMGQxYXRWTGZmK0EzNktLLzdsaCtSZ3BZ?=
 =?utf-8?B?MkxtVHFIL0U0TFFFVUdXTFMvZnhHLzZUdVBmMlJBb0kzcDViblhqSGk5RkJu?=
 =?utf-8?B?cTA3Vis5TXpUNmR3U3dhVFdwdjFRVkxML3pDcm5MSXdkR1ZFYkpyYk5iV3Vo?=
 =?utf-8?B?Z3hXN3hPMW5wb1V5Qm1PYW5paVBZVlVJZmQ3dE53aExPeGpvMlVJUmtaNFlz?=
 =?utf-8?B?SGV1dExzcS9IUFZTOC9CaWIxeXFpYWJYUjR2cCtVWnZvaFRzdmpWMUU1cnpB?=
 =?utf-8?Q?boTRSvgAnrcoerPMOfi7T1o=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89b19efa-e8a4-4f55-fc8c-08d9f5c5b79b
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 05:39:39.0732
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aSpQsejINYdZCSQp2yT/k2F5Esp/EAkwQW+jjlwH4TuNH7OfzDETqzNR+8NPJRw7k/m5KvrEfnMh98zSAfKCgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5263
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/21/2022 9:19 AM, Suravee Suthikulpanit wrote:
> ....
> diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
> index 3543b7a4514a..3306b74f1d8b 100644
> --- a/arch/x86/kvm/svm/avic.c
> +++ b/arch/x86/kvm/svm/avic.c
> @@ -79,6 +79,50 @@ static inline enum avic_modes avic_get_vcpu_apic_mode(struct vcpu_svm *svm)
> ..
> +void avic_activate_vmcb(struct vcpu_svm *svm)

This should be static void.

> +{
> +	struct vmcb *vmcb = svm->vmcb01.ptr;
> +
> +	vmcb->control.int_ctl |= AVIC_ENABLE_MASK;
> +
> +	if (svm->x2apic_enabled) {
> +		vmcb->control.int_ctl |= X2APIC_MODE_MASK;
> +		vmcb->control.avic_physical_id &= ~X2AVIC_MAX_PHYSICAL_ID;
> +		vmcb->control.avic_physical_id |= X2AVIC_MAX_PHYSICAL_ID;
> +		/* Disabling MSR intercept for x2APIC registers */
> +		avic_set_x2apic_msr_interception(svm, false);
> +	} else {
> +		vmcb->control.avic_physical_id &= ~AVIC_MAX_PHYSICAL_ID;
> +		vmcb->control.avic_physical_id |= AVIC_MAX_PHYSICAL_ID;
> +		/* Enabling MSR intercept for x2APIC registers */
> +		avic_set_x2apic_msr_interception(svm, true);
> +	}
> +}
> +
> +void avic_deactivate_vmcb(struct vcpu_svm *svm)

This should be static void.

Reported-by: kernel test robot <lkp@intel.com>

Regards,
Suravee