Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 22 Feb 2022 08:40:19 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     Michael Straube <straube.linux@gmail.com>,
        gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq()
Message-ID: <20220222054018.GD3943@kadam>
References: <20220220154847.7521-1-straube.linux@gmail.com>
 <20220220154847.7521-3-straube.linux@gmail.com>
 <cb7db1ac-8e7e-d549-a5c0-fcd072ae815e@gmail.com>
 <94160654-ec16-cad2-3cc2-46628caaa17e@gmail.com>
 <20220221122250.GE3965@kadam>
 <32a2b74b-f541-ddf6-d8c9-6bd6ca0ad07b@gmail.com>
 <8d5cf235-27f0-9c7a-3659-d2b1fe7a02dd@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8d5cf235-27f0-9c7a-3659-d2b1fe7a02dd@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yj8s2RuG3JZsPuUJHubUCBzVOaFpHajcpAHhrN5Fgf5ubqb9Mc/CmpwRP194?=
 =?us-ascii?Q?wNifH/STrDhQy9tHljXDrWEHggKu7XVlvQ0J/fZJvsSUAD7Rx6Araw+RkVoQ?=
 =?us-ascii?Q?BnP0dbMDHjpBhQIZU6qsjE+vqxqoneDNuqlYrHDQHmbtJHdjQxcM+zrFjNiQ?=
 =?us-ascii?Q?su4K9E28SaVnpu9s3eB7CD4NdRx4FAa/p4a5jCpVzFlYFLlr73athTYmvQUK?=
 =?us-ascii?Q?VlOBTFntezAhjSJOoQcxHpGbbwUvvso+fCSIql1kcFeUWki6TDrsrmy8TSde?=
 =?us-ascii?Q?NPqpz8olf2VQdlUXVkYfJb1awO998s9XbSJ7Cae0T1jVmOS6ERnZUM8fbyzg?=
 =?us-ascii?Q?chP6FSYAbjZ7JUilp3pca/2jKE4CLPBe5ZrTUNK6OrOWtPzxzN/4WKkb0Ae+?=
 =?us-ascii?Q?GFusbOj4KHs0vrjmQnrt4Udbo4YCJtW36ofzlNFl5gBCbstWOEr0rn0EDOcz?=
 =?us-ascii?Q?n0Ih+su+blPLbBF92LMZQdZPZlTC5zQRAp8ddODzaRyY3KrXvpBQeKAxiysS?=
 =?us-ascii?Q?3OHEXElfFSfUboHH9/BEmpwNx1bnL35TOwrXgYeBPuCjLiAxIeK+tYfxo6UY?=
 =?us-ascii?Q?To86h5ujLHIR1TO3Jj14Rt1n92n0e3rFDNG3NpBG0+K5ngyZTGPINF6f9BCx?=
 =?us-ascii?Q?+M5j8puZf+BlTkvInReUTaV1sqs3lj4OoCFcW5Pr2wFuipbsXirQ1fuzjgfj?=
 =?us-ascii?Q?xQdm45v63geGVGfQb/bjz44qNkkaZni7D+dgTR/Bto9wintgUNSTWyICd+P4?=
 =?us-ascii?Q?mVnG+UxS5LpfVVmlkOp/OCCQBhhjbxtkmZ34epClovxzdM9qkoYUUm6NoHd3?=
 =?us-ascii?Q?uUjX3Wjowe3kd8eGVAF5lVCiTAV1FQDYZd70VS/YULx/lZhEdphrZIFzO+GH?=
 =?us-ascii?Q?WrMHemfIxeaa0/G9+I1qXHIpzpp5rnkBKIYXCo2AtzgMCOXHAPAg4QiCLXaf?=
 =?us-ascii?Q?2sg1dbCftiIY94GSSZdlDjEE+HHpGsLNIFf7Uo38xZ51E4GOYGvNe1dvn5Q1?=
 =?us-ascii?Q?WZ30g5AZZ/O8JkupN1wjzE5bqCEh6OXZYSNyxywhUbldJiRNvb6YYk+vypcb?=
 =?us-ascii?Q?CdA8E3UPTI2RWzFh+UzTPvPM/V1W1l3rqGrdXVeqLIINyHEuBJggUgGneKI6?=
 =?us-ascii?Q?jD1iVVi2E3xhiLSgg6jgevjqPi+MTFKWZz0gvA2EZnjgNBZDZxmSgtHrVmBb?=
 =?us-ascii?Q?U3mwuUwMS3+KenQXNGtPkcFn7Hbm258voQbZDlwvBTij1ZRpbC0ARzsSx/tB?=
 =?us-ascii?Q?jyAew+F9sIAYzKjRyRYtSo1tb/woHr1XYZcxmPvzPAMKyfWGgUtUINgnMfwK?=
 =?us-ascii?Q?mu+fRr+6TplE/0mYDdmHzynYnGaiS2ydIU7Ye/Qn4PmvbJAqeOrQzkKRh29M?=
 =?us-ascii?Q?4ntDlqdAQNzF7pGXp0Gw0cOtZLLYwNMvbUV9bHN1U24tCLl/Zl78snvjqySB?=
 =?us-ascii?Q?GsIrTmwqdotX9bGNoeyfPKOxJLfOTLWCgu3ndbADe6pXf43HVXgyJY8YJ1kP?=
 =?us-ascii?Q?rTBXyhvSMk/T7n7QGi4KzB+TzrO6syTTTbUi1yy9hjyTyxZkrzq3183Lr4Vo?=
 =?us-ascii?Q?H+Clr9i0hV3yvmxbdDgfVPBLvDnxxW40vIrwUP5d+5gUxMOoAiaZK4vk/nmq?=
 =?us-ascii?Q?J0LWNSZ1MRkfHKduLnLIQSdgTISCjGokt+PqB16ySOAEXorl1sYFWkAx9y9O?=
 =?us-ascii?Q?LBezyg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f471045-ae09-4c6d-2464-08d9f5c5d5fd
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 05:40:29.9947
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c0x6LpJ+jaAJB6aVtD2Ma7Yjvou2tW/gXgrcnNb4CCcBBT1ZqqPwf7faBjgh70NP7wNcM9ZGTBZoOnLU1/5hrJxyPPUpqmZMuDJ4vy+ydLg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1986
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10265 signatures=677614
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202220033
X-Proofpoint-ORIG-GUID: CT0lcKAq5fozFMKYUjzIBHRkL83f7U9K
X-Proofpoint-GUID: CT0lcKAq5fozFMKYUjzIBHRkL83f7U9K
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 21, 2022 at 11:54:50PM +0300, Pavel Skripkin wrote:
> Hi Michael,
> 
> On 2/21/22 22:20, Michael Straube wrote:
> > > I'm glad that Pavel noticed this change.  This is a risky thing and
> > > should have been noted in the commit message.
> > > 
> > > Just from a review stand point it would be best to leave the original
> > > behavior.
> > > 
> > 
> > Do you mean to leave the whole original code including the 5 GHz
> > frequencies? Or returning a default value if we have a channel value < 1
> > or > 14?
> > 
> 
> IMO, your version is much cleaner than previous one. This table walk seems
> really unreasonable, since 5 GHz support is really redundant (I saw it in
> other thread)
> 
> I'd put just sanity check and return the default value from previous
> version. Maybe even wrapped with unlikely() if we sure, that in normal state
> we won't hit it ;)

Adding likely()/unlikely() annotations hurt readability.  Do not do that
unless you have benchmark data to prove that it is worth it.  (Hint: it
is not worth it here).

regards,
dan carpenter