Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp4522333pxb; Tue, 22 Feb 2022 00:05:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzwzs/YhWODy3WWxbvIUZXs/P/Wc3sGpNqtCay0ca2bfbLLOrjgslCL7sNJuuFQYvmjBJY9 X-Received: by 2002:a17:906:5f89:b0:6d0:226c:628d with SMTP id a9-20020a1709065f8900b006d0226c628dmr18432036eju.646.1645517100145; Tue, 22 Feb 2022 00:05:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645517100; cv=none; d=google.com; s=arc-20160816; b=oolnSBN+THcp4RgP51h6WC/mQyvNXwIvmI2RRiznjFSskcGaXxRmdYBERAl7K+JMfo HgaTjwyS2f+Jsx2GWRlS7NW3d+s5yOsSRhkAa1YGPjdp4AtXUL12a6f7tP/m+5oRVMLB gLpVz34VmV7N6csLKvuJ72GcyKPBFP78zSRzlWHOJD1F2VvGQyWua2hkOFj/T1mFfxff PHFtkXlt3GO0TbIMt9DqhYJRwp5it48W+pfUjmZXKfCz4D2fY61TMZef3JWCLyaI1efG I+8MlbTTNK9s8Ggc8N9og7HzY6SPkxZZ2fq+ZKE9EQBDTOyRzWL4vFlApfcjm2d/S2vr ZfGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ORBF63952JWIlwFqVnXGFT6YnhmkLo2k4Gn5pDTRsuY=; b=pffNGbwWtO5j9h2EVsMVZS9TtlfSzX+V5h5IXZkyfnEQIaJhrdHrbAoBxgXa/N1ngq MKkqPEg+p7uO80Ioy4XuwhrbprrvSXXBWBC3PCvH+7QPtLHZqTmKAqpLAb/XWYyg31bs PM3nES/yyVGVDqN8GZeoXxPZe4NIvsf7Gx4Tmfg21pbkM2mBFqxEF5hjx/GDLJhD5x41 3Igxw0zj5guKV7Xg+tP2PoW8/lZcYb1qbKu1hqa1AN1StBnQFLaN1bCOM+/R42j2g+5t 1zLoMgot5NPVzRpDKA3jquar6y0YsmHTlseuoEbc+7gUTC1fgMusPy5CRqZXvg3awvH0 9K2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JvdEnk6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v6si4744684edq.276.2022.02.22.00.04.36; Tue, 22 Feb 2022 00:05:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JvdEnk6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229916AbiBVICB (ORCPT + 99 others); Tue, 22 Feb 2022 03:02:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbiBVICA (ORCPT ); Tue, 22 Feb 2022 03:02:00 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 057AEDF74; Tue, 22 Feb 2022 00:01:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ORBF63952JWIlwFqVnXGFT6YnhmkLo2k4Gn5pDTRsuY=; b=JvdEnk6EijkAJ3snIkHL5LIdDJ nlEQqwCfKiy0UBENlPkKFdv5Fi8INhe5JE6i/OXSmIE+f+nTRxkPmjoP3TIgaqI4k5gBCfUqGEpKw qU53z0ZATsVSoxaVFl9khH8A52AcTLXdSL5G9VII1fW58mWKCd89ETkVypF0buokG2PFMXmrD9A66 CyMBtp4eVlvLsUNYntYAOoyrPABWsiDvAcwYBD4Sn+dkSIgw8xoCarGpQIIt5V48Es+KcKcLZWk15 x98HaTkv5gf1yFOxK79RRJC7DJZwAuvlguiHpgM3ngM3LMvfUGt0ywGo2sMs/uVBkqLohCXeYDHvt 6J7ISLAQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMQ6z-008R1k-I5; Tue, 22 Feb 2022 08:01:29 +0000 Date: Tue, 22 Feb 2022 00:01:29 -0800 From: Christoph Hellwig To: Finn Thain Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mesh: Stop using struct scsi_pointer Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 22, 2022 at 10:09:42AM +1100, Finn Thain wrote: > This driver doesn't use SCp.ptr to save a SCSI command data pointer > which means "scsi pointer" is a complete misnomer here. Only a few > members of struct scsi_pointer are used and the rest waste memory. > Avoid the "struct foo { struct bar; };" silliness. Looks good: Reviewed-by: Christoph Hellwig