Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Feb 2022 09:35:25 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Ondrej Zary <linux@zary.sk>
Cc:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Tim Waugh <tim@cyberelk.net>, linux-block@vger.kernel.org,
        linux-parport@lists.infradead.org, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_parport: second preview
Message-ID: <20220222083525.GB5899@lst.de>
References: <20220220224909.8032-1-linux@zary.sk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220220224909.8032-1-linux@zary.sk>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Sun, Feb 20, 2022 at 11:49:09PM +0100, Ondrej Zary wrote:
> Protocol registration could be improved - I don't like protocols[] and
> protocol numbers, devices should probably be created by protocol name.
> Also the LPT port base addresses should probably be replaced by port names
> (like parport0).
> 
> The bpck driver seems to need to know if a CD drive is attached (weird) but
> I doubt that I can get such info from libata.

You can check adev->class == ATA_DEV_ATAPI, there's a bunch of drivers
that already do that.

I'll try to take a look at the actual patch once I find a bit of time.