Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <acc45712-b6c7-5cc8-920f-93f3db45413f@intel.com>
Date:   Tue, 22 Feb 2022 10:28:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [Intel-gfx] [PATCH v3 08/11] drm/i915: Separate wakeref tracking
Content-Language: en-US
To:     =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
CC:     <linux-kernel@vger.kernel.org>, <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, netdev <netdev@vger.kernel.org>,
        "Lucas De Marchi" <lucas.demarchi@intel.com>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Eric Dumazet <edumazet@google.com>,
        Chris Wilson <chris.p.wilson@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>
References: <20220221232542.1481315-1-andrzej.hajda@intel.com>
 <20220221232542.1481315-9-andrzej.hajda@intel.com>
 <YhSM4HFT7UpRYEIg@intel.com>
From:   Andrzej Hajda <andrzej.hajda@intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298
 Gdansk - KRS 101882 - NIP 957-07-52-316
In-Reply-To: <YhSM4HFT7UpRYEIg@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFlqaW5ZRElVaXY0MGdOejNqY1ppaWwrS2xZd3ljdWlBTHpnQTl1U3NFTnFi?=
 =?utf-8?B?ckh4K3dXZzE3dkxxeGZNYjUrQ2hTcThsd2U5L1lNZVE4S0ZJNElnNzJOU1FP?=
 =?utf-8?B?b3MrSVhrelg4RS9sVTdqOGJsTk83QWxsQWJiZUVmSVRHWER0T2lsT29PY1dt?=
 =?utf-8?B?M0RUYXZjSHVRLzRPRm5CNWpreW5EK3FMMGd3d1VFbmlnWEdqRUhjTlpmTmJX?=
 =?utf-8?B?elkxakNVM2hFakRQNDB6b1N3blIwbkxEU0dFVnkzM25KdWdsaUJFWTNhcHd0?=
 =?utf-8?B?V2V1Mk1uSlRGWTFGNHd2SjMwckVIakJoRFk5NmlEcEw1eW9uZ29CSTYyMngy?=
 =?utf-8?B?Q1lrN2U5dVZCSnlLZ2dmOFRPUlpnYUtyVmJMcUdBN3JBL3JZOUVab0VlWUF4?=
 =?utf-8?B?a0NhV2pyWlo5Z0ZHbkxXU3NmQVZPenVlWTR4dC9SUlpiNzRSWjQraGU0aGtD?=
 =?utf-8?B?d2l6UStGZkIxZHNDNXFMYWRYeVU3TEREYllHcWFBcHpzZ2ZqaTd2dGhKRzl4?=
 =?utf-8?B?QXZCeHdCTWRnTDEzc1p6ZVNxNUdzeGx4NVhEZTlsT0tSMjVJV01vT2VhS3pG?=
 =?utf-8?B?L3ppRWhML0wxdWFBeXNpOXpPVnNnRnluU2hwVlBENE5vSWl5RGsrcEJUYkF5?=
 =?utf-8?B?cUpLZGxwdmI0OG1zbmgyamhhV3RNTkUxN0dNM3c5RE5RVmVjZFBnYk5aWkJR?=
 =?utf-8?B?YzluWEVLdXQ2K09mbzQ1U3RicGJSSk8zSzdVVmZOY3J3dEQ4eE82ZU9lK3VT?=
 =?utf-8?B?aUlpeW51YlpXL3Q5S2JRYkI4dnhQZVpRcUdVaWRiK0l6RlVpaDQybXU2SGhL?=
 =?utf-8?B?eDVCeHo4dldZUnlkYm9MVXRrcWJRWkpGdVFjSFV4cEJiMmlkZUg5aHBFY2tR?=
 =?utf-8?B?aFVSeFVNYnczMDZRL3hFZDlWQStMendoWDZwVnhsNlNSZmo0K2haZDFtSUNF?=
 =?utf-8?B?Z3ZlaDkvNFhLMXc2QTRlcVpJWWNNNmoySUFQdDQxKytGSVBsSjZZSG9Fc2xF?=
 =?utf-8?B?RVJ5MUM3bGRMUWx2S21HWmVEYVNVS0ExVXBETXNHVW91R0lFd2lYUGZyQ0V4?=
 =?utf-8?B?TndCRmNVWnFWNTFoa3Z5SmYzRFhKL1lIZVZmMEh5RTBhSTZ3NElucjRaL1lT?=
 =?utf-8?B?S3VSbE1hUkR3ZHlvWGNiUFBEWE1kaXNvc2w5T3JYeHJDcTRYVDZkKytuanpH?=
 =?utf-8?B?Sk9ORkIvbTdZWjR5Q0I0d0tmakJMSjlEc21sMWtQTnd6bDhweFZZNGNzdnBO?=
 =?utf-8?B?Y1pNNmFmQmpwd3NCcE1OL0RxMFg1dTJoK3I0VjYzNzNtMW9nZE0waEJrRzZL?=
 =?utf-8?B?MHdiRmpMTkpIRmJ1VzJ1RThaSVM1RzgwcS9WTU1QQ0tkTzltT3VvS2kwMzM3?=
 =?utf-8?B?YXdUalkzME1qbFB5M3FWeGpuSEpnTFgyQlE4RnJpL0xzUEFNUGZHaWtaSzlW?=
 =?utf-8?B?RmlEbVBKWWpxZHBlWENqNmVyQjROaFhBalF0b3JKL3NBK3ZWV2FZbHZ0Z1ZL?=
 =?utf-8?B?L3JGT0ZUSHNta1dRMHhOY0JtSGE1ZG5RMmcrYTdXOFllc1JIN2xXR1hCcGtD?=
 =?utf-8?B?NWwxTm92cVRoVDNWQjhoN2pSNDdDdjdmWURSK2VIS1g4U2llTjlKdFYvQmxh?=
 =?utf-8?B?YUtiUitaZ0k3d1c5dnlpcWh0M1owVzlEbXFzTGJxeldaRlRmbXRuVlBXWEU2?=
 =?utf-8?B?R1pUaldQSDB4SVVLOEVWUVpUdXdYcGVteUZFZXo4cWFxT09yQXFvQmwrZDhH?=
 =?utf-8?B?dU5pejdZTmlpejVTWFRuUEU5NUpNNjBiT2lYc29ITlNBaWdnalc0RTY0S0tL?=
 =?utf-8?B?dW1pSW4xT0RwTjV0cUxEUXYyOWxTTkRtK3p6bW5ZMkovdWxYaG9zWGZQNkta?=
 =?utf-8?B?TUVXU29jSmMybG1LK28yd3d2Mk1TZjI4ZnhqSkpCRVI3VkNMYlprQkd0ZHAx?=
 =?utf-8?B?Sk1WbjNLWDBTL3lPdWhJOFFlOXdtdkV2aTllZkRScFJ2S1dybnVYRE5uUWps?=
 =?utf-8?B?ajh6VE1OL1VaLzJ6NE1TSlNGZVh5MkRDVzdVdTdkWnBnVG81TldNMFIyWE81?=
 =?utf-8?B?ZDJVUEQ2NjRPNVI0UlpNRWwzY2VQVHRNMzB0UE5saS8yYjcyMlFuN3RmVDNT?=
 =?utf-8?B?eGFXYlQ5L1FYL25leEcyUkh2QUhDWnZVUFdWdElqYlk3SGpXc3JmNEJUY0Jj?=
 =?utf-8?Q?eGbKogWzmkYOt0yZqiVM9II=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d73332a-8308-4ce0-d2fe-08d9f5e5b56b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3180.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 09:28:39.1725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L+AZnYDxwfBuQK6ecAPsotvCp7iJDqg70eAekAPGY3YGYXHzTxrmO3LyORKkdcEQbqw+uDms2YhDAG/q98Z2qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2113
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 22.02.2022 08:12, Ville Syrjälä wrote:
> On Tue, Feb 22, 2022 at 12:25:39AM +0100, Andrzej Hajda wrote:
>> -static noinline depot_stack_handle_t
>> +static intel_wakeref_t
>>   track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
>>   {
>> -	depot_stack_handle_t stack, *stacks;
>> -	unsigned long flags;
>> -
>> -	if (rpm->no_wakeref_tracking)
>> -		return -1;
>> -
>> -	stack = __save_depot_stack();
>> -	if (!stack)
>> +	if (!rpm->available)
>>   		return -1;
> Still not the same.
>

It was fixed but in wrong place - patch 11. I will move the change here.

Regards
Andrzej