Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e867e419-fa9f-e67f-bbfb-5261874c9d29@amd.com>
Date:   Tue, 22 Feb 2022 12:31:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] dma-buf: check the return value of kstrdup()
Content-Language: en-US
To:     xkernel.wang@foxmail.com, sumit.semwal@linaro.org
Cc:     linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <tencent_22C6C2E595DEFED1417A98A5736539482809@qq.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <tencent_22C6C2E595DEFED1417A98A5736539482809@qq.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTNndUp1a0FqRWlXZUsxV0tYRFJsZzF1R1lmeWlVWXZjWlJpalZCSndTeXJW?=
 =?utf-8?B?cGUvaCtDNEYzRk4xdmdsdTQ0WU9uLzlYeHZ2VkRwUkM3aDNTTUcrQU9yN25t?=
 =?utf-8?B?N0hTU2FqR1JKSjBBRGVyRVBBSjFRYXJOL2l1UkRjOWtGVDd4UDZoNVRKdzNE?=
 =?utf-8?B?Sm5qUDJibElwenZNM0VGaTI5NjBNemtDVXk5djlVdGViTFFsTDFqeXR3NFhP?=
 =?utf-8?B?U3IydHQvMlhwaTlqL3JJdHBDZUlOcisrczRTQ0VlV3dndU83enZiZ0VLRk9v?=
 =?utf-8?B?eUNkZnptS010NW1oVFJ3eWJwK3JDWTBiUkxnaHgvU2JqdzFmOUV0ckIrQmx4?=
 =?utf-8?B?N09xRjB2V3ZCRmpOSThKekZQUHBQY2ttMFlUWVdZZGFrUlVtNXR3U25HM3JR?=
 =?utf-8?B?L2NMblE2WDJOT3ZoNjVWZEs2UFpOSWRUV2J2OHRFeTNCMG5DdGZCRUlxQ2xC?=
 =?utf-8?B?aDlrQ3NtVHYxcWpxSmcxUDB5M3RaSnV1OXZWdDU2c2RnbWtDNUY3MWhJaHg3?=
 =?utf-8?B?aGdtRklhY3paZjlTS1p4OTR3RTFwS0U1RzVkdUZ4YUF1ZndEZURCR3lVRnV4?=
 =?utf-8?B?eGZpS2kySTNvZVF2cE1tTWRXYU1JcDVrWmR6aUV1NVNJTjB6K0h5ZUJkWHBr?=
 =?utf-8?B?WmYrQ01sNHM1VlVTMm9JVG9NM1g0SlFvVDFlWk16S0YxTHB2d0ZmajI1QVlD?=
 =?utf-8?B?dUNwOUMvUjdlRGdEWHE4NVRzUU1lNStqL1g4eDYwMGxNcitmZzN5VS80ZTJt?=
 =?utf-8?B?UEx5Qms3dGU3OGVXZ000ZXp5Z2RDbm8wRGlzdWdESGltaW1TWWQxWlViR25m?=
 =?utf-8?B?SDd1c1hEelY2TkpNQVR6R0hBbkFwb3F5OGp2YjJSQWZZQU5JSWFnWnIxYzl0?=
 =?utf-8?B?RHlPWlVyWElvb2krM3FPQ3Fid2xLeHN5UnhtSTF4VzdCSkVSaitIakVoMnlS?=
 =?utf-8?B?SmRROUQwSTFvNlJmeUs1cUw3blIwOTAva1lRci9jWFBIS1lTbTJnWEpiMU9G?=
 =?utf-8?B?OVE4R0wzam8vTHNjLzUyaC8yMEtWQThMZDBsN0c5eHFER05mcGNRbTFSaWty?=
 =?utf-8?B?Nkx1emtFWnB4Q1BKQVp5OGh0Z0dUdFdSNjUvSWhLWDYxYi94c0FoV2Z5a01w?=
 =?utf-8?B?Q25SRUdjdUxUVWxaUjEvbUZ5SktoOHhic2lrTk1GeDU0M3pUZ0lya0E4QTRF?=
 =?utf-8?B?MGQrSmFCUDR2eXdkWVJQWXdVUUZtcTI3OE0wUkI1MGlBaEUrRWhqSlZudTd6?=
 =?utf-8?B?dGlRbnlWZFQwWGRHUC9JMDF1eFJGbWVCUWhYZW5QbWRLTy9BZms3R2Jwb2FJ?=
 =?utf-8?B?aXpyc0NuZjlNZFhkaVhaYTJHQ3lYZnp0OXlNamdGTlMzeUFVTE5Ja3VuREta?=
 =?utf-8?B?SG1ZMmZBK2xSMjZhM2dUczlHU1dHWDZhcEtiVWNWN0lBMVFvQi9CM2k0d0FI?=
 =?utf-8?B?TWZ2eEhmSGpFaVBJM0V0RE1qYXFHNGw5REN1VkJjOXBuNEhCaTF4VTRnUDhD?=
 =?utf-8?B?RXEzZGc5Q2R0bSsvYVc2ZllPZm42R1A4VE4yRzJlRGpXOG9reU50dmFtK2px?=
 =?utf-8?B?RWwwdjFuU3ZOKzVPeFFySVVDWXpCeWE1bXJBZ2YyUmN2MVhXSmh0V0E2Mkpk?=
 =?utf-8?B?VldnVHEzQTlZdzBHOXRDQ0N1VkdpN2ZZck1sQkllZjA4SlhtcTNiSmJhL0tI?=
 =?utf-8?B?elRmLys4bjB2UnN1VXFncWh2UkhKdHpQa2VuQXlBeFlveWxzelRFSHlqUm5R?=
 =?utf-8?B?YldWaEhnUSs4ZVhFYWNYcWNJYUxiUEJYblFUWG55TWpVUld5eVZGOXpBaXFG?=
 =?utf-8?B?YzRLK1pydEtjblV5ai9TbDNkQkozNjNIQlBzNnRPSUxkTEUxOHN1YmFDWDVT?=
 =?utf-8?B?UVVIN0xrcTByQzRmNDNwUk9YQ29FeWZzMXZpa1JjUmVVL3c5L3FYTFhaVlFz?=
 =?utf-8?B?cG1ZMXlHVEZmbUN3QlhxY0dBRDgwYzN6K09SYktOcDNtYlhJaXBvcVNXZFcr?=
 =?utf-8?B?Wk9EUkJTMVpFVTF2UHpzRmNxc0dHT1NjRkM0NWFwbHZOSlpRYzhKS1ZVemVM?=
 =?utf-8?B?RCtkR0g1SXpqKzArbm9OUlRERzhFclQ5YlFmclZqZktFWFRKM3dkbms5Y200?=
 =?utf-8?B?aCs0TW4xVTdUUkRYREJLTlB5S2JBdEhLQlhld2VBWGI0cmdyNlV0Z1F5eXVW?=
 =?utf-8?Q?0AIJ7IJMpKPP8oeZC85OS54=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35bbb069-8481-4002-b1a0-08d9f5f6ef7a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 11:31:58.0378
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6QaA2ZJ9ZvYC3pPbKcQAPTvyC4ICrGoc+D260qw4V3RKMBrdblOl6mrnoYRp0VyN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3033
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 22.02.22 um 12:30 schrieb xkernel.wang@foxmail.com:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kstrdup() is a memory allocation function which can return NULL when
> some internaly memory errors happen. It is better to check the return
> value of it to prevent further wrong memory access.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/dma-buf/selftest.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma-buf/selftest.c b/drivers/dma-buf/selftest.c
> index c60b694..2c29e2a 100644
> --- a/drivers/dma-buf/selftest.c
> +++ b/drivers/dma-buf/selftest.c
> @@ -50,6 +50,9 @@ static bool apply_subtest_filter(const char *caller, const char *name)
>   	bool result = true;
>   
>   	filter = kstrdup(__st_filter, GFP_KERNEL);
> +	if (!filter)
> +		return false;
> +
>   	for (sep = filter; (tok = strsep(&sep, ","));) {
>   		bool allow = true;
>   		char *sl;