Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <00534db7-6b0e-7efa-11a1-d386e2f71a23@intel.com>
Date:   Tue, 22 Feb 2022 11:44:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH v3 07/11] lib/ref_tracker: remove warnings in case of
 allocation failure
Content-Language: en-US
To:     Eric Dumazet <edumazet@google.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, netdev <netdev@vger.kernel.org>,
        "Jani Nikula" <jani.nikula@linux.intel.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Lucas De Marchi <lucas.demarchi@intel.com>,
        Chris Wilson <chris.p.wilson@intel.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>
References: <20220221232542.1481315-1-andrzej.hajda@intel.com>
 <20220221232542.1481315-8-andrzej.hajda@intel.com>
 <CANn89i+E3z-iXSJh8316KSycYk2VTS-n0E=tAOj23fuDSi1Zjg@mail.gmail.com>
From:   Andrzej Hajda <andrzej.hajda@intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298
 Gdansk - KRS 101882 - NIP 957-07-52-316
In-Reply-To: <CANn89i+E3z-iXSJh8316KSycYk2VTS-n0E=tAOj23fuDSi1Zjg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3BGdU1KR2s1MUYzeWswOUtCK1Q3aEhJYy9qWThrandLZDgzbVp1S1QvYTVK?=
 =?utf-8?B?RXpaUjF2Yi9vMzN4T2Q0N21hVDR0SzF0djdZcGFqS0c1YXZ5WUtVZC9QZ0pl?=
 =?utf-8?B?dHdTZS9QNWFvZmFITU94aEVSLzczZFRtbVIzbFVIM3dTMktaVWlreGFwNnZn?=
 =?utf-8?B?TVBzcndsTEJqdVRFeloyK01vSkh0d2xVWUhVUTRWRUFYaVNhYldoSVdxNlZt?=
 =?utf-8?B?V081RXExNXhlWGsvYmpseTJyK0dTM2tIOW8wbkhSMjJHUHJ4VUFRK3pMRS94?=
 =?utf-8?B?Uk1EdTl1NlAycnVuSWV5SWFZMjVmYkpRMGVjejYxU1RORUpqV1oxSGdJTDBz?=
 =?utf-8?B?RjhDNW56WHhvY3dnR1l2YUYrNEpZUXVRS0VXYUJKeGpUU052bWY3MFBwMmxI?=
 =?utf-8?B?cXFZN1Rhb2EvbUQvNVZNUlpNZDI1cnJOdzc0d2ZNSGRjMGh6ZkRyRlFyK09P?=
 =?utf-8?B?bXNPZ21GQ3lyR090VlhSd2QwaGVQUURMTU1wUk5pa1RrZENNSTlTbWErSEp2?=
 =?utf-8?B?NWNYSGlOMUFKRXdsZi9yMmlPVWNlK3FuNCtOeDBTY2lGMSt5dm4zUkVzU1Vk?=
 =?utf-8?B?M0VkanVMb0xjMTg4WjlvQU11TXBQZnRLQWpFNUpkdlRUTUVKNlBnTzF2NEN5?=
 =?utf-8?B?VGdIQVVaSlpGN2xoeS9Ya3FUNTlRSEZrM3NBdzJ3R3ViOWFOanlseXVBSXRK?=
 =?utf-8?B?cjdtRWFhR2NFNEcydTk5dFR6SHBtTDU2RjFZVXN6Y2NvczZlL1hYSUlVOUJJ?=
 =?utf-8?B?RE13WEJ0Y0hVc0l1MTF4djhGckFma0lKRHlGcFhqVVhiSUwzUGhjWTFMM0s2?=
 =?utf-8?B?UnZFTnR6aU0zZWhlVnh4NnRCSENvUTRtWUJMaDNYTExkUDJ4RkE5QXJ1ejRT?=
 =?utf-8?B?VjlCdkJvQmtXcXBvaFRCeWdvK2hmNi9LUGFRMDRBTjBZbVlVLzYrY0pvbEZT?=
 =?utf-8?B?aVg5ZUlkOStncFdHdGNSMjhKaG1zdWhlNDltMnF3aEJ5K2hjVU1VQ005Wncz?=
 =?utf-8?B?bjI2SlI2VFBXTXVMZTNMeE1JUnE1WHJkNU90WmUzTGFsK3Z0U1VBVGY1QktV?=
 =?utf-8?B?UCt1d1RjYkJ0RWJUemxSMVpDeG9yVDIrdjYybFhWM1ZJcGpibjZ4ZVRKaThT?=
 =?utf-8?B?a1RlS2hzUHBzbE5KcURDdW5iTVI5eXVKTzI4SE5EaTZ2UUZmaElLSlA5N2l6?=
 =?utf-8?B?UDBJSzJjWlYycDRGcWE4U2tBM203OTBEN0RmY1FRTWFMNTZZbitsZTNzSEh4?=
 =?utf-8?B?d2pzNTl3emZFdzJDOGtJZ1VUS1RPZnRROVptc1dyOEQrcHorNGlVWGMrdXRK?=
 =?utf-8?B?TFd4RFdtTWdhVGlyQ3hJOGNYaHRNTTlqaTQ4WCtGMzJlRDBoN1piVnNLUTdT?=
 =?utf-8?B?bmRJNGRDMDczQ3dBYUtjRi9YMUxnQWpTM1dNUEl6dWp4T2c5VWt6QU1ZdEdV?=
 =?utf-8?B?dUhzZEZRa3Z0WFd0ODNuS292akRiUnRMUGd4eXNhRGtacDgyb3lGeFgvT0g0?=
 =?utf-8?B?K3pxYTBFdTFTMlEvejBZT3RYbTJ4dU1zaFdFbjJiSTJRU3BocEV2dWRNTnlU?=
 =?utf-8?B?c2MyNVZYRkRYSG5QQVBGcTNNRnQ4UW1ieTJJTHNFd3hOUS9DYnhSLzNMalFJ?=
 =?utf-8?B?SitaaUlrUld0TEY1elRxZUdsMVhzRExNcklObHNZSmV3TG9sZmdtSmxSTkJz?=
 =?utf-8?B?YWNocThSd1ZScGJ3WHhpb2JqMm9TMUNVUEZzZUZqdTh5ajZQZVFYYWU0TkZG?=
 =?utf-8?B?VGRDNDVXNVZtNWhuclhLaUlmb0hhbFE1cTJobXF0YTkyMnliT25hdmdaWVhz?=
 =?utf-8?B?dDU0THBNVUI4T093Ly9Fa0VWTE1BdytQUlNJV0ZjWlhHdklPaVZaZjdjTEpD?=
 =?utf-8?B?dWR4QnZnQkNOd0I4NmhaZE56c1B0aFpkbEp6bVpOZzlsMGE5clNUbFdueXow?=
 =?utf-8?B?OUUvK0JjcENJKzJSRDdPQlUva1VFQTVxd0djVXlGV3NJTDg4N1dnbWFlVHZW?=
 =?utf-8?B?c0ErNHlBVG4vdURQNjFRWnRxNkI5L01NbWdLUWlJSC8zcUpWZDRXTzArNWNH?=
 =?utf-8?B?STBZTFBTbzNOeVpvbGlhM1NTZldsMVlnRjFYbUtCOS9aWStZbW9wNEZKOG50?=
 =?utf-8?B?b0Q0azJwOFJqT1lPVFZSMVJXUTdWQ3lOeGdBOWdJWE5vRC9UT3NnLzRiUzJF?=
 =?utf-8?Q?bjnF0vaK9b74qH3neGPUjlI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 066ea091-2216-4fc7-b731-08d9f5f04628
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3180.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 10:44:16.9852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1vDlYZAixV3nYPfCjS17zRYxKjnSpTGKrcvsjUNnFT4COs/+h5iFgsTsLo+5cw8p/hf8Kb+SPYp/Jhv7xCRTgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2154
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 22.02.2022 00:54, Eric Dumazet wrote:
> On Mon, Feb 21, 2022 at 3:26 PM Andrzej Hajda <andrzej.hajda@intel.com> wrote:
>> Library can handle allocation failures. To avoid allocation warnings
>> __GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been
>> replaced with GFP_NOWAIT in case of stack allocation on tracker free
>> call.
>>
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
>> ---
>>   lib/ref_tracker.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
>> index 2ef4596b6b36f..cae4498fcfd70 100644
>> --- a/lib/ref_tracker.c
>> +++ b/lib/ref_tracker.c
>> @@ -189,7 +189,7 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir,
>>          unsigned long entries[REF_TRACKER_STACK_ENTRIES];
>>          struct ref_tracker *tracker;
>>          unsigned int nr_entries;
>> -       gfp_t gfp_mask = gfp;
>> +       gfp_t gfp_mask = gfp | __GFP_NOWARN;
> SGTM
>
>>          unsigned long flags;
>>
>>          WARN_ON_ONCE(dir->dead);
>> @@ -237,7 +237,8 @@ int ref_tracker_free(struct ref_tracker_dir *dir,
>>                  return -EEXIST;
>>          }
>>          nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
>> -       stack_handle = stack_depot_save(entries, nr_entries, GFP_ATOMIC);
>> +       stack_handle = stack_depot_save(entries, nr_entries,
>> +                                       GFP_NOWAIT | __GFP_NOWARN);
> Last time I looked at this, __GFP_NOWARN was enforced in __stack_depot_save()

You are right, however I am not sure if we should count on unexpected 
(at least for me) and undocumented behavior.
Currently we do not need to rely on some hidden feature.

Regards
Andrzej

>
>>          spin_lock_irqsave(&dir->lock, flags);
>>          if (tracker->dead) {
>> --
>> 2.25.1
>>