Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp31634pxm; Tue, 22 Feb 2022 05:52:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJydC8KFl5jlGXM3sqfwQGzdSBoY/g3Rb66rEro3lBMetdAuddimW1Hk6b0d49RixEIM3HXs X-Received: by 2002:aa7:8515:0:b0:4e0:bd8:c238 with SMTP id v21-20020aa78515000000b004e00bd8c238mr24995981pfn.69.1645537930808; Tue, 22 Feb 2022 05:52:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645537930; cv=none; d=google.com; s=arc-20160816; b=lIcraSXrZHzNqmWSSQMxpaPNraj/e8SYGRtYXOg3oA9WXnWFAQv0M/Gh2WiKdfNsEa 79amG2v47bIE1XiOiESFLNilTXoxfg7p8YGUKuRyohgE7WsHpkggEvyZj889Podukmf+ UvnZYCCixPJzISveKuhnhNeu8Yl5u0LV4RlaDVhWYLx/mVmKb3f1xsdl71DhPrQW/8u1 ExXWFazK7Mv81nxMAcoAbXVK1LPZt54WXT5XGiDVwQ7CdH6P8O42MSjpldrs6cdV94qC py10l2l2v8W2u+Lz5sDLRwL4QGyZLfKD/XN1qVicxdpGCB4mvG89BbF+YLStXtrCp9ct XBfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=3Ch3p/AFzlZVtjPcB9Sm6tlBBenO8zpATKp8t2BYB6I=; b=phPRNOKvi52ggoh91+XdJjWAwhRirGZS+VBS54j+4O51tivsZ/8p7+oeROoWFlBntA SWp9SZMF6/d3pFzzwFoOFWticsTIRKsupyNzeKqHJbNnC73NGxdIfbzqCJU3KLsZOzWx ICR7OgiVdrG2IcQbP/EJRS9jYst//d4xzKQBfAwej9ksYMHTB61BwFzSDG3MWGrlt+He MDgmjqa7nyhb2fR+cAKhSzKDuGF27E1USLzmXOlhR7iKZ1bDsAuCPHk4JX53ZZXdXXv5 6Geqv1q/Wwj3duQFfliaXe8x1pClWr3U2fdor9QC4nw1KcGIbEg42IxhrNUGnl/1mfa8 +nkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8si2336995pfa.193.2022.02.22.05.51.53; Tue, 22 Feb 2022 05:52:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232207AbiBVNhk (ORCPT + 99 others); Tue, 22 Feb 2022 08:37:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231440AbiBVNhj (ORCPT ); Tue, 22 Feb 2022 08:37:39 -0500 Received: from p3plsmtpa07-06.prod.phx3.secureserver.net (p3plsmtpa07-06.prod.phx3.secureserver.net [173.201.192.235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ACD2192BA for ; Tue, 22 Feb 2022 05:37:10 -0800 (PST) Received: from localhost ([82.17.115.212]) by :SMTPAUTH: with ESMTPA id MVLonjBopdsXDMVLpnM6Jf; Tue, 22 Feb 2022 06:37:10 -0700 X-CMAE-Analysis: v=2.4 cv=ZLASJV3b c=1 sm=1 tr=0 ts=6214e706 a=9gipVNR6X1CoIeAWHwLoWw==:117 a=9gipVNR6X1CoIeAWHwLoWw==:17 a=IkcTkHD0fZMA:10 a=20KFwNOVAAAA:8 a=j-GoWnyPFWeJtNoJgLoA:9 a=QEXdDO2ut3YA:10 X-SECURESERVER-ACCT: atomlin@atomlin.com Date: Tue, 22 Feb 2022 13:37:08 +0000 From: Aaron Tomlin To: Christophe Leroy Cc: Aaron Tomlin , "mcgrof@kernel.org" , "cl@linux.com" , "pmladek@suse.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "void@manifault.com" , "allen.lkml@gmail.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" Subject: Re: [PATCH v7 05/13] module: Move latched RB-tree support to a separate file Message-ID: <20220222133708.tew4wxhkf5hpkg2u@ava.usersys.com> References: <20220222130911.1348513-1-atomlin@redhat.com> <20220222130911.1348513-6-atomlin@redhat.com> <8ed19f41-625a-154f-096c-ae7ea19a9649@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8ed19f41-625a-154f-096c-ae7ea19a9649@csgroup.eu> X-CMAE-Envelope: MS4xfH8N2fumSewoTMn9SJibgCg3aysMctgxzFqQ0FzPkDdCexLi5prNkq9ZxW8LQvuNr9W0hZTqRUOIvOuTVrBRkjd84KNOVluyHcTLuWkiDbgLIObPT5PY Eo45c5/nKDApOLEQMD5uDSYNISMNXaLM/QSJmNbPmeFZUOwCaTgtOvV43/NaHkMNyZkHorNjCwm0x6/JNQuUtcoiGd8rdZq/W7VlAAjA0lGZvtvhEAp8cphP jOKhOH5Lz+54qf30GP9O5uDWMw1lNyDVnIvvELlHF85TZ9NPkVfsker4g12wG6A5IXY5qXGqNuwr5OqSnLJXbXM5rmQ4ymyW5gsvDZfM4mEbjEFyCaBJjy7C 0Ybl1asxwjhrSb6kxKzZMHwCAuljUdW2vOgPEx05bLTZ6ZE7p4+Ub8W1adlgEyfUumk0RJdBwnS3p7PWLOlxXYsh9a/xp8esdceOiqUIg8JsfqC8ZmhmQ564 lLPYmGWO0ltHmetZ67ktaQWAIMoMB1Z/9g3d9QqrhYVOk4FOL9pNTUYZmVLAYMJ0R6nnN7PknMxPjJIDhnbk29IuweH4NJyQqpF/4R6PKkSStrJEAwf4bxb8 fkwZD0rJ1HxlSuKxuEMf4lOqnGD6OTINVFN1fgFWD7AkcQ== X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2022-02-22 13:32 +0000, Christophe Leroy wrote: > Le 22/02/2022 à 14:09, Aaron Tomlin a écrit : > > No functional change. > > > > This patch migrates module latched RB-tree support > > (e.g. see __module_address()) from core module code > > into kernel/module/tree_lookup.c. > > > > Signed-off-by: Aaron Tomlin > > --- > > kernel/module/Makefile | 3 + > > kernel/module/internal.h | 33 +++++++++ > > kernel/module/main.c | 130 ++---------------------------------- > > kernel/module/tree_lookup.c | 109 ++++++++++++++++++++++++++++++ > > 4 files changed, 149 insertions(+), 126 deletions(-) > > create mode 100644 kernel/module/tree_lookup.c > > > > diff --git a/kernel/module/Makefile b/kernel/module/Makefile > > index ed3aacb04f17..e8413975bf1d 100644 > > --- a/kernel/module/Makefile > > +++ b/kernel/module/Makefile > > @@ -11,3 +11,6 @@ obj-y += main.o > > obj-$(CONFIG_MODULE_DECOMPRESS) += decompress.o > > obj-$(CONFIG_MODULE_SIG) += signing.o > > obj-$(CONFIG_LIVEPATCH) += livepatch.o > > +ifdef CONFIG_MODULES > > This ifdef is not needed anymore. > > > +obj-$(CONFIG_MODULES_TREE_LOOKUP) += tree_lookup.o > > +endif Oops! Apologies this was an oversight. -- Aaron Tomlin